Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OAS] Add more Elasticsearch query rule examples #164386

Merged
merged 2 commits into from
Aug 28, 2023
Merged

[OAS] Add more Elasticsearch query rule examples #164386

merged 2 commits into from
Aug 28, 2023

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Aug 22, 2023 •
edited by kibanamachine
Loading

Summary

Relates to #161685

This PR adds a second example of creating an Elasticsearch query rule. In this case, it uses query DSL and has two actions that use a server log connector. The purpose of the latter is to demonstrate that Elasticsearch query rules support alert summaries.

@lcawl lcawl added Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) docs v8.11.0 labels Aug 22, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lcawl lcawl marked this pull request as ready for review August 22, 2023 02:18
@lcawl lcawl requested a review from a team as a code owner August 22, 2023 02:18
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@lcawl lcawl added v8.10.0 and removed backport:skip This commit does not require backporting labels Aug 25, 2023
mikecote
mikecote approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lcawl lcawl merged commit eaf9269 into elastic:main Aug 28, 2023
@lcawl lcawl deleted the es-query-rule-example branch August 28, 2023 18:25
@kibanamachine kibanamachine mentioned this pull request Aug 28, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 28, 2023
@lcawl
[OAS] Add more Elasticsearch query rule examples (elastic#164386)
8bd6509 
(cherry picked from commit eaf9269)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.10

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Aug 28, 2023
@kibanamachine @lcawl
[8.10] [OAS] Add more Elasticsearch query rule examples (#164386) (#1…
ee5c73d 
…65031)

# Backport

This will backport the following commits from `main` to `8.10`:
- [[OAS] Add more Elasticsearch query rule examples
(#164386)](#164386)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Lisa
Cawley","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-08-28T18:25:53Z","message":"[OAS]
Add more Elasticsearch query rule examples
(#164386)","sha":"eaf9269667db66a5b69eb137e3444830b8b33cb6","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Alerting","release_note:skip","Team:ResponseOps","docs","v8.10.0","v8.11.0"],"number":164386,"url":"https://github.com/elastic/kibana/pull/164386","mergeCommit":{"message":"[OAS]
Add more Elasticsearch query rule examples
(#164386)","sha":"eaf9269667db66a5b69eb137e3444830b8b33cb6"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/164386","number":164386,"mergeCommit":{"message":"[OAS]
Add more Elasticsearch query rule examples
(#164386)","sha":"eaf9269667db66a5b69eb137e3444830b8b33cb6"}}]}]
BACKPORT-->

Co-authored-by: Lisa Cawley <[email protected]>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Aug 29, 2023
@jloleysens
Merge branch 'main' into run-migrations-on-migrator
44333f6 
* main: (40 commits)
  Adjust migrations and elasticsearch service settings for serverless. (elastic#165050)
  [Security Solution] expandable flyout - add investigate in timeline f… (elastic#165025)
  [SecuritySolution] Hide create dashboard button from listing (elastic#164476)
  Construct HTTP log message only if needed (elastic#165057)
  [Security Solution] expandable flyout - add no data message in entities details and entities overview components (elastic#164955)
  Add functional tests for serverless security management UIs (elastic#164886)
  [api-docs] 2023-08-29 Daily api_docs build (elastic#165056)
  [Cloud Security][CIS GCP]cis gcp now use updated gcp field name + small last minute changes (elastic#164792)
  [Security Solution] Expandable flyout - update risk classification ui in entities overview (elastic#165022)
  [Security Solution] Fixes Preconfigured Connectors not working with Assistant (elastic#164900)
  [Security Solution] Coverage Overview follow-up 2 (elastic#164986)
  [DOCS] Add cross-link for other encryption key settings (elastic#165014)
  chore(slo): general enhancement (elastic#164723)
  Revert "[SOR] Allow optionally downgrading documents with a higher version model in API READ methods" (elastic#164991)
  [OAS] Add more Elasticsearch query rule examples (elastic#164386)
  [security_solution_cypress] Add support for options in EsArchiver.load (elastic#164988)
  [Event Log] Skip setting assets to hidden in serverless (elastic#164767)
  remove unneeded usages of isErrorResponse (elastic#164609)
  [Enterprise Search] Make network drive connector platinum (elastic#165007)
  [RAM] update api key to become public (elastic#164883)
  ...
This was referenced Oct 1, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikecote mikecote mikecote approved these changes

Assignees
No one assigned
Labels
docs Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.10.0 v8.11.0
Projects
No open projects
AppEx: ResponseOps - Execution & Connectors
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lcawl @apmmachine @kibana-ci @elasticmachine @kibanamachine @mikecote