[Management] Index pattern creation wizard in React! #16499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @cjcenizal |
💚 Build Succeeded |
cjcenizal
reviewed
Feb 3, 2018
| indexPatterns: $injector.get('indexPatterns'), | ||
| savedObjectsClient: $injector.get('Private')(SavedObjectsClientProvider), | ||
| kbnUrl: $injector.get('kbnUrl'), | ||
| notify: new Notifier(), |
There was a problem hiding this comment.
Looks like this isn't in use? I think it was originally needed to surface a fatal error but yours truly removed that requirement. ;)
FYI, we can use the new toastNotifications service to show a toast when the index pattern is successfully created.
There was a problem hiding this comment.
Great point! Removed
💚 Build Succeeded |
|
@cjcenizal Ready! |
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
Feb 6, 2018
* Index pattern creation wizard shell * PR feedback
chrisronline
added a commit
that referenced
this pull request
Feb 6, 2018
|
Backport 6.x: e2d249e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #15722, #15936, #16129
Background
This PR is the last step at refactoring the index pattern creation wizard from Angular to React. The management team decided to do both the EUI and React refactor at the same time.
Details
This PR removes all existing angular code for the index pattern creation wizard and replaces it with React. The functionality should be exactly the same
The file structure looks like:
components/- This contains all the parts of the index pattern creation wizardconstants/- This is where the constants used throughout index pattern creation are storedlib/- This is where helper functions exist, isolated and dependency-free