Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Response Ops] Unskip serverless alerting rule tests #165514

Merged
merged 6 commits into from
Sep 5, 2023
Merged

[Response Ops] Unskip serverless alerting rule tests #165514

merged 6 commits into from
Sep 5, 2023

Conversation

ymao1
Copy link
Contributor

@ymao1 ymao1 commented Sep 1, 2023 •
edited
Loading

Resolves #165145

Summary

Serverless alerting tests are now working, likely after the PR to support datastreams in AAD, so tests can be unskipped.

Can see the test being run as part of the serverless security tests, the serverless search tests and the serverless observability tests

@ymao1 ymao1 changed the title Unskipping test [Response Ops] Unskip serverless alerting rule tests Sep 1, 2023
@ymao1 ymao1 force-pushed the unskip-serverless-alerting-tests branch from 67465c3 to 4ece8cc Compare September 1, 2023 18:55
@ymao1 ymao1 marked this pull request as ready for review September 1, 2023 20:58
@ymao1 ymao1 requested a review from a team September 1, 2023 20:58
@ymao1 ymao1 self-assigned this Sep 1, 2023
@ymao1 ymao1 added release_note:skip Skip the PR/issue when compiling release notes v8.11.0 Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Sep 1, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@ymao1
Copy link
Contributor Author

ymao1 commented Sep 5, 2023

@elasticmachine merge upstream

ersin-erdal
ersin-erdal approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@ersin-erdal ersin-erdal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ymao1
Copy link
Contributor Author

ymao1 commented Sep 5, 2023

@elasticmachine merge upstream

@kibanamachine kibanamachine requested a review from a team as a code owner September 5, 2023 12:33
@ymao1
Copy link
Contributor Author

ymao1 commented Sep 5, 2023

@elasticmachine merge upstream

@ymao1 ymao1 removed the request for review from a team September 5, 2023 13:09
@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 5, 2023 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Serverless Security Investigations Cypress Tests #2 / Export timelines Exports a custom timeline template Exports a custom timeline template
  • [job] [logs] Serverless Security Explore Cypress Tests #1 / Pagination All users and all Hosts tables reset all Hosts pagination when sorting column reset all Hosts pagination when sorting column
  • [job] [logs] Serverless Security Explore Cypress Tests #1 / Pagination All users and all Hosts tables reset all users pagination when sorting column reset all users pagination when sorting column
  • [job] [logs] Serverless Security Explore Cypress Tests #1 / Pagination Host uncommon processes table) "before all" hook for "pagination updates results and page number" "before all" hook for "pagination updates results and page number"
  • [job] [logs] Serverless Observability Examples Tests / serverless examples UI Search examples handling warnings with search source fetch "after all" hook for "able to handle shard failure warnings and prevent default notifications"
  • [job] [logs] Serverless Observability Examples Tests / serverless examples UI Search examples handling warnings with search source fetch "before all" hook for "shows shard failure warning notifications by default"

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ymao1

@ymao1 ymao1 merged commit 74f3ba2 into elastic:main Sep 5, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Sep 5, 2023
@ymao1 ymao1 deleted the unskip-serverless-alerting-tests branch September 5, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ersin-erdal ersin-erdal ersin-erdal approved these changes

Assignees

@ymao1 ymao1

Labels
backport:skip This commit does not require backporting Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[serverless] Response Ops ESS test skips
5 participants
@ymao1 @elasticmachine @kibana-ci @ersin-erdal @kibanamachine