Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SecuritySolution] Fix TypeScript errors #167147

Merged
merged 8 commits into from
Sep 27, 2023
Merged

[SecuritySolution] Fix TypeScript errors #167147

merged 8 commits into from
Sep 27, 2023

Conversation

janmonschke
Copy link
Contributor

Summary

Fixes various TypeScript errors in security solution and associated modules/plugins.

@janmonschke janmonschke added release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Investigations Team labels Sep 25, 2023
janmonschke
janmonschke commented Sep 25, 2023
View reviewed changes
x-pack/plugins/security_solution/public/common/components/markdown_editor/plugins/index.ts
@@ -5,6 +5,8 @@
* 2.0.
*/

// TODO: This import can be removed, once https://github.com/elastic/eui/pull/7221 made its way into Kibana main
import type { DefaultEuiMarkdownProcessingPlugins } from '@elastic/eui/src/components/markdown_editor/plugins/markdown_default_plugins/processing_plugins';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linking elastic/eui#7221 here to keep track of it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janmonschke , now that the linked PR is merged. Do you want to go ahead and remove the import in this PR only?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@logeekal Oh, did they already update EUI in Kibana?

Copy link
Contributor

@patrykkopycinski patrykkopycinski Sep 26, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, #166868

@janmonschke janmonschke marked this pull request as ready for review September 25, 2023 13:28
@janmonschke janmonschke requested review from a team as code owners September 25, 2023 13:28
janmonschke
janmonschke commented Sep 25, 2023
View reviewed changes
x-pack/plugins/security_solution/public/common/components/markdown_editor/plugins/index.ts
};
export const nonStatefulUiPlugins = getDefaultEuiMarkdownUiPlugins();
export const parsingPlugins = getDefaultEuiMarkdownParsingPlugins();
// TODO: This explicit type can be removed, once https://github.com/elastic/eui/pull/7221 made its way into Kibana main
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linking elastic/eui#7221 here to keep track of it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@janmonschke
Copy link
Contributor Author

@elasticmachine merge upstream

@janmonschke janmonschke force-pushed the thi-typescript-fixes branch 4 times, most recently from 1cb66cf to 16ef116 Compare September 26, 2023 14:36
stephmilovic
stephmilovic approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@stephmilovic stephmilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from explore side, thanks for the fix!

@patrykkopycinski patrykkopycinski added the ci:skip-cypress-osquery Skips osquery cypress checks label Sep 26, 2023
michaelolo24
michaelolo24 approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@michaelolo24 michaelolo24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the fixes!

watson
watson approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@watson watson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've verified that the 11 TypeScript errors coming from x-pack/test_serverless/tsconfig.json in the "Check Types Commit Diff" check are not related to this PR and so we can safely merge it as long as the other CI checks are green and all reviews are positive.

@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 27, 2023 •
edited
Loading

💔 Build Failed

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 12.8MB 12.8MB -427.0B

History

  • 💔 Build #162692 failed c6a0d20b53398d6f94328547033f07cc4345610a
  • 💔 Build #162592 failed d9c2abfbc1d75ca92c00eca6fa85890384ecaea7
  • 💔 Build #162459 failed 16ef116ecacb5ba4b3e92665a9218fbc5d8bfc34
  • 💔 Build #162295 failed 1cb66cffeaa925206c24136a7e918ed05bdf8a54

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@watson watson merged commit 26873af into elastic:main Sep 27, 2023
@kibanamachine kibanamachine added v8.11.0 backport:skip This commit does not require backporting labels Sep 27, 2023
@watson
Copy link
Contributor

watson commented Sep 27, 2023

Force merged to get around unrelated TypeScript errors and flaky tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@logeekal logeekal logeekal left review comments

@michaelolo24 michaelolo24 michaelolo24 approved these changes

@joeypoon joeypoon joeypoon approved these changes

@stephmilovic stephmilovic stephmilovic approved these changes

@watson watson watson approved these changes

@patrykkopycinski patrykkopycinski Awaiting requested review from patrykkopycinski patrykkopycinski was automatically assigned from elastic/security-defend-workflows

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting ci:skip-cypress-osquery Skips osquery cypress checks release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Investigations Team v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@janmonschke @kibana-ci @watson @patrykkopycinski @stephmilovic @logeekal @joeypoon @michaelolo24 @kibanamachine @tomsonpl