feat: add back minBarHeight on discover histogram

src/plugins/chart_expressions/expression_xy/common/__mocks__/index.ts

@@ -87,6 +87,7 @@ export const createArgsWithLayers = (
   layers: DataLayerConfig | DataLayerConfig[] = sampleLayer
 ): XYProps => ({
   showTooltip: true,
+  minBarHeight: 1,
   legend: {
     type: 'legendConfig',
     isVisible: false,

src/plugins/chart_expressions/expression_xy/common/expression_functions/common_xy_args.ts

@@ -103,4 +103,8 @@ export const commonXYArgs: CommonXYFn['args'] = {
     types: ['string'],
     help: strings.getMinTimeBarIntervalHelp(),
   },
+  minBarHeight: {
+    types: ['number'],
+    help: strings.getMinBarHeightHelp(),
+  },
 };

src/plugins/chart_expressions/expression_xy/common/expression_functions/layered_xy_vis_fn.ts

@@ -55,6 +55,7 @@ export const layeredXyVisFn: LayeredXyVisFn['fn'] = async (data, args, handlers)
       args: {
         ...args,
         layers,
+        minBarHeight: args.minBarHeight ?? 1,
         markSizeRatio: hasMarkSizeAccessors && !args.markSizeRatio ? 10 : args.markSizeRatio,
         ariaLabel:
           args.ariaLabel ??

src/plugins/chart_expressions/expression_xy/common/expression_functions/validate.ts

@@ -109,6 +109,11 @@ export const errors = {
         defaultMessage: '`minTimeBarInterval` argument is applicable only for time bar charts.',
       }
     ),
+  invalidMinBarHeightError: () =>
+    i18n.translate('expressionXY.reusable.function.xyVis.errors.invalidMinBarHeightError', {
+      defaultMessage:
+        'The min bar height should be a positive integer, representing pixel height of the bar.',
+    }),
   axisIsNotAssignedError: (axisId: string) =>
     i18n.translate('expressionXY.reusable.function.xyVis.errors.axisIsNotAssignedError', {
       defaultMessage:
@@ -297,3 +302,9 @@ export const validateMinTimeBarInterval = (
     }
   }
 };
+
+export const validateMinBarHeight = (minBarHeight?: number) => {
+  if (minBarHeight !== undefined && minBarHeight < 0) {
+    throw new Error(errors.invalidMinBarHeightError());
+  }
+};

src/plugins/chart_expressions/expression_xy/common/expression_functions/xy_vis_fn.ts

@@ -28,6 +28,7 @@ import {
   validatePointsRadiusForChartType,
   validateLinesVisibilityForChartType,
   validateAxes,
+  validateMinBarHeight,
 } from './validate';
 import { logDatatable } from '../utils';
 
@@ -111,6 +112,7 @@ export const xyVisFn: XyVisFn['fn'] = async (data, args, handlers) => {
   validateFillOpacity(args.fillOpacity, hasArea);
   validateAddTimeMarker(dataLayers, args.addTimeMarker);
   validateMinTimeBarInterval(dataLayers, hasBar, args.minTimeBarInterval);
+  validateMinBarHeight(args.minBarHeight);
 
   validateValueLabels(args.valueLabels, hasBar);
   validateMarkSizeRatioWithAccessor(args.markSizeRatio, dataLayers[0].markSizeAccessor);
@@ -127,6 +129,7 @@ export const xyVisFn: XyVisFn['fn'] = async (data, args, handlers) => {
       args: {
         ...restArgs,
         layers,
+        minBarHeight: args.minBarHeight ?? 1,
         markSizeRatio:
           dataLayers[0].markSizeAccessor && !args.markSizeRatio ? 10 : args.markSizeRatio,
         ariaLabel:

src/plugins/chart_expressions/expression_xy/common/i18n/index.tsx

@@ -121,6 +121,10 @@ export const strings = {
     i18n.translate('expressionXY.xyVis.xAxisInterval.help', {
       defaultMessage: 'Specifies the min interval for time bar chart',
     }),
+  getMinBarHeightHelp: () =>
+    i18n.translate('expressionXY.xyVis.minBarHeight.help', {
+      defaultMessage: 'Specifies the min bar height in pixels for bar chart',
+    }),
   getSplitColumnAccessorHelp: () =>
     i18n.translate('expressionXY.xyVis.splitColumnAccessor.help', {
       defaultMessage: 'Specifies split column of the xy chart',

src/plugins/chart_expressions/expression_xy/common/types/expression_functions.ts

@@ -233,6 +233,7 @@ export interface XYArgs extends DataLayerArgs {
   addTimeMarker?: boolean;
   markSizeRatio?: number;
   minTimeBarInterval?: string;
+  minBarHeight?: number;
   splitRowAccessor?: ExpressionValueVisDimension | string;
   splitColumnAccessor?: ExpressionValueVisDimension | string;
   detailedTooltip?: boolean;
@@ -284,6 +285,7 @@ export interface LayeredXYArgs {
   addTimeMarker?: boolean;
   markSizeRatio?: number;
   minTimeBarInterval?: string;
+  minBarHeight?: number;
   orderBucketsBySum?: boolean;
   showTooltip: boolean;
   splitRowAccessor?: ExpressionValueVisDimension | string;
@@ -307,6 +309,7 @@ export interface XYProps {
   addTimeMarker?: boolean;
   markSizeRatio?: number;
   minTimeBarInterval?: string;
+  minBarHeight: number;
   splitRowAccessor?: ExpressionValueVisDimension | string;
   splitColumnAccessor?: ExpressionValueVisDimension | string;
   detailedTooltip?: boolean;

src/plugins/chart_expressions/expression_xy/public/components/data_layers.tsx

@@ -8,6 +8,7 @@
 import {
   AreaSeries,
   BarSeries,
+  BarSeriesProps,
   CurveType,
   LabelOverflowConstraint,
   LineSeries,
@@ -51,6 +52,7 @@ interface Props {
   timeZone?: string;
   emphasizeFitting?: boolean;
   fillOpacity?: number;
+  minBarHeight: number;
   shouldShowValueLabels?: boolean;
   valueLabels: ValueLabelMode;
   defaultXScaleType: XScaleType;
@@ -68,6 +70,7 @@ export const DataLayers: FC<Props> = ({
   syncColors,
   valueLabels,
   fillOpacity,
+  minBarHeight,
   formatFactory,
   paletteService,
   fittingFunction,
@@ -189,22 +192,28 @@ export const DataLayers: FC<Props> = ({
                 />
               );
             case SeriesTypes.BAR:
-              const valueLabelsSettings = {
+              const valueLabelsSettings: Pick<BarSeriesProps, 'displayValueSettings'> = {
                 displayValueSettings: {
                   // This format double fixes two issues in elastic-chart
                   // * when rotating the chart, the formatter is not correctly picked
                   // * in some scenarios value labels are not strings, and this breaks the elastic-chart lib
                   valueFormatter: (d: unknown) => yAxis?.formatter?.convert(d) || '',
                   showValueLabel: shouldShowValueLabels && valueLabels !== ValueLabelModes.HIDE,
-                  isValueContainedInElement: false,
                   isAlternatingValueLabel: false,
                   overflowConstraints: [
                     LabelOverflowConstraint.ChartEdges,
                     LabelOverflowConstraint.BarGeometry,
                   ],
                 },
               };
-              return <BarSeries key={index} {...seriesProps} {...valueLabelsSettings} />;
+              return (
+                <BarSeries
+                  key={index}
+                  {...seriesProps}
+                  {...valueLabelsSettings}
+                  minBarHeight={minBarHeight}
+                />
+              );
             case SeriesTypes.AREA:
               return (
                 <AreaSeries

src/plugins/chart_expressions/expression_xy/public/components/xy_chart.test.tsx

@@ -2510,6 +2510,7 @@ describe('XYChart component', () => {
 
     const args: XYProps = {
       showTooltip: true,
+      minBarHeight: 1,
       legend: { type: 'legendConfig', isVisible: false, position: Position.Top },
       valueLabels: 'hide',
       yAxisConfigs: [
@@ -2618,6 +2619,7 @@ describe('XYChart component', () => {
     const args: XYProps = {
       legend: { type: 'legendConfig', isVisible: false, position: Position.Top },
       valueLabels: 'hide',
+      minBarHeight: 1,
       yAxisConfigs: [
         {
           type: 'yAxisConfig',
@@ -2706,6 +2708,7 @@ describe('XYChart component', () => {
 
     const args: XYProps = {
       showTooltip: true,
+      minBarHeight: 1,
       legend: { type: 'legendConfig', isVisible: true, position: Position.Top },
       valueLabels: 'hide',
       yAxisConfigs: [

src/plugins/chart_expressions/expression_xy/public/components/xy_chart.tsx

@@ -948,6 +948,7 @@ export function XYChart({
               syncColors={syncColors}
               valueLabels={valueLabels}
               fillOpacity={args.fillOpacity}
+              minBarHeight={args.minBarHeight}
               formatFactory={formatFactory}
               paletteService={paletteService}
               fittingFunction={fittingFunction}

src/plugins/unified_histogram/public/chart/utils/get_lens_attributes.test.ts

@@ -176,6 +176,7 @@ describe('getLensAttributes', () => {
                 "position": "right",
                 "shouldTruncate": false,
               },
+              "minBarHeight": 2,
               "preferredSeriesType": "bar_stacked",
               "showCurrentTimeMarker": true,
               "tickLabelsVisibilitySettings": Object {
@@ -352,6 +353,7 @@ describe('getLensAttributes', () => {
                 "position": "right",
                 "shouldTruncate": false,
               },
+              "minBarHeight": 2,
               "preferredSeriesType": "bar_stacked",
               "showCurrentTimeMarker": true,
               "tickLabelsVisibilitySettings": Object {
@@ -510,6 +512,7 @@ describe('getLensAttributes', () => {
                 "position": "right",
                 "shouldTruncate": false,
               },
+              "minBarHeight": 2,
               "preferredSeriesType": "bar_stacked",
               "showCurrentTimeMarker": true,
               "tickLabelsVisibilitySettings": Object {

src/plugins/unified_histogram/public/chart/utils/get_lens_attributes.ts

@@ -18,6 +18,7 @@ import type {
   Suggestion,
 } from '@kbn/lens-plugin/public';
 import { LegendSize } from '@kbn/visualizations-plugin/public';
+import { XYConfiguration } from '@kbn/visualizations-plugin/common';
 import { fieldSupportsBreakdown } from './field_supports_breakdown';
 
 export interface LensRequestData {
@@ -139,7 +140,7 @@ export const getLensAttributes = ({
     ? {
         ...suggestionVisualizationState,
       }
-    : {
+    : ({
         layers: [
           {
             accessors: ['count_column'],
@@ -167,6 +168,7 @@ export const getLensAttributes = ({
         preferredSeriesType: 'bar_stacked',
         valueLabels: 'hide',
         fittingFunction: 'None',
+        minBarHeight: 2,
         showCurrentTimeMarker: true,
         axisTitlesVisibilitySettings: {
           x: false,
@@ -183,7 +185,7 @@ export const getLensAttributes = ({
           yLeft: true,
           yRight: false,
         },
-      };
+      } as XYConfiguration);
   const attributes = {
     title:
       title ??

src/plugins/visualizations/common/convert_to_lens/types/configurations.ts

@@ -166,6 +166,7 @@ export interface XYConfiguration {
   labelsOrientation?: LabelsOrientationConfig;
   curveType?: XYCurveType;
   fillOpacity?: number;
+  minBarHeight?: number;
   hideEndzones?: boolean;
   valuesInLegend?: boolean;
   showCurrentTimeMarker?: boolean;

x-pack/plugins/lens/public/visualizations/xy/to_expression.ts

@@ -331,14 +331,15 @@ export const buildXYExpression = (
 
   const layeredXyVisFn = buildExpressionFunction<LayeredXyVisFn>('layeredXyVis', {
     legend: buildExpression([legendConfigFn]).toAst(),
-    fittingFunction: state.fittingFunction || 'None',
-    endValue: state.endValue || 'None',
-    emphasizeFitting: state.emphasizeFitting || false,
-    fillOpacity: state.fillOpacity || 0.3,
-    valueLabels: state?.valueLabels || 'hide',
-    hideEndzones: state?.hideEndzones || false,
-    addTimeMarker: state?.showCurrentTimeMarker || false,
-    valuesInLegend: state?.valuesInLegend || false,
+    fittingFunction: state.fittingFunction ?? 'None',
+    endValue: state.endValue ?? 'None',
+    emphasizeFitting: state.emphasizeFitting ?? false,
+    minBarHeight: state.minBarHeight ?? 1,
+    fillOpacity: state.fillOpacity ?? 0.3,
+    valueLabels: state.valueLabels ?? 'hide',
+    hideEndzones: state.hideEndzones ?? false,
+    addTimeMarker: state.showCurrentTimeMarker ?? false,
+    valuesInLegend: state.valuesInLegend ?? false,
     yAxisConfigs: [...yAxisConfigsToExpression(yAxisConfigs)],
     xAxisConfig: buildExpression([xAxisConfigFn]).toAst(),
     showTooltip: [],

x-pack/plugins/lens/public/visualizations/xy/types.ts

@@ -215,6 +215,7 @@ export interface XYState {
   labelsOrientation?: LabelsOrientationConfig;
   curveType?: XYCurveType;
   fillOpacity?: number;
+  minBarHeight?: number;
   hideEndzones?: boolean;
   showCurrentTimeMarker?: boolean;
   valuesInLegend?: boolean;