Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution ] Fix flake in /prebuilt_rules/fleet_integration.ts API Integration test #169791

Merged
merged 6 commits into from
Oct 27, 2023
Merged

[Security Solution ] Fix flake in /prebuilt_rules/fleet_integration.ts API Integration test #169791

merged 6 commits into from
Oct 27, 2023

Conversation

jpdjere
Copy link
Contributor

@jpdjere jpdjere commented Oct 25, 2023 •
edited by kibanamachine
Loading

Fixes: #167056

Summary

  • Flake cannot be reproduced on 500 runs on flaky test runner.
  • Latest fail points to a socket timeout error and not an issue intrinsic to the test; and a subsequent retry makes the test pass.
  • Unskipping test.

Flaky test runs

@jpdjere jpdjere self-assigned this Oct 26, 2023
@jpdjere jpdjere added release_note:skip Skip the PR/issue when compiling release notes Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team v8.11.0 v8.12.0 labels Oct 26, 2023
@jpdjere jpdjere marked this pull request as ready for review October 26, 2023 09:41
@jpdjere jpdjere requested a review from a team as a code owner October 26, 2023 09:41
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@jpdjere jpdjere added the Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area label Oct 26, 2023
@banderror banderror requested a review from maximpn October 26, 2023 12:29
@jpdjere jpdjere requested a review from maximpn October 27, 2023 12:27
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jpdjere

@maximpn maximpn merged commit 8bf2931 into elastic:main Oct 27, 2023
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.11 Cherrypick failed because the selected commit (8bf2931) is empty. Did you already backport this commit?

Manual backport

To create the backport manually run:

node scripts/backport --pr 169791

Questions ?

Please refer to the Backport tool documentation

@banderror
Copy link
Contributor

banderror commented Oct 27, 2023 •
edited
Loading

@maximpn @jpdjere the backport has failed
UPD: which also led to reopening the ticket #167056 (comment)

@jpdjere jpdjere mentioned this pull request Oct 30, 2023
Closed
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 169791 locally

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 16, 2024
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 169791 locally

@jpdjere jpdjere added the backport:skip This commit does not require backporting label Mar 19, 2024
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximpn maximpn maximpn approved these changes

Assignees

@jpdjere jpdjere

Labels
backport:skip This commit does not require backporting Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area release_note:skip Skip the PR/issue when compiling release notes Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.11.0 v8.12.0
Projects
None yet
Milestone
No milestone
6 participants
@jpdjere @elasticmachine @kibana-ci @kibanamachine @banderror @maximpn