[ResponseOps] Hyperlinks in Slack messages are broken when there is "_" or "*" in the URL

[doakalexi]

Resolves #165673

Summary

escapeSlack function in the mustasche_renderer breakes the hyperlinks by wrapping the URL with backticks.
So the below markdown template does not work.

<{{context.alertDetailsUrl}}|View alert details>

This PR removes the code that adds backticks.
With this change action variables with text wrapped in asterisks *text* will render as text or wrapped in underscores _text_ will render as text .

Checklist

• Unit or functional tests were updated or added to match the most common scenarios

To verify

• Create a slack connector
• Create a rule that uses a slack connector and use the above markdown template
• Verify that hyperlink is working properly in slack

[elasticmachine]

Pinging @elastic/response-ops (Team:ResponseOps)

[pmuellr]

This feels like it's too broad of a change. The reason we escape variable content containing * or _ is to prevent Slack from treating these as bold or italic. By removing this escaping completely, variables with those characters will end up causing probably unwanted style changes in the message.

I wonder if we can be a little more specific. Could we check if the value is a URL (see if URL.parse() or whatever doesn't throw an error)? If it IS a URL, do something different, otherwise do the existing thing (wrap the whole thing in back-tics).

As an additional thought, I wonder if we should uri encode the URL while we're at it? This would fix some additional issues, but is somewhat magical, so my brain says no ...

[doakalexi]

Resolved in this commit 1c76b5f

[pmuellr]

LGTM. Tested by setting server.publicBaseUrl: http://local_host:5601/, and then adding a Slack action that renders {{kibanaBaseUrl}} - no back tics!

[kibana-ci]

💛 Build succeeded, but was flaky

• Buildkite Build
• Commit: ca06438

Failed CI Steps

• Security Solution Cypress Tests #10

Test Failures

• [job] [logs] Security Solution Cypress Tests #10 / Changing alert status Opening alerts can mark a closed alert as open can mark a closed alert as open

Metrics [docs]

✅ unchanged

History

• 💚 Build #171898 succeeded b49ba2d
• 💚 Build #171703 succeeded e8329e6
• 💔 Build #171670 failed ce775bd

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream