-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Shareable Dashboards] Update spaces for new references on save #171005
Draft
cqliu1
wants to merge
14
commits into
elastic:shareable-dashboards
Choose a base branch
from
cqliu1:update-spaces-for-references
base: shareable-dashboards
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[Shareable Dashboards] Update spaces for new references on save #171005
cqliu1
wants to merge
14
commits into
elastic:shareable-dashboards
from
cqliu1:update-spaces-for-references
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cqliu1
added
Feature:Dashboard
Dashboard related features
Team:Presentation
Presentation Team for Dashboard, Input Controls, and Canvas
Project:ShareToSpace
labels
Nov 10, 2023
💔 Build FailedFailed CI Steps
Test Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
…to a shared dasbhoard
…iu1/kibana into update-spaces-for-references
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:Dashboard
Dashboard related features
Project:ShareToSpace
Team:Presentation
Presentation Team for Dashboard, Input Controls, and Canvas
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Feature Branch: #168166
Related to #168241.
Related to #168287
This updates spaces for any new references added to a shared dashboard on save. This currently shares nested panels without any warning to the user that the sharing has occurred. Adding a confirmation modal warning the user that saving will share their newly added references to the same spaces as its parent dashboard in a separate PR.
This also introduced a confirmation modal warning the user when they are saving changes on a shared dashboard.
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers