Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Shareable Dashboards] Update spaces for new references on save #171005

Draft
wants to merge 14 commits into
base: shareable-dashboards
Choose a base branch
from

Conversation

cqliu1
Copy link
Contributor

@cqliu1 cqliu1 commented Nov 10, 2023

Summary

Feature Branch: #168166
Related to #168241.
Related to #168287

This updates spaces for any new references added to a shared dashboard on save. This currently shares nested panels without any warning to the user that the sharing has occurred. Adding a confirmation modal warning the user that saving will share their newly added references to the same spaces as its parent dashboard in a separate PR.

This also introduced a confirmation modal warning the user when they are saving changes on a shared dashboard.

Screenshot 2023-11-22 at 11 53 41 AM

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@cqliu1 cqliu1 added Feature:Dashboard Dashboard related features Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Project:ShareToSpace labels Nov 10, 2023
@kibana-ci
Copy link
Collaborator

kibana-ci commented Nov 27, 2023

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #8 / SpaceListInternal using custom properties with the active space, eight inactive spaces, and one unauthorized space with behaviorContext="outside-space", shows badges with button
  • [job] [logs] Jest Tests #8 / SpaceListInternal using custom properties with the active space, eight inactive spaces, and one unauthorized space with displayLimit=0, shows badges without button
  • [job] [logs] Jest Tests #8 / SpaceListInternal using custom properties with the active space, eight inactive spaces, and one unauthorized space with displayLimit=1, shows badges with button
  • [job] [logs] Jest Tests #8 / SpaceListInternal using custom properties with the active space, eight inactive spaces, and one unauthorized space with displayLimit=7, shows badges with button
  • [job] [logs] Jest Tests #8 / SpaceListInternal using custom properties with the active space, eight inactive spaces, and one unauthorized space with displayLimit=8, shows badges without button
  • [job] [logs] Jest Tests #8 / SpaceListInternal using default properties with "all spaces", the active space, six inactive spaces, and one unauthorized space shows one badge without button
  • [job] [logs] Jest Tests #8 / SpaceListInternal using default properties with only "all spaces" shows one badge without button
  • [job] [logs] Jest Tests #8 / SpaceListInternal using default properties with the active space and five inactive spaces shows badges without button
  • [job] [logs] Jest Tests #8 / SpaceListInternal using default properties with the active space and one inactive space shows one badge without button
  • [job] [logs] Jest Tests #8 / SpaceListInternal using default properties with the active space and six inactive spaces shows badges with button
  • [job] [logs] Jest Tests #8 / SpaceListInternal using default properties with the active space, five inactive spaces, and one unauthorized space shows badges without button
  • [job] [logs] Jest Tests #8 / SpaceListInternal using default properties with the active space, five inactive spaces, and two unauthorized spaces shows badges without button
  • [job] [logs] Jest Tests #8 / SpaceListInternal using default properties with the active space, six inactive spaces, and one unauthorized space shows badges with button
  • [job] [logs] Jest Tests #8 / SpaceListInternal using default properties with the active space, six inactive spaces, and two unauthorized spaces shows badges with button
  • [job] [logs] Jest Tests #8 / SpaceListInternal with a SpacesContext for a specific feature with the active space, eight inactive spaces, and one unauthorized space shows badges with button, showing disabled features at the end of the list

Metrics [docs]

‼️ ERROR: no builds found for mergeBase sha [3e64193]

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Dashboard Dashboard related features Project:ShareToSpace Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants