Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] [Serverless] Integrates Cypress in visual mode with QA environment #171107
[Security Solution] [Serverless] Integrates Cypress in visual mode with QA environment #171107
Changes from 19 commits
9b80e45
9d12316
0bdc4e7
9925a08
dabe482
d45456a
eb0de0f
3ed0458
a7366d3
ef368d1
eb188b5
8ec88f7
57d1183
7e2f4e0
5a6e17d
2facb09
b48532d
57923b2
073d7ec
b48924c
6fbfbae
7d0b6aa
7156604
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Instead of filtering out product types I'd recommend to add product types if a corresponding flag is set. It will make the implementation clearer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
tier
,endpointAddon
andcloudAddon
are only specific for running Cypress against QA env in visual mode but script consumer can specify these props in the other modes as well though it has no effect. Sinceyargs
supports commands clearer solution would to split functionality in commands with unique params.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious. Why did you decide to run curl command instead of axios?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maximpn this
addCleanupTask()
didn't accept async, that was the reason behind if there is any other solution/way, more than happy to implement it :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kibana
->Kibana
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kibana
->Kibana
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious about command naming. We have only one separate QA environment we run tests against. It turns out
qa
is a subset ofserverless
in some sense. I can imagine we have ESS QA environment in the future and this naming will have more sense.Have you considered the other options like
cypress:open:serverless-qa
?Naming in this file isn't consistent but we can improve it by sticking to one format something like
cypress:mode:env[:suites name]
.