Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Specific Cypress executions for Detection Engine team #172298

Merged
merged 16 commits into from
Dec 4, 2023

Conversation

MadameSheema
Copy link
Member

@MadameSheema MadameSheema commented Nov 30, 2023

Addresses: #153661

Summary

This PR is part of the effort we are making to have our cypres serverless tests ready for the second quality gate (QA environment - real serverless project and also part of the initial effort started by #153664.

With the introduced changes, we are creating specific Detection Engine Cypress executions for both ESS and serverless with the aim of:

  • To help to identify quickly the ownership of the tests in case of failure.
  • To help to raise specific flakiness inside the tests of the team.

In this PR:

  • We are creating a specific folder for the detection engine team
  • We are creating 2 different executions (jus exceptions and all the the tests inside the detection engine except the exceptions one) for ESS, serverless and the quality gate
  • We are integrating everything with buildkite and also adding the new executions to the flaky test suite runner
  • We are updating the readme
  • We are updating the codeowners file to be aligned with the new changes

@MadameSheema MadameSheema changed the title new detection engine folder [Security Solution] Specific Cypress executions for Detection Engine team Dec 3, 2023
@MadameSheema MadameSheema self-assigned this Dec 4, 2023
@MadameSheema MadameSheema added release_note:skip Skip the PR/issue when compiling release notes Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Engine Security Solution Detection Engine Area v8.12.0 labels Dec 4, 2023
@MadameSheema MadameSheema marked this pull request as ready for review December 4, 2023 08:59
@MadameSheema MadameSheema requested review from a team as code owners December 4, 2023 08:59
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Copy link
Contributor

@yctercero yctercero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks so much for these updates.

@MadameSheema MadameSheema enabled auto-merge (squash) December 4, 2023 19:22
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @MadameSheema

@MadameSheema MadameSheema merged commit 217a663 into elastic:main Dec 4, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Dec 4, 2023
@MadameSheema MadameSheema deleted the detection-engine-execution branch June 28, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Detection Engine Security Solution Detection Engine Area Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants