Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.12] [doclinks] propagate build flavor to getDocLinks (#172358) #173135

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.12:

Questions ?

Please refer to the Backport tool documentation

## Summary

Fix elastic#167088

Add a new `buildFlavor` (`traditional` | `serverless`) parameter to
`getDocLinks` and `getDocLinksMeta` so that the doc links generator
logic can leverage the information

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit c50f3d7)
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/config 46 47 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lists 148.7KB 148.8KB +68.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/config 10 9 -1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 374.9KB 375.1KB +169.0B
Unknown metric groups

API count

id before after diff
@kbn/config 75 76 +1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @pgayvallet

@kibanamachine kibanamachine merged commit 76e8e9a into elastic:8.12 Dec 12, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants