-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Search] Fix web crawler enabled without enterprise search #174453
Merged
sphilipse
merged 3 commits into
elastic:main
from
sphilipse:search-fix-web-crawler-accessible-without-ent-search
Jan 8, 2024
Merged
[Search] Fix web crawler enabled without enterprise search #174453
sphilipse
merged 3 commits into
elastic:main
from
sphilipse:search-fix-web-crawler-accessible-without-ent-search
Jan 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efegurkan
approved these changes
Jan 8, 2024
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 8, 2024
…74453) (#174456) # Backport This will backport the following commits from `main` to `8.12`: - [[Search] Fix web crawler enabled without enterprise search (#174453)](#174453) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sander Philipse","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-01-08T14:43:33Z","message":"[Search] Fix web crawler enabled without enterprise search (#174453)\n\n## Summary\r\n\r\nThis fixes the web crawler being accessible in Search without a running\r\nEnterprise Search node.","sha":"01093201f27a30995ac88c4f70c928aff34606aa","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:EnterpriseSearch","v8.12.0","v8.13.0"],"title":"[Search] Fix web crawler enabled without enterprise search","number":174453,"url":"https://github.com/elastic/kibana/pull/174453","mergeCommit":{"message":"[Search] Fix web crawler enabled without enterprise search (#174453)\n\n## Summary\r\n\r\nThis fixes the web crawler being accessible in Search without a running\r\nEnterprise Search node.","sha":"01093201f27a30995ac88c4f70c928aff34606aa"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","branchLabelMappingKey":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/174453","number":174453,"mergeCommit":{"message":"[Search] Fix web crawler enabled without enterprise search (#174453)\n\n## Summary\r\n\r\nThis fixes the web crawler being accessible in Search without a running\r\nEnterprise Search node.","sha":"01093201f27a30995ac88c4f70c928aff34606aa"}}]}] BACKPORT--> Co-authored-by: Sander Philipse <[email protected]>
delanni
pushed a commit
to delanni/kibana
that referenced
this pull request
Jan 11, 2024
…74453) ## Summary This fixes the web crawler being accessible in Search without a running Enterprise Search node.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release_note:skip
Skip the PR/issue when compiling release notes
Team:EnterpriseSearch
v8.12.0
v8.13.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the web crawler being accessible in Search without a running Enterprise Search node.