Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search] Fix web crawler enabled without enterprise search #174453

Conversation

sphilipse
Copy link
Member

@sphilipse sphilipse commented Jan 8, 2024

Summary

This fixes the web crawler being accessible in Search without a running Enterprise Search node.

@sphilipse sphilipse added release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.12.0 labels Jan 8, 2024
@sphilipse sphilipse marked this pull request as ready for review January 8, 2024 13:36
@sphilipse sphilipse requested a review from a team January 8, 2024 13:36
@sphilipse sphilipse enabled auto-merge (squash) January 8, 2024 14:07
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.7MB 2.7MB +410.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sphilipse sphilipse merged commit 0109320 into elastic:main Jan 8, 2024
20 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 8, 2024
…74453)

## Summary

This fixes the web crawler being accessible in Search without a running
Enterprise Search node.

(cherry picked from commit 0109320)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.12

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 8, 2024
…74453) (#174456)

# Backport

This will backport the following commits from `main` to `8.12`:
- [[Search] Fix web crawler enabled without enterprise search
(#174453)](#174453)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Sander
Philipse","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-01-08T14:43:33Z","message":"[Search]
Fix web crawler enabled without enterprise search (#174453)\n\n##
Summary\r\n\r\nThis fixes the web crawler being accessible in Search
without a running\r\nEnterprise Search
node.","sha":"01093201f27a30995ac88c4f70c928aff34606aa","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:EnterpriseSearch","v8.12.0","v8.13.0"],"title":"[Search]
Fix web crawler enabled without enterprise
search","number":174453,"url":"https://github.com/elastic/kibana/pull/174453","mergeCommit":{"message":"[Search]
Fix web crawler enabled without enterprise search (#174453)\n\n##
Summary\r\n\r\nThis fixes the web crawler being accessible in Search
without a running\r\nEnterprise Search
node.","sha":"01093201f27a30995ac88c4f70c928aff34606aa"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","branchLabelMappingKey":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/174453","number":174453,"mergeCommit":{"message":"[Search]
Fix web crawler enabled without enterprise search (#174453)\n\n##
Summary\r\n\r\nThis fixes the web crawler being accessible in Search
without a running\r\nEnterprise Search
node.","sha":"01093201f27a30995ac88c4f70c928aff34606aa"}}]}] BACKPORT-->

Co-authored-by: Sander Philipse <[email protected]>
delanni pushed a commit to delanni/kibana that referenced this pull request Jan 11, 2024
…74453)

## Summary

This fixes the web crawler being accessible in Search without a running
Enterprise Search node.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.12.0 v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants