[Security Solution] JSON diffs test plan #175958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikitaindik
requested review from
jpdjere and
maximpn
and removed request for
jpdjere
nikitaindik
added
release_note:skip
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
|
Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
@nikitaindik Let's please request review from someone who's working on the epic. |
maximpn
approved these changes
Jan 31, 2024
...lution/docs/testing/test_plans/detection_response/prebuilt_rules/installation_and_upgrade.md
Outdated
Show resolved
Hide resolved
|
|
||
| #### **Scenario: User can see precisely how property values would change after upgrade** | ||
|
|
||
| **Automation**: 1 UI component-level test |
There was a problem hiding this comment.
Does UI component-level test represent a unit test or it's something different?
There was a problem hiding this comment.
I envisioned it to be a react-testing-library test where I would render the flyout passing it the current rule and the updated rule as props. Not sure if this can be considered a "unit test", probably more like "integration test". Would "UI integration test" work better?
|
@nikitaindik Can you add a Table of Contents at the beggining? The file has become large enough already that is hard to navigate or have an overview in mind of the sections: |
jpdjere
reviewed
Feb 1, 2024
...lution/docs/testing/test_plans/detection_response/prebuilt_rules/installation_and_upgrade.md
Outdated
Show resolved
Hide resolved
jpdjere
reviewed
Feb 1, 2024
| Given a rule preview with rule changes is open | ||
| Then each line of <column> that was <change_type> should have <bg_color> background | ||
| And marked with <line_badge> badge | ||
| And each changed word in <column> should be highlighted with <accent_color> |
There was a problem hiding this comment.
I cannot recall now, but we are only using only WORD diffing for the whole JSON, right? No need to test other uses cases, like character diffing.
There was a problem hiding this comment.
No, at this stage it's by word only.
jpdjere
reviewed
Feb 1, 2024
...lution/docs/testing/test_plans/detection_response/prebuilt_rules/installation_and_upgrade.md
Outdated
Show resolved
Hide resolved
jpdjere
reviewed
Feb 1, 2024
...lution/docs/testing/test_plans/detection_response/prebuilt_rules/installation_and_upgrade.md
Outdated
Show resolved
Hide resolved
jpdjere
approved these changes
Feb 1, 2024
banderror
approved these changes
Feb 1, 2024
There was a problem hiding this comment.
Scenarios look fantastic! Thank you @nikitaindik.
Left a bunch of nits.
...lution/docs/testing/test_plans/detection_response/prebuilt_rules/installation_and_upgrade.md
Outdated
Show resolved
Hide resolved
...lution/docs/testing/test_plans/detection_response/prebuilt_rules/installation_and_upgrade.md
Outdated
Show resolved
Hide resolved
...lution/docs/testing/test_plans/detection_response/prebuilt_rules/installation_and_upgrade.md
Outdated
Show resolved
Hide resolved
...lution/docs/testing/test_plans/detection_response/prebuilt_rules/installation_and_upgrade.md
Outdated
Show resolved
Hide resolved
...lution/docs/testing/test_plans/detection_response/prebuilt_rules/installation_and_upgrade.md
Outdated
Show resolved
Hide resolved
...lution/docs/testing/test_plans/detection_response/prebuilt_rules/installation_and_upgrade.md
Outdated
Show resolved
Hide resolved
...lution/docs/testing/test_plans/detection_response/prebuilt_rules/installation_and_upgrade.md
Outdated
Show resolved
Hide resolved
...lution/docs/testing/test_plans/detection_response/prebuilt_rules/installation_and_upgrade.md
Outdated
Show resolved
Hide resolved
...lution/docs/testing/test_plans/detection_response/prebuilt_rules/installation_and_upgrade.md
Show resolved
Hide resolved
nikitaindik
force-pushed
the
json-diffs-test-plan
branch
from
e356ddd to
63a30ac
Compare
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Feb 7, 2024
**Resolves: elastic#166162 This PR introduces a test plan for the JSON diff preview. This preview is displayed in the upgrade prebuilt rule flyout. <img width="1209" alt="Schermafbeelding 2024-01-31 om 10 38 51" src="https://github.com/elastic/kibana/assets/15949146/9f4ffcca-31fe-464e-9315-c90ec38696d6">
CoenWarmer
pushed a commit
to CoenWarmer/kibana
that referenced
this pull request
Feb 15, 2024
**Resolves: elastic#166162 This PR introduces a test plan for the JSON diff preview. This preview is displayed in the upgrade prebuilt rule flyout. <img width="1209" alt="Schermafbeelding 2024-01-31 om 10 38 51" src="https://github.com/elastic/kibana/assets/15949146/9f4ffcca-31fe-464e-9315-c90ec38696d6">
nikitaindik
added a commit
that referenced
this pull request
Feb 19, 2024
**Resolves: #166163 Flaky test runner runs: [1](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5189), [2](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5190), [3](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5191), [4](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5192) ## Summary This PR adds tests in accordance with the [test plan](#175958) that was merged earlier.
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 19, 2024
**Resolves: elastic#166163 Flaky test runner runs: [1](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5189), [2](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5190), [3](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5191), [4](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5192) ## Summary This PR adds tests in accordance with the [test plan](elastic#175958) that was merged earlier. (cherry picked from commit cd374d2)
kibanamachine
added a commit
that referenced
this pull request
Feb 19, 2024
# Backport This will backport the following commits from `main` to `8.13`: - [[Security Solution] JSON diffs test coverage (#176770)](#176770) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nikita Indik","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-02-19T15:12:51Z","message":"[Security Solution] JSON diffs test coverage (#176770)\n\n**Resolves: https://github.com/elastic/kibana/issues/166163**\r\n\r\nFlaky test runner runs:\r\n[1](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5189),\r\n[2](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5190),\r\n[3](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5191),\r\n[4](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5192)\r\n\r\n## Summary\r\nThis PR adds tests in accordance with the [test\r\nplan](#175958) that was merged\r\nearlier.","sha":"cd374d23368de182a96df0948192a9bca7bdc4aa","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","test-coverage","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","v8.13.0","v8.14.0"],"title":"[Security Solution] JSON diffs test coverage","number":176770,"url":"https://github.com/elastic/kibana/pull/176770","mergeCommit":{"message":"[Security Solution] JSON diffs test coverage (#176770)\n\n**Resolves: https://github.com/elastic/kibana/issues/166163**\r\n\r\nFlaky test runner runs:\r\n[1](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5189),\r\n[2](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5190),\r\n[3](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5191),\r\n[4](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5192)\r\n\r\n## Summary\r\nThis PR adds tests in accordance with the [test\r\nplan](#175958) that was merged\r\nearlier.","sha":"cd374d23368de182a96df0948192a9bca7bdc4aa"}},"sourceBranch":"main","suggestedTargetBranches":["8.13"],"targetPullRequestStates":[{"branch":"8.13","label":"v8.13.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.14.0","branchLabelMappingKey":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/176770","number":176770,"mergeCommit":{"message":"[Security Solution] JSON diffs test coverage (#176770)\n\n**Resolves: https://github.com/elastic/kibana/issues/166163**\r\n\r\nFlaky test runner runs:\r\n[1](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5189),\r\n[2](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5190),\r\n[3](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5191),\r\n[4](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5192)\r\n\r\n## Summary\r\nThis PR adds tests in accordance with the [test\r\nplan](#175958) that was merged\r\nearlier.","sha":"cd374d23368de182a96df0948192a9bca7bdc4aa"}}]}] BACKPORT--> Co-authored-by: Nikita Indik <[email protected]>
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Mar 4, 2024
**Resolves: elastic#166162 This PR introduces a test plan for the JSON diff preview. This preview is displayed in the upgrade prebuilt rule flyout. <img width="1209" alt="Schermafbeelding 2024-01-31 om 10 38 51" src="https://github.com/elastic/kibana/assets/15949146/9f4ffcca-31fe-464e-9315-c90ec38696d6">
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Mar 4, 2024
**Resolves: elastic#166163 Flaky test runner runs: [1](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5189), [2](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5190), [3](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5191), [4](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5192) ## Summary This PR adds tests in accordance with the [test plan](elastic#175958) that was merged earlier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #166162
This PR introduces a test plan for the JSON diff preview. This preview is displayed in the upgrade prebuilt rule flyout.