[ML] Single metric viewer in dashboards: adds functional test #178768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvarezmelissa87
added
:ml
Feature:Anomaly Detection
|
Pinging @elastic/ml-ui (:ml) |
3 tasks
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
11 tasks
peteharverson
approved these changes
Mar 18, 2024
| @@ -16,6 +16,7 @@ export function MachineLearningDashboardEmbeddablesProvider( | |||
| const retry = getService('retry'); | |||
| const testSubjects = getService('testSubjects'); | |||
| const find = getService('find'); | |||
| // const ml = getService('ml'); | |||
There was a problem hiding this comment.
Is this line needed?
13 tasks
qn895
reviewed
Mar 18, 2024
| @@ -16,6 +16,7 @@ export function MachineLearningDashboardEmbeddablesProvider( | |||
| const retry = getService('retry'); | |||
| const testSubjects = getService('testSubjects'); | |||
| const find = getService('find'); | |||
| // const ml = getService('ml'); | |||
qn895
reviewed
Mar 18, 2024
| await testSubjects.clickWhenNotDisabledWithoutRetry(subj); | ||
| await this.assertAnomalyChartsEmbeddableInitializerNotExists(); | ||
| }); | ||
| }, | ||
|
|
||
| async clickSingleMetricViewerInitializerConfirmButtonEnabled() { |
There was a problem hiding this comment.
does the function name clickSingleMetricViewerInitializerConfirmButtonEnabled need to reflect that the button is enabled?
qn895
reviewed
Mar 18, 2024
| ); | ||
| }); | ||
|
|
||
| it('create new single metric viewer panel', async () => { |
There was a problem hiding this comment.
Might not necessary for this test for now but might be useful in the future to also test that you can add multiple single metric viewer panels
qn895
approved these changes
Mar 18, 2024
|
Test LGTM 🎉 , just had some nit comments |
saikatsarkar056
pushed a commit
to saikatsarkar056/kibana
that referenced
this pull request
Mar 21, 2024
…c#178768) ## Summary Related meta issue: elastic#176651 This PR adds functional tests for SMV in dashboards. Flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5485 ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related meta issue: #176651
This PR adds functional tests for SMV in dashboards.
Flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5485
Checklist
Delete any items that are not applicable to this PR.