Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Cleanup, removes dashboard plugin dependency #179245

Merged
merged 5 commits into from
Mar 27, 2024
Merged

[Lens] Cleanup, removes dashboard plugin dependency #179245

merged 5 commits into from
Mar 27, 2024

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Mar 22, 2024 •
edited
Loading

Summary

Removes the dependency from the dashboard plugin as the dashboardFeatureFlag is not used anymore.

@stratoula
Copy link
Contributor Author

/ci

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.4MB 1.4MB -708.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula added technical debt Improvement of the software architecture and operational architecture release_note:skip Skip the PR/issue when compiling release notes Feature:Lens backport:skip This commit does not require backporting Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.14.0 labels Mar 26, 2024
@stratoula stratoula marked this pull request as ready for review March 26, 2024 15:18
@stratoula stratoula requested review from a team as code owners March 26, 2024 15:18
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@stratoula stratoula requested a review from ThomThomson March 26, 2024 15:19
mbondyra
mbondyra approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, didn't notice any regression 👌🏼

@stratoula stratoula merged commit d32322f into elastic:main Mar 27, 2024
28 checks passed
@drewdaemon drewdaemon mentioned this pull request Mar 27, 2024
Draft
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgayvallet pgayvallet pgayvallet approved these changes

@mbondyra mbondyra mbondyra approved these changes

@ThomThomson ThomThomson ThomThomson approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture v8.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@stratoula @kibana-ci @elasticmachine @pgayvallet @mbondyra @ThomThomson