Unskip TSVB to Lens functional test #179858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dej611
added
test_xpack_functional
release_note:skip
|
/ci |
dej611
commented
Apr 3, 2024
x-pack/test/functional/apps/lens/open_in_lens/tsvb/dashboard.ts
Outdated
Show resolved
Hide resolved
|
/ci |
|
/ci |
dej611
commented
Apr 3, 2024
|
/ci |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
mbondyra
added
the
Team:Visualizations
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #179307 and speeds up a bit the
resetPagemethod when possible via click on theVisualize listnavigation breadcrumb on the top left:The work on
navigateToNewVisualization(function called byresetPage) had some side effects for some tests where a uiSettings changes were used as shortcut for the time picker: in such case aforceRefreshoption has been provided now to cover it, but I may suggest to reduce the usage as much as possible.The new change lead to an average of ~5 minutes saving only within the
open_in_lens/tsvbtest suite, but it is a rough number as the average between the savings on the CI on the flaky runner.Probably there's an extra saving on other test suites as well.
Flaky runner for the
Open in Lens/TSVBtest suite (50x runs): https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5604Flaky runner for the
Lens - Group5test suite (50x runs): https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5606#_Checklist