-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Console Monaco Migration] Handle editor resize #180494
Merged
ElenaStoeva
merged 7 commits into
elastic:main
from
ElenaStoeva:console-monaco-migration/add-resize-handling
Apr 25, 2024
Merged
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
eeb808e
[Console Monaco Migration] Handle editor resize
ElenaStoeva d8e484e
Merge branch 'main' into console-monaco-migration/add-resize-handling
ElenaStoeva 7b1de07
Merge branch 'main' into console-monaco-migration/add-resize-handling
ElenaStoeva a4f44ee
Move logic into a hook
ElenaStoeva a78dd1e
Merge branch 'main' into console-monaco-migration/add-resize-handling
ElenaStoeva 156d61a
Fix lint errors
ElenaStoeva f02739b
Check for existing resize checker
ElenaStoeva File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35 changes: 35 additions & 0 deletions
35
src/plugins/console/public/application/containers/editor/monaco/use_resize_checker_utils.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0 and the Server Side Public License, v 1; you may not use this file except | ||
* in compliance with, at your election, the Elastic License 2.0 or the Server | ||
* Side Public License, v 1. | ||
*/ | ||
|
||
import { useRef } from 'react'; | ||
import { ResizeChecker } from '@kbn/kibana-utils-plugin/public'; | ||
import { monaco } from '@kbn/monaco'; | ||
|
||
/** | ||
* Hook that returns functions for setting up and destroying a {@link ResizeChecker} | ||
* for a Monaco editor. | ||
*/ | ||
export const useResizeCheckerUtils = () => { | ||
const resizeChecker = useRef<ResizeChecker | null>(null); | ||
|
||
const setupResizeChecker = ( | ||
divElement: HTMLDivElement, | ||
editor: monaco.editor.IStandaloneCodeEditor | ||
) => { | ||
resizeChecker.current = new ResizeChecker(divElement); | ||
resizeChecker.current.on('resize', () => { | ||
editor.layout(); | ||
}); | ||
}; | ||
|
||
const destroyResizeChecker = () => { | ||
resizeChecker.current!.destroy(); | ||
}; | ||
|
||
return { setupResizeChecker, destroyResizeChecker }; | ||
}; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggest to check if there is already a resizeChecker.current and destroy it if there is one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review @Dosant! Added this check with f02739b.