-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable heap snapshots for all our distributables #181363
Conversation
Pinging @elastic/kibana-core (Team:Core) |
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it in serverless -- everything works as expected. LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating this! LGTM. Also tested locally after building.
@marius-dr found an issue with this on Windows. Reverted with f52db83.
|
did some investigating on it. Looks like it's not supposed to work on Windows: nodejs/node#27133, and it's badly documented. |
Unfortunate, but looks like the issue is windows does not know about |
)" This reverts commit 26b8c71.
Summary
Fixes #167955
To test:
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers