Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[Entity Analytics] Move scripted metric painless scripts to static file & remove category based weighting" #183759

Merged
merged 1 commit into from
May 17, 2024

Conversation

hop-dev
Copy link
Contributor

@hop-dev hop-dev commented May 17, 2024

Reverts #182038

@hop-dev hop-dev requested a review from a team as a code owner May 17, 2024 15:55
@hop-dev hop-dev enabled auto-merge (squash) May 17, 2024 15:55
@hop-dev hop-dev self-assigned this May 17, 2024
@hop-dev hop-dev added the release_note:skip Skip the PR/issue when compiling release notes label May 17, 2024
Copy link
Contributor

@jaredburgettelastic jaredburgettelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert LGTM

@hop-dev hop-dev merged commit a81138e into main May 17, 2024
37 of 38 checks passed
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 15.1MB 15.1MB +188.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 522 521 -1

Total ESLint disabled count

id before after diff
securitySolution 604 603 -1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @hop-dev

@hop-dev hop-dev deleted the revert-182038-risk-score-painless-refactor branch May 17, 2024 17:12
@kibanamachine kibanamachine added v8.15.0 backport:skip This commit does not require backporting labels May 17, 2024
hop-dev added a commit that referenced this pull request May 20, 2024
…n (with sorting fix after test failure) (#183844)

## Summary

This code was originally approved and merged in
#182038

It was then reverted in #183759
after a [test failure](#183758).

The previous code had introduced flakiness, occasionally the inputs
would be supplied to risk scoring in the wrong order causing the score
to decrease. Re-adding the sorting in the reduce script has fixed this.

Here is the only new code:
a8cbb1c

[Flaky test
run](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6045)
🟢

---------

Co-authored-by: oatkiller <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants