Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Update esarchive ecommerce dataset, enable alerting flyout tests #186630

Merged
merged 13 commits into from
Jun 24, 2024

Conversation

darnautov
Copy link
Contributor

@darnautov darnautov commented Jun 21, 2024

Summary

Closes #186261 and #102012

  • Updates timestamps in the esarchive ecommerce data set (from 2019 to 2023)
  • Enables anomaly detection alert flyout tests

Checklist

@darnautov darnautov requested a review from a team as a code owner June 21, 2024 14:18
@darnautov darnautov added :ml test_ui_functional Team:ML Team label for ML (also use :ml) v8.15.0 labels Jun 21, 2024
@darnautov darnautov self-assigned this Jun 21, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@darnautov darnautov added the release_note:skip Skip the PR/issue when compiling release notes label Jun 21, 2024
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked the archive update and the timestamp bumps LGTM.
However, I think you'll have to update some tests that are using this archive as we're doing some assertions on timestamps IIRC.

@darnautov
Copy link
Contributor Author

@elasticmachine merge upstream

@darnautov darnautov enabled auto-merge (squash) June 24, 2024 12:32
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #12 / security app - SAML interactions URL capture resets invalid target URL

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @darnautov

@darnautov darnautov merged commit 745abf7 into elastic:main Jun 24, 2024
28 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jun 24, 2024
@darnautov
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
7.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

darnautov added a commit to darnautov/kibana that referenced this pull request Jun 26, 2024
…elastic#186630)

## Summary

Closes elastic#186261 and elastic#102012

- Updates timestamps in the esarchive ecommerce data set (from 2019 to
2023)
- Enables anomaly detection alert flyout tests

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 745abf7)

# Conflicts:
#	x-pack/test/api_integration/apis/aiops/test_data.ts
#	x-pack/test/api_integration/apis/ml/fields_service/time_field_range.ts
#	x-pack/test/api_integration/apis/ml/job_validation/validate.ts
#	x-pack/test/functional/apps/ml/anomaly_detection/multi_metric_job.ts
#	x-pack/test/functional/apps/ml/anomaly_detection_jobs/convert_jobs_to_advanced_job.ts
#	x-pack/test/functional/apps/transform/creation/index_pattern/continuous_transform.ts
#	x-pack/test/functional/apps/transform/creation_index_pattern.ts
#	x-pack/test/functional_with_es_ssl/apps/ml/alert_flyout.ts
@darnautov
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
7.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

darnautov added a commit that referenced this pull request Jul 3, 2024
…t tests (#186630) (#186943)

# Backport

Closes #102012

This will backport the following commits from `main` to `7.17`:
- [[ML] Update esarchive ecommerce dataset, enable alerting flyout tests
(#186630)](#186630)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dima
Arnautov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-06-24T13:55:29Z","message":"[ML]
Update esarchive ecommerce dataset, enable alerting flyout tests
(#186630)\n\n## Summary\r\n\r\nCloses #186261 and #102012\r\n\r\n-
Updates timestamps in the esarchive ecommerce data set (from 2019
to\r\n2023)\r\n- Enables anomaly detection alert flyout tests
\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"745abf7624c98105ef273d8d1d57730a33728c32","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","test_ui_functional","release_note:skip","backport:skip","Team:ML","v8.15.0"],"number":186630,"url":"https://github.com/elastic/kibana/pull/186630","mergeCommit":{"message":"[ML]
Update esarchive ecommerce dataset, enable alerting flyout tests
(#186630)\n\n## Summary\r\n\r\nCloses #186261 and #102012\r\n\r\n-
Updates timestamps in the esarchive ecommerce data set (from 2019
to\r\n2023)\r\n- Enables anomaly detection alert flyout tests
\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"745abf7624c98105ef273d8d1d57730a33728c32"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.15.0","labelRegex":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/186630","number":186630,"mergeCommit":{"message":"[ML]
Update esarchive ecommerce dataset, enable alerting flyout tests
(#186630)\n\n## Summary\r\n\r\nCloses #186261 and #102012\r\n\r\n-
Updates timestamps in the esarchive ecommerce data set (from 2019
to\r\n2023)\r\n- Enables anomaly detection alert flyout tests
\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"745abf7624c98105ef273d8d1d57730a33728c32"}}]}]
BACKPORT-->
adelisle pushed a commit to Makila-AI/kibana that referenced this pull request Aug 5, 2024
…t tests (elastic#186630) (elastic#186943)

# Backport

Closes elastic#102012

This will backport the following commits from `main` to `7.17`:
- [[ML] Update esarchive ecommerce dataset, enable alerting flyout tests
(elastic#186630)](elastic#186630)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dima
Arnautov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-06-24T13:55:29Z","message":"[ML]
Update esarchive ecommerce dataset, enable alerting flyout tests
(elastic#186630)\n\n## Summary\r\n\r\nCloses elastic#186261 and elastic#102012\r\n\r\n-
Updates timestamps in the esarchive ecommerce data set (from 2019
to\r\n2023)\r\n- Enables anomaly detection alert flyout tests
\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"745abf7624c98105ef273d8d1d57730a33728c32","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","test_ui_functional","release_note:skip","backport:skip","Team:ML","v8.15.0"],"number":186630,"url":"https://github.com/elastic/kibana/pull/186630","mergeCommit":{"message":"[ML]
Update esarchive ecommerce dataset, enable alerting flyout tests
(elastic#186630)\n\n## Summary\r\n\r\nCloses elastic#186261 and elastic#102012\r\n\r\n-
Updates timestamps in the esarchive ecommerce data set (from 2019
to\r\n2023)\r\n- Enables anomaly detection alert flyout tests
\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"745abf7624c98105ef273d8d1d57730a33728c32"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.15.0","labelRegex":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/186630","number":186630,"mergeCommit":{"message":"[ML]
Update esarchive ecommerce dataset, enable alerting flyout tests
(elastic#186630)\n\n## Summary\r\n\r\nCloses elastic#186261 and elastic#102012\r\n\r\n-
Updates timestamps in the esarchive ecommerce data set (from 2019
to\r\n2023)\r\n- Enables anomaly detection alert flyout tests
\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"745abf7624c98105ef273d8d1d57730a33728c32"}}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting :ml release_note:skip Skip the PR/issue when compiling release notes Team:ML Team label for ML (also use :ml) test_ui_functional v7.17.23 v8.15.0
Projects
None yet
6 participants