-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Update esarchive ecommerce dataset, enable alerting flyout tests #186630
[ML] Update esarchive ecommerce dataset, enable alerting flyout tests #186630
Conversation
Pinging @elastic/ml-ui (:ml) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've checked the archive update and the timestamp bumps LGTM.
However, I think you'll have to update some tests that are using this archive as we're doing some assertions on timestamps IIRC.
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @darnautov |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…elastic#186630) ## Summary Closes elastic#186261 and elastic#102012 - Updates timestamps in the esarchive ecommerce data set (from 2019 to 2023) - Enables anomaly detection alert flyout tests ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 745abf7) # Conflicts: # x-pack/test/api_integration/apis/aiops/test_data.ts # x-pack/test/api_integration/apis/ml/fields_service/time_field_range.ts # x-pack/test/api_integration/apis/ml/job_validation/validate.ts # x-pack/test/functional/apps/ml/anomaly_detection/multi_metric_job.ts # x-pack/test/functional/apps/ml/anomaly_detection_jobs/convert_jobs_to_advanced_job.ts # x-pack/test/functional/apps/transform/creation/index_pattern/continuous_transform.ts # x-pack/test/functional/apps/transform/creation_index_pattern.ts # x-pack/test/functional_with_es_ssl/apps/ml/alert_flyout.ts
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…t tests (#186630) (#186943) # Backport Closes #102012 This will backport the following commits from `main` to `7.17`: - [[ML] Update esarchive ecommerce dataset, enable alerting flyout tests (#186630)](#186630) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dima Arnautov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-06-24T13:55:29Z","message":"[ML] Update esarchive ecommerce dataset, enable alerting flyout tests (#186630)\n\n## Summary\r\n\r\nCloses #186261 and #102012\r\n\r\n- Updates timestamps in the esarchive ecommerce data set (from 2019 to\r\n2023)\r\n- Enables anomaly detection alert flyout tests \r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"745abf7624c98105ef273d8d1d57730a33728c32","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","test_ui_functional","release_note:skip","backport:skip","Team:ML","v8.15.0"],"number":186630,"url":"https://github.com/elastic/kibana/pull/186630","mergeCommit":{"message":"[ML] Update esarchive ecommerce dataset, enable alerting flyout tests (#186630)\n\n## Summary\r\n\r\nCloses #186261 and #102012\r\n\r\n- Updates timestamps in the esarchive ecommerce data set (from 2019 to\r\n2023)\r\n- Enables anomaly detection alert flyout tests \r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"745abf7624c98105ef273d8d1d57730a33728c32"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.15.0","labelRegex":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/186630","number":186630,"mergeCommit":{"message":"[ML] Update esarchive ecommerce dataset, enable alerting flyout tests (#186630)\n\n## Summary\r\n\r\nCloses #186261 and #102012\r\n\r\n- Updates timestamps in the esarchive ecommerce data set (from 2019 to\r\n2023)\r\n- Enables anomaly detection alert flyout tests \r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"745abf7624c98105ef273d8d1d57730a33728c32"}}]}] BACKPORT-->
…t tests (elastic#186630) (elastic#186943) # Backport Closes elastic#102012 This will backport the following commits from `main` to `7.17`: - [[ML] Update esarchive ecommerce dataset, enable alerting flyout tests (elastic#186630)](elastic#186630) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dima Arnautov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-06-24T13:55:29Z","message":"[ML] Update esarchive ecommerce dataset, enable alerting flyout tests (elastic#186630)\n\n## Summary\r\n\r\nCloses elastic#186261 and elastic#102012\r\n\r\n- Updates timestamps in the esarchive ecommerce data set (from 2019 to\r\n2023)\r\n- Enables anomaly detection alert flyout tests \r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"745abf7624c98105ef273d8d1d57730a33728c32","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","test_ui_functional","release_note:skip","backport:skip","Team:ML","v8.15.0"],"number":186630,"url":"https://github.com/elastic/kibana/pull/186630","mergeCommit":{"message":"[ML] Update esarchive ecommerce dataset, enable alerting flyout tests (elastic#186630)\n\n## Summary\r\n\r\nCloses elastic#186261 and elastic#102012\r\n\r\n- Updates timestamps in the esarchive ecommerce data set (from 2019 to\r\n2023)\r\n- Enables anomaly detection alert flyout tests \r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"745abf7624c98105ef273d8d1d57730a33728c32"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.15.0","labelRegex":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/186630","number":186630,"mergeCommit":{"message":"[ML] Update esarchive ecommerce dataset, enable alerting flyout tests (elastic#186630)\n\n## Summary\r\n\r\nCloses elastic#186261 and elastic#102012\r\n\r\n- Updates timestamps in the esarchive ecommerce data set (from 2019 to\r\n2023)\r\n- Enables anomaly detection alert flyout tests \r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"745abf7624c98105ef273d8d1d57730a33728c32"}}]}] BACKPORT-->
Summary
Closes #186261 and #102012
Checklist