Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Enable Detections API bundling in build pipeline #188436

Merged
merged 6 commits into from
Jul 17, 2024

Conversation

maximpn
Copy link
Contributor

@maximpn maximpn commented Jul 16, 2024

Addresses: #184428
Relates to: #186384

Summary

This PR enables Detections API OpenAPI bundling in build pipeline. It also fixes wrong references which weren't caught by the OpenAPI Linter and code generator.

For some reason #186384 didn't enable OpenAPI bundling by including .buildkite/scripts/steps/openapi_bundling/security_solution_openapi_bundling.sh into .buildkite/scripts/steps/checks.sh.

@maximpn maximpn added release_note:skip Skip the PR/issue when compiling release notes docs Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team v8.16.0 labels Jul 16, 2024
@maximpn maximpn self-assigned this Jul 16, 2024
@maximpn maximpn force-pushed the enable-detections-api-bundling branch from 943cbab to ea0efa3 Compare July 16, 2024 14:05
@maximpn maximpn force-pushed the enable-detections-api-bundling branch from ea0efa3 to 5a1b2b6 Compare July 16, 2024 14:09
@maximpn maximpn marked this pull request as ready for review July 16, 2024 16:10
@maximpn maximpn requested review from a team as code owners July 16, 2024 16:10
@maximpn maximpn requested review from nkhristinin and dplumlee July 16, 2024 16:10
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management)

@maximpn maximpn marked this pull request as draft July 16, 2024 16:12
@maximpn maximpn marked this pull request as ready for review July 16, 2024 16:14
@elasticmachine
Copy link
Contributor

⏳ Build in-progress, with failures

Failed CI Steps

History

cc @maximpn

@maximpn maximpn removed the request for review from dplumlee July 17, 2024 12:58
@maximpn maximpn enabled auto-merge (squash) July 17, 2024 12:58
@maximpn maximpn merged commit bd0aab6 into elastic:main Jul 17, 2024
39 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 17, 2024
@maximpn maximpn deleted the enable-detections-api-bundling branch July 17, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting docs release_note:skip Skip the PR/issue when compiling release notes Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants