Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Add new custom rule action to force time shift #188710

Merged
merged 7 commits into from
Jul 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions x-pack/packages/ml/anomaly_utils/detector_rule.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
export enum ML_DETECTOR_RULE_ACTION {
SKIP_MODEL_UPDATE = 'skip_model_update',
SKIP_RESULT = 'skip_result',
FORCE_TIME_SHIFT = 'force_time_shift',
}

/**
Expand Down Expand Up @@ -44,6 +45,20 @@ export enum ML_DETECTOR_RULE_OPERATOR {
GREATER_THAN_OR_EQUAL = 'gte',
}

/**
* Enum ML_DETECTOR_RULE_PARAMS
*/
export enum ML_DETECTOR_RULE_PARAMS {
FORCE_TIME_SHIFT = 'force_time_shift',
}

/**
* Enum ML_DETECTOR_RULE_PARAMS_FORCE_TIME_SHIFT
*/
export enum ML_DETECTOR_RULE_PARAMS_FORCE_TIME_SHIFT {
TIME_SHIFT_AMOUNT = 'time_shift_amount',
}

/**
* List of detector functions which don't support rules with numeric conditions.
*/
Expand Down
2 changes: 2 additions & 0 deletions x-pack/packages/ml/anomaly_utils/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,8 @@ export {
ML_DETECTOR_RULE_CONDITIONS_NOT_SUPPORTED_FUNCTIONS,
ML_DETECTOR_RULE_FILTER_TYPE,
ML_DETECTOR_RULE_OPERATOR,
ML_DETECTOR_RULE_PARAMS,
ML_DETECTOR_RULE_PARAMS_FORCE_TIME_SHIFT,
} from './detector_rule';

export type { InfluencersFilterQuery } from './es_client';
Expand Down
9 changes: 9 additions & 0 deletions x-pack/plugins/ml/common/types/detector_rules.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,17 @@ export interface DetectorRuleCondition {
value: number;
}

export interface DetectorRuleParamsForceTimeShift {
time_shift_amount: number;
}

export interface DetectorRuleParams {
force_time_shift?: DetectorRuleParamsForceTimeShift;
}

export interface DetectorRule {
actions: ML_DETECTOR_RULE_ACTION[];
scope?: DetectorRuleScope;
conditions?: DetectorRuleCondition[];
params?: DetectorRuleParams[];
}
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import {
import { ML_DETECTOR_RULE_ACTION } from '@kbn/ml-anomaly-utils';
import { FormattedMessage } from '@kbn/i18n-react';

// TODO: add onForceTimeShift action
export function ActionsSection({ actions, onSkipResultChange, onSkipModelUpdateChange }) {
return (
<React.Fragment>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,15 @@ const customRulesSchema = schema.maybe(
schema.arrayOf(
schema.object({
actions: schema.arrayOf(
schema.oneOf([schema.literal('skip_result'), schema.literal('skip_model_update')])
schema.oneOf([
schema.literal('skip_result'),
schema.literal('skip_model_update'),
schema.literal('force_time_shift'),
])
),
conditions: schema.maybe(schema.arrayOf(schema.any())),
scope: schema.maybe(schema.any()),
params: schema.maybe(schema.any()),
})
)
);
Expand Down