Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Auto-bundle AI Assistant API OpenAPI specs #188826

Merged
merged 6 commits into from
Jul 24, 2024

Conversation

maximpn
Copy link
Contributor

@maximpn maximpn commented Jul 22, 2024

Addresses: #184428

Summary

This PR adds scripts for automatic bundling of AI Assistant API OpenAPI specs as a part of PR pipeline. Corresponding result bundles are automatically committed to the Assistant Common package x-pack/packages/kbn-elastic-assistant-common in the docs/openapi/ess/ and docs/openapi/serverless folders (similar to #186384).

@maximpn maximpn added release_note:skip Skip the PR/issue when compiling release notes docs Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Security Generative AI Security Generative AI v8.16.0 labels Jul 22, 2024
@maximpn maximpn self-assigned this Jul 22, 2024
@maximpn
Copy link
Contributor Author

maximpn commented Jul 22, 2024

Hi @elastic/security-generative-ai,

Could you check validity of accessibility of your APIs in Serverless and ESS by checking added x-labels?

@maximpn maximpn force-pushed the add-automatic-ai-assistant-api-bundling branch from d9ff562 to bee0578 Compare July 22, 2024 11:40
@maximpn maximpn marked this pull request as ready for review July 22, 2024 13:06
@maximpn maximpn requested review from a team as code owners July 22, 2024 13:06
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@spong
Copy link
Member

spong commented Jul 24, 2024

#188704 has been merged, so this should be good once conflicts are resolved. Apologies for the overlap with the x-labels changes -- I didn't realize you were working this effort so ended up tackling them with the API alignment changes. All API's are ess/serverless, so I think we're all good here. Thanks for working on the bundler and all the docs and details @maximpn, this was nice and easy to work through and update 🙂

@maximpn maximpn force-pushed the add-automatic-ai-assistant-api-bundling branch from bee0578 to a4a2d73 Compare July 24, 2024 15:28
Copy link
Member

@spong spong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @maximpn! 🙂

@maximpn maximpn enabled auto-merge (squash) July 24, 2024 16:41
@maximpn maximpn disabled auto-merge July 24, 2024 18:12
@maximpn maximpn force-pushed the add-automatic-ai-assistant-api-bundling branch from ce773d9 to 7edacb2 Compare July 24, 2024 18:16
@maximpn maximpn requested a review from a team as a code owner July 24, 2024 18:19
@maximpn maximpn requested a review from a team as a code owner July 24, 2024 18:19
@maximpn maximpn requested a review from jpdjere July 24, 2024 18:19
@maximpn maximpn enabled auto-merge (squash) July 24, 2024 18:23
@maximpn maximpn removed the request for review from jpdjere July 24, 2024 18:25
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
integrationAssistant 539 540 +1
securitySolution 5610 5611 +1
total +2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/elastic-assistant-common 332 328 -4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 20.4MB 20.4MB +7.0B
Unknown metric groups

API count

id before after diff
@kbn/elastic-assistant-common 358 354 -4

History

  • 💚 Build #222889 succeeded bee0578bc4fb6d26c616efecba8bfa196298cb02
  • 💔 Build #222864 failed d9ff562fd974cec52479dcaecf2d462c86345b96

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @maximpn

Copy link
Contributor

@dplumlee dplumlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rule management changes lgtm!

@maximpn maximpn merged commit d7f62b6 into elastic:main Jul 24, 2024
41 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 24, 2024
@maximpn maximpn deleted the add-automatic-ai-assistant-api-bundling branch July 24, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting docs release_note:skip Skip the PR/issue when compiling release notes Team:Security Generative AI Security Generative AI Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants