[Entity Analytics] Improve response body for asset criticality delete route #189872
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While doing the API docs I noticed the asset criticality delete route did not return a response body, and returned a very ugly 404 if you attempted to delete something which didnt exist...
I have now made it so that we return a boolean for if the record was deleted or not (
false
if the record didnt exist) and we also return the record that was deleted if it was, e.g...And if the record didnt exist...