[Entity Analytics] MKI test failure fixes #190182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hop-dev
commented
Aug 8, 2024
hop-dev
commented
Aug 8, 2024
| @@ -31,7 +31,8 @@ import { REFRESH_BUTTON } from '../screens/security_header'; | |||
| export const updateDashboardTimeRange = () => { | |||
| // eslint-disable-next-line cypress/no-force | |||
| cy.get(GET_DATE_PICKER_APPLY_BUTTON(GLOBAL_FILTERS_CONTAINER)).click({ force: true }); // Force to fix global timerange flakiness | |||
| cy.get(REFRESH_BUTTON).click(); | |||
| // eslint-disable-next-line cypress/no-force | |||
| cy.get(REFRESH_BUTTON).click({ force: true }); // Force to fix even more global timerange flakiness | |||
There was a problem hiding this comment.
very rarely (1 in over 1000 test runs) the query button is disabled I dont understand why and I have no screenshots, but the button is not what is primarily under test so I think a force is reasonable here
jbudz
approved these changes
Aug 9, 2024
|
@elasticmachine merge upstream |
dmlemeshko
reviewed
Sep 2, 2024
There was a problem hiding this comment.
Code changes LGTM. @hop-dev did you have a chance to run the tests against real project on QA (MKI) to confirm flakiness is fixed?
|
@elasticmachine merge upstream |
|
@dmlemeshko the issue is so rare I didn't think that would be effective, do you have a concern about the change? |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
hop-dev
added
the
release_note:skip
kibanamachine
added
v8.16.0
backport:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes #10176
I've been looking into a few of our flaky tests and come up with a couple of actions, I will comment on them individually.