Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dataset Quality]Migrate telemetry tests and remove flyout code #190584

Conversation

achyutjhunjhunwala
Copy link
Contributor

@achyutjhunjhunwala achyutjhunjhunwala commented Aug 15, 2024

Summary

closes #184572

After the merge of the 1st PR around Flyout migration, this PR covers the remaining bits.

  • Adding same telemetry to the page which was present in the flyout
  • Create a Locator and use it in the Table to connect the main page with Details page
  • Update locator in Unified Doc Viewer
  • Migrate all kind of tests which were present for flyout to the page
  • Remove everything which was once called Dataset Quality Flyout.
  • Make build green - Yellow is also acceptable

@achyutjhunjhunwala achyutjhunjhunwala added release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-logs Observability Logs User Experience Team Feature:Dataset Health labels Aug 15, 2024
@achyutjhunjhunwala achyutjhunjhunwala self-assigned this Aug 15, 2024
@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@yngrdyn yngrdyn self-requested a review August 22, 2024 13:17
@yngrdyn
Copy link
Contributor

yngrdyn commented Aug 22, 2024

/oblt-deploy

@yngrdyn
Copy link
Contributor

yngrdyn commented Aug 23, 2024

/oblt-deploy

@achyutjhunjhunwala
Copy link
Contributor Author

/oblt-deploy

@yngrdyn
Copy link
Contributor

yngrdyn commented Aug 26, 2024

/oblt-deploy

@yngrdyn
Copy link
Contributor

yngrdyn commented Aug 26, 2024

I think I've found a bug. I'm not able to navigate from the chart

Screen.Recording.2024-08-26.at.15.41.35.mov

@achyutjhunjhunwala
Copy link
Contributor Author

@yngrdyn Thank you for catching this bug, i missed a small piece of code during migration which caused it
Fixed now
Aug-26-2024 16-02-43

@yngrdyn
Copy link
Contributor

yngrdyn commented Aug 26, 2024

/oblt-deploy

Copy link
Contributor

@yngrdyn yngrdyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Thanks for removing the flyout 🚀

@achyutjhunjhunwala achyutjhunjhunwala enabled auto-merge (squash) August 27, 2024 07:48
@kibana-ci
Copy link
Collaborator

kibana-ci commented Aug 27, 2024

💚 Build Succeeded

  • Buildkite Build
  • Commit: cd8bdd1
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-190584-cd8bdd17ffeb

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1932 1933 +1
dataQuality 159 162 +3
datasetQuality 310 293 -17
discover 985 986 +1
infra 1576 1577 +1
logsExplorer 617 618 +1
logsShared 227 228 +1
observability 1116 1117 +1
observabilityAIAssistantApp 246 247 +1
observabilityLogsExplorer 202 203 +1
observabilityOnboarding 236 237 +1
profiling 304 305 +1
unifiedDocViewer 281 282 +1
uptime 589 590 +1
ux 200 201 +1
total -1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/deeplinks-observability 44 49 +5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataQuality 114.3KB 114.1KB -250.0B
datasetQuality 328.0KB 287.0KB -41.0KB
unifiedDocViewer 205.4KB 205.3KB -159.0B
total -41.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dataQuality 7.4KB 7.9KB +430.0B
datasetQuality 49.5KB 49.0KB -551.0B
total -121.0B
Unknown metric groups

API count

id before after diff
@kbn/deeplinks-observability 56 61 +5

async chunk count

id before after diff
datasetQuality 19 16 -3

ESLint disabled line counts

id before after diff
@kbn/deeplinks-observability 9 11 +2
datasetQuality 19 16 -3
total -1

Total ESLint disabled count

id before after diff
@kbn/deeplinks-observability 9 11 +2
datasetQuality 21 18 -3
total -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @achyutjhunjhunwala

@achyutjhunjhunwala achyutjhunjhunwala merged commit 8431033 into elastic:main Aug 27, 2024
22 checks passed
@kibanamachine kibanamachine added v8.16.0 backport:skip This commit does not require backporting labels Aug 27, 2024
@achyutjhunjhunwala achyutjhunjhunwala deleted the migrate-telemetry-tests-and-remove-flyout-code branch August 27, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project Feature:Dataset Health release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-logs Observability Logs User Experience Team v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dataset Quality] Migrate Dataset Quality Flyout to a Dedicated Page
6 participants