-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dataset Quality]Migrate telemetry tests and remove flyout code #190584
[Dataset Quality]Migrate telemetry tests and remove flyout code #190584
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
/oblt-deploy |
...t_serverless/functional/test_suites/observability/dataset_quality/dataset_quality_details.ts
Show resolved
Hide resolved
...t_serverless/functional/test_suites/observability/dataset_quality/dataset_quality_details.ts
Show resolved
Hide resolved
x-pack/plugins/data_quality/common/url_schema/dataset_quality_url_schema_v1.ts
Show resolved
Hide resolved
x-pack/plugins/observability_solution/dataset_quality/public/hooks/use_redirect_link.ts
Show resolved
Hide resolved
...ck/plugins/observability_solution/dataset_quality/public/hooks/use_dataset_quality_table.tsx
Show resolved
Hide resolved
...s/observability_solution/dataset_quality/public/components/dataset_quality/table/columns.tsx
Show resolved
Hide resolved
...y_solution/dataset_quality/public/components/dataset_quality_details/details/fields_list.tsx
Show resolved
Hide resolved
/oblt-deploy |
…ests-and-remove-flyout-code
/oblt-deploy |
/oblt-deploy |
I think I've found a bug. I'm not able to navigate from the chart Screen.Recording.2024-08-26.at.15.41.35.mov |
@yngrdyn Thank you for catching this bug, i missed a small piece of code during migration which caused it |
/oblt-deploy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! Thanks for removing the flyout 🚀
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
async chunk count
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Summary
closes #184572
After the merge of the 1st PR around Flyout migration, this PR covers the remaining bits.