Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Fix root level yaml variables dollar escape #190615

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

nchaulet
Copy link
Member

Summary

Related to #188377

The way we handle root level yaml variable is done via a regex.replace, that function do not handle $ sign correctly as it's a placehold for matches, (see doc)

That PR fix the usage we do of that function.

How to test

Try to add a custom log integration with the advanced yaml configuration test: $$$$ and verify the policy contains that value.

Screenshot 2024-08-15 at 10 47 05 AM Screenshot 2024-08-15 at 10 47 37 AM

@nchaulet nchaulet added bug Fixes for quality problems that affect the customer experience Team:Fleet Team label for Observability Data Collection Fleet team labels Aug 15, 2024
@nchaulet nchaulet requested a review from a team as a code owner August 15, 2024 14:48
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Thanks for the test case as well. 🚀

@nchaulet nchaulet added the release_note:skip Skip the PR/issue when compiling release notes label Aug 15, 2024
@nchaulet nchaulet enabled auto-merge (squash) August 15, 2024 16:00
@nchaulet nchaulet merged commit 17b2be1 into elastic:main Aug 15, 2024
31 checks passed
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine kibanamachine added v8.16.0 backport:skip This commit does not require backporting labels Aug 15, 2024
@nchaulet nchaulet deleted the fix-replace-config-yaml-escape branch August 15, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants