Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM]: Disable _source unless otherwise specified #194424

Closed
wants to merge 9 commits into from
Closed

[APM]: Disable _source unless otherwise specified #194424

wants to merge 9 commits into from

Conversation

dgieselaar
Copy link
Member

No description provided.

@elasticmachine
Copy link
Contributor

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!

@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@dgieselaar dgieselaar force-pushed the apm-app-source-to-fields branch from d13e607 to 82a6eed Compare September 30, 2024 12:11
@dgieselaar
Copy link
Member Author

/ci

@dgieselaar
Copy link
Member Author

/ci

@dgieselaar
Copy link
Member Author

/ci

@kibana-ci
Copy link
Collaborator

kibana-ci commented Oct 1, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #12 / APM API tests traces/find_traces.spec.ts basic no archive Find traces when traces exist when using EQL returns the correct trace samples for join sequences
  • [job] [logs] FTR Configs #12 / APM API tests traces/find_traces.spec.ts basic no archive Find traces when traces exist when using EQL returns the correct trace samples for join sequences
  • [job] [logs] FTR Configs #21 / Observability specs (trial) fetching observability alerts details context for AI assistant contextual insights when traces and logs are ingested and logs are not annotated with service.name when no params are specified returns only 1 log category
  • [job] [logs] FTR Configs #21 / Observability specs (trial) fetching observability alerts details context for AI assistant contextual insights when traces and logs are ingested and logs are not annotated with service.name when no params are specified returns only 1 log category
  • [job] [logs] FTR Configs #19 / Telemetry /internal/telemetry/clusters/_stats with monitoring disabled should pass ad-hoc enforced validations
  • [job] [logs] FTR Configs #19 / Telemetry /internal/telemetry/clusters/_stats with monitoring disabled should pass ad-hoc enforced validations
  • [job] [logs] Jest Integration Tests #1 / unrecognized task types should be no workload aggregator errors when there are removed task types
  • [job] [logs] Jest Integration Tests #1 / unrecognized task types should be no workload aggregator errors when there are removed task types

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1865 1866 +1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/apm-types 316 329 +13
apmDataAccess 93 107 +14
total +27

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.4MB 3.4MB +82.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
apm 118 119 +1
apmDataAccess 3 5 +2
total +3

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
apm 40.4KB 40.7KB +307.0B
Unknown metric groups

API count

id before after diff
@kbn/apm-types 317 330 +13
apmDataAccess 93 107 +14
total +27

ESLint disabled line counts

id before after diff
@kbn/observability-utils 1 2 +1

Total ESLint disabled count

id before after diff
@kbn/observability-utils 1 2 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

AlexanderWert
AlexanderWert reviewed Oct 2, 2024
View reviewed changes
...bility_solution/apm/server/routes/errors/get_error_groups/get_error_group_main_statistics.ts
],
ERROR_ID,
] as const),
_source: [ERROR_LOG_MESSAGE, ERROR_EXC_MESSAGE, ERROR_EXC_HANDLED, ERROR_EXC_TYPE],
Copy link
Member

@AlexanderWert AlexanderWert Oct 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dgieselaar why do those still need to be from _source?
ERROR_EXC_MESSAGE, ERROR_EXC_HANDLED, ERROR_EXC_TYPE are all available as single-value fields

Not sure about ERROR_LOG_MESSAGE though

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't error.exception an array with plain objects?

@crespocarlos crespocarlos mentioned this pull request Oct 7, 2024
Merged
crespocarlos added a commit that referenced this pull request Oct 15, 2024
@crespocarlos @kibanamachine
@elasticmachine @jennypavlova
[APM][Otel] Use fields instead of _source on APM queries (#195242)
7235ed0 
closes #192606

## Summary

v2 based on the work done in this PR
#192608 and the suggestion from
Dario #194424

This PR replaces the _source usage in APM queries with fields to support
Otel data. The idea is to get rid of existing UI errors we have and make
sure that otel data is shown correctly in the UI.

One way to check it is using the [e2e
PoC](https://github.com/elastic/otel-apm-e2e-poc/blob/main/README.md).

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: Jenny <[email protected]>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 15, 2024
@crespocarlos
[APM][Otel] Use fields instead of _source on APM queries (elastic…
09f2c7c 
…#195242)

closes elastic#192606

## Summary

v2 based on the work done in this PR
elastic#192608 and the suggestion from
Dario elastic#194424

This PR replaces the _source usage in APM queries with fields to support
Otel data. The idea is to get rid of existing UI errors we have and make
sure that otel data is shown correctly in the UI.

One way to check it is using the [e2e
PoC](https://github.com/elastic/otel-apm-e2e-poc/blob/main/README.md).

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: Jenny <[email protected]>
(cherry picked from commit 7235ed0)
@dgieselaar dgieselaar closed this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderWert AlexanderWert AlexanderWert left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dgieselaar @elasticmachine @obltmachine @kibana-ci @AlexanderWert @kibanamachine