Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Add callout to promote blog post #195943

Merged
merged 7 commits into from
Oct 14, 2024
Merged

[Security Solution] Add callout to promote blog post #195943

merged 7 commits into from
Oct 14, 2024

Conversation

nikitaindik
Copy link
Contributor

Resolves: #195423

Summary

This PR adds a callout to the Rule Management page. This callout displays a link to a post in Elastic blog.

Once a user clicks on "x" in the top-right corner the callout will be dismissed forever. Dismissal state is saved in localStorage.

This is only for ESS v8.16.0 and beyond. Not for Serverless.

⚠️ Currently the link leads to a 404 page because the blog post is not yet created. It'll be published in time for 8.16 release.

⚠️ UI copy is not final. It'll be reviewed by the Docs folks on Monday. I'll change it to their suggestion once they review it on Monday.

Screenshot

Scherm­afbeelding 2024-10-11 om 16 43 59

@nikitaindik nikitaindik added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Feature:Rule Management Security Solution Detection Rule Management area Team:Detection Rule Management Security Detection Rule Management Team v8.16.0 labels Oct 11, 2024
@nikitaindik nikitaindik self-assigned this Oct 11, 2024
@nikitaindik nikitaindik marked this pull request as ready for review October 11, 2024 15:02
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management)

@nikitaindik nikitaindik requested a review from maximpn October 11, 2024 15:03
maximpn
maximpn approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@maximpn maximpn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nikitaindik nikitaindik added the ci:cloud-deploy Create or update a Cloud deployment label Oct 11, 2024
@nikitaindik nikitaindik mentioned this pull request Oct 14, 2024
Closed
@nikitaindik nikitaindik removed the ci:cloud-deploy Create or update a Cloud deployment label Oct 14, 2024
nikitaindik and others added 2 commits October 14, 2024 21:25
@nikitaindik @joepeeples
Update x-pack/plugins/security_solution/public/detections/components/…
2f1e9c9 
…callouts/blog_post_detection_engineering_callout/translations.ts

Co-authored-by: Joe Peeples <[email protected]>
@nikitaindik
Merge branch '8.x' into blog-callout-8.16
a455d4b
@nikitaindik nikitaindik enabled auto-merge (squash) October 14, 2024 19:30
banderror
banderror approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@banderror banderror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 6001 6003 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 20.8MB 20.8MB +1.4KB

History

cc @nikitaindik

@nikitaindik nikitaindik merged commit ee7bc7e into elastic:8.x Oct 14, 2024
31 checks passed
@nikitaindik nikitaindik mentioned this pull request Oct 15, 2024
Closed
@banderror banderror mentioned this pull request Oct 21, 2024
Closed
@nikitaindik nikitaindik mentioned this pull request Nov 18, 2024
Merged
nikitaindik added a commit that referenced this pull request Nov 19, 2024
@nikitaindik
[Security Solution] Remove a blog post callout from rule management p…
552212c 
…age (#200650)

**Resolves: #197024

## Summary

PR #195943 added a callout banner
to the 8.x branch. This banner was intended to be displayed only in ESS
v8.16. We are now removing it to ensure it does not appear in v8.17.0.

## Screenshots

**Before**
<img width="1840" alt="Scherm­afbeelding 2024-11-18 om 21 14 22"
src="https://github.com/user-attachments/assets/46ad45af-c058-4379-8651-43954801b3a1">

**After**
<img width="1840" alt="Scherm­afbeelding 2024-11-18 om 21 14 41"
src="https://github.com/user-attachments/assets/181d0b95-4486-43ab-be08-35ae91759660">
@PhilippeOberti PhilippeOberti mentioned this pull request Dec 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joepeeples joepeeples joepeeples left review comments

@banderror banderror banderror approved these changes

@maximpn maximpn maximpn approved these changes

Assignees

@nikitaindik nikitaindik

Labels
backport:skip This commit does not require backporting Feature:Rule Management Security Solution Detection Rule Management area release_note:skip Skip the PR/issue when compiling release notes Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nikitaindik @elasticmachine @maximpn @banderror @joepeeples