-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FTR][Ownership] Assign logstash, metrics ui, etc #196919
[FTR][Ownership] Assign logstash, metrics ui, etc #196919
Conversation
Assigned lists due to the api called is defined here: https://github.com/elastic/kibana/blob/4ed9e5173c6d56a949c15fcb8aa223cfc64fc5f1/x-pack/test/security_solution_cypress/cypress/tasks/api_calls/exceptions.ts#L54 \cc @elastic/security-detection-engine Assigned Logs Shared due to elastic#189646 \cc @elastic/obs-ux-logs-team Assigned logstash due to https://github.com/elastic/kibana/blob/4ed9e5173c6d56a949c15fcb8aa223cfc64fc5f1/x-pack/plugins/logstash/kibana.jsonc#L4 \cc @elastic/logstash Assigned metris ui due to https://github.com/elastic/kibana/blob/4f85a9989373fae228ab7969b671b6817d5ecf79/x-pack/plugins/observability_solution/infra/kibana.jsonc#L4 \cc @elastic/obs-ux-logs-team & @elastic/obs-ux-infra_services-team Contributes to: elastic#194817
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…kibana into assign-lists-logstassh-etc
.github/CODEOWNERS
Outdated
@@ -1374,6 +1376,7 @@ x-pack/test/api_integration/deployment_agnostic/services/ @elastic/appex-qa | |||
x-pack/test/**/deployment_agnostic/ @elastic/appex-qa #temporarily to monitor tests migration | |||
|
|||
# Core | |||
/x-pack/test/api_integration/apis/logstash @elastic/kibana-core |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the APIs tested here are owned by @elastic/logstash
as per
"owner": "@elastic/logstash", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the impact of this change on the Logstash team? - we have little capacity or ability to do work in Kibana at the moment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the impact of this change on the Logstash team? - we have little capacity or ability to do work in Kibana at the moment
@afharo this is one reason why I elected to assign this to the core team
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, the plugin is already owned by the logstash team, so... unless we expect big breaking changes in the FTR suite, I wouldn't expect them to require any changes if the plugin doesn't change.
@wayneseymour, am I missing any other potential effort in maintaining these tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, not that I'm aware of.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Back to the logstash team: 55ced3d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Detection Engine changes LGTM!
💚 Build Succeeded
Metrics [docs]
History
|
Summary
Hopefully assigning to not too large of a reviewers list.
Reasons for Assignments
Assigned lists due to the api called is defined here:
kibana/x-pack/test/security_solution_cypress/cypress/tasks/api_calls/exceptions.ts
Line 54 in 4ed9e51
Assigned Logs Shared due to #189646 \cc @elastic/obs-ux-logs-team
Assigned logstash due to
kibana/x-pack/plugins/logstash/kibana.jsonc
Line 4 in 4ed9e51
Assigned metris ui due to
kibana/x-pack/plugins/observability_solution/infra/kibana.jsonc
Line 4 in 4f85a99
Contributes to: #194817