Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FTR][Ownership] Assign logstash, metrics ui, etc #196919

Merged
merged 8 commits into from
Oct 23, 2024

Conversation

wayneseymour
Copy link
Member

@wayneseymour wayneseymour commented Oct 18, 2024

Summary

Hopefully assigning to not too large of a reviewers list.

Reasons for Assignments

Assigned lists due to the api called is defined here:

\cc @elastic/security-detection-engine

Assigned Logs Shared due to #189646 \cc @elastic/obs-ux-logs-team

Assigned logstash due to

"owner": "@elastic/logstash",
\cc @elastic/logstash

Assigned metris ui due to

"owner": ["@elastic/obs-ux-logs-team", "@elastic/obs-ux-infra_services-team"],
\cc @elastic/obs-ux-logs-team & @elastic/obs-ux-infra_services-team

Contributes to: #194817

@wayneseymour wayneseymour added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Oct 18, 2024
@wayneseymour wayneseymour self-assigned this Oct 18, 2024
@wayneseymour wayneseymour requested review from a team and rylnd October 18, 2024 16:12
@wayneseymour
Copy link
Member Author

@elasticmachine merge upstream

Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -1374,6 +1376,7 @@ x-pack/test/api_integration/deployment_agnostic/services/ @elastic/appex-qa
x-pack/test/**/deployment_agnostic/ @elastic/appex-qa #temporarily to monitor tests migration

# Core
/x-pack/test/api_integration/apis/logstash @elastic/kibana-core
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the APIs tested here are owned by @elastic/logstash as per

"owner": "@elastic/logstash",

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the impact of this change on the Logstash team? - we have little capacity or ability to do work in Kibana at the moment

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the impact of this change on the Logstash team? - we have little capacity or ability to do work in Kibana at the moment

@afharo this is one reason why I elected to assign this to the core team

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, the plugin is already owned by the logstash team, so... unless we expect big breaking changes in the FTR suite, I wouldn't expect them to require any changes if the plugin doesn't change.

@wayneseymour, am I missing any other potential effort in maintaining these tests?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, not that I'm aware of.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Back to the logstash team: 55ced3d

Copy link
Contributor

@rylnd rylnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Detection Engine changes LGTM!

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

cc @wayneseymour

@wayneseymour wayneseymour merged commit 0409f98 into elastic:main Oct 23, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:review backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants