[TableListView] Hint message for chars not allowed in search #197307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebelga
added
release_note:skip
sebelga
changed the title
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
|
This seems to be working as intended, but the help text seems to be quite intrusive, and shows up whenever there is focus in the text box. Could we make the help text show up only if the user has input one of the disallowed characters? |
|
Thanks for the review @tsullivan!
Good idea, I addressed it in 14fd42e and updated the PR description to show the new behaviour. Can you have another look? Thanks! 👍 |
💚 Build Succeeded
Metrics [docs]Async chunks
History
cc @sebelga |
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11495246677 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 24, 2024
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 24, 2024
…197307) (#197570) # Backport This will backport the following commits from `main` to `8.x`: - [[TableListView] Hint message for chars not allowed in search (#197307)](#197307) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sébastien Loix","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-24T08:10:49Z","message":"[TableListView] Hint message for chars not allowed in search (#197307)","sha":"b45a8e0866f334c1468cfdf9d3a7b0076032ca92","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:SharedUX","backport:prev-minor","Component:TableListView"],"title":"[TableListView] Hint message for chars not allowed in search","number":197307,"url":"https://github.com/elastic/kibana/pull/197307","mergeCommit":{"message":"[TableListView] Hint message for chars not allowed in search (#197307)","sha":"b45a8e0866f334c1468cfdf9d3a7b0076032ca92"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197307","number":197307,"mergeCommit":{"message":"[TableListView] Hint message for chars not allowed in search (#197307)","sha":"b45a8e0866f334c1468cfdf9d3a7b0076032ca92"}}]}] BACKPORT--> Co-authored-by: Sébastien Loix <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I've added a hint to the table list view search bar to indicate the characters that are not allowed.
This partially fixes #151120. Ideally we should allow special chars in the search bar. elastic/eui#7175 introduced a way to do plain search with special characters but if we turn it on we lose the filtering mechanism of the EuiInMemoryTable.
Screenshot