[ES|QL] Don't suggest unsupported fields #200544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stratoula
added
release_note:enhancement
v9.0.0
backport:version
💚 Build Succeeded
Metrics [docs]Page load bundle
|
|
Pinging @elastic/kibana-esql (Team:ESQL) |
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11895968089 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 18, 2024
## Summary Closes elastic#189666 Specifically: - we do not suggest unsupported fields - we add a warning if the field is used in the query ### How to test 1. Create an index with unsupported fields. I used this ``` PUT my-index-test-unsupported { "mappings" : { "properties" : { "my_histogram" : { "type" : "histogram" }, "my_text" : { "type" : "keyword" } } } } PUT my-index-test-unsupported/_doc/1 { "my_text" : "histogram_1", "my_histogram" : { "values" : [0.1, 0.2, 0.3, 0.4, 0.5], "counts" : [3, 7, 23, 12, 6] } } PUT my-index-test-unsupported/_doc/2 { "my_text" : "histogram_2", "my_histogram" : { "values" : [0.1, 0.25, 0.35, 0.4, 0.45, 0.5], "counts" : [8, 17, 8, 7, 6, 2] } } ``` 2. Go to the editor and try the autocomplete, it should not suggest the histogram field <img width="998" alt="image" src="https://github.com/user-attachments/assets/2a9b4594-1f8f-4e7a-9ea3-d9086c770178"> 3. Use a query like `FROM my-index-test-unsupported | KEEP my_histogram `. You should see a warning <img width="991" alt="image" src="https://github.com/user-attachments/assets/1bf747da-191f-46e2-b1b8-e5966653f405"> ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 3c3f2c1)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 18, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[ES|QL] Don't suggest unsupported fields (#200544)](#200544) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Stratoula Kalafateli","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-18T15:45:25Z","message":"[ES|QL] Don't suggest unsupported fields (#200544)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/189666\r\n\r\nSpecifically:\r\n\r\n- we do not suggest unsupported fields\r\n- we add a warning if the field is used in the query\r\n\r\n### How to test\r\n\r\n1. Create an index with unsupported fields. I used this\r\n\r\n```\r\nPUT my-index-test-unsupported\r\n{\r\n \"mappings\" : {\r\n \"properties\" : {\r\n \"my_histogram\" : {\r\n \"type\" : \"histogram\"\r\n },\r\n \"my_text\" : {\r\n \"type\" : \"keyword\"\r\n }\r\n }\r\n }\r\n}\r\n\r\nPUT my-index-test-unsupported/_doc/1\r\n{\r\n \"my_text\" : \"histogram_1\",\r\n \"my_histogram\" : {\r\n \"values\" : [0.1, 0.2, 0.3, 0.4, 0.5], \r\n \"counts\" : [3, 7, 23, 12, 6] \r\n }\r\n}\r\n\r\nPUT my-index-test-unsupported/_doc/2\r\n{\r\n \"my_text\" : \"histogram_2\",\r\n \"my_histogram\" : {\r\n \"values\" : [0.1, 0.25, 0.35, 0.4, 0.45, 0.5], \r\n \"counts\" : [8, 17, 8, 7, 6, 2] \r\n }\r\n}\r\n```\r\n\r\n2. Go to the editor and try the autocomplete, it should not suggest the\r\nhistogram field\r\n\r\n<img width=\"998\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/2a9b4594-1f8f-4e7a-9ea3-d9086c770178\">\r\n\r\n3. Use a query like `FROM my-index-test-unsupported | KEEP my_histogram\r\n`. You should see a warning\r\n\r\n<img width=\"991\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/1bf747da-191f-46e2-b1b8-e5966653f405\">\r\n\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"3c3f2c11a9da2a26f75f601ee365af1a227295b6","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","v9.0.0","Feature:ES|QL","Team:ESQL","backport:version","v8.17.0"],"title":"[ES|QL] Don't suggest unsupported fields","number":200544,"url":"https://github.com/elastic/kibana/pull/200544","mergeCommit":{"message":"[ES|QL] Don't suggest unsupported fields (#200544)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/189666\r\n\r\nSpecifically:\r\n\r\n- we do not suggest unsupported fields\r\n- we add a warning if the field is used in the query\r\n\r\n### How to test\r\n\r\n1. Create an index with unsupported fields. I used this\r\n\r\n```\r\nPUT my-index-test-unsupported\r\n{\r\n \"mappings\" : {\r\n \"properties\" : {\r\n \"my_histogram\" : {\r\n \"type\" : \"histogram\"\r\n },\r\n \"my_text\" : {\r\n \"type\" : \"keyword\"\r\n }\r\n }\r\n }\r\n}\r\n\r\nPUT my-index-test-unsupported/_doc/1\r\n{\r\n \"my_text\" : \"histogram_1\",\r\n \"my_histogram\" : {\r\n \"values\" : [0.1, 0.2, 0.3, 0.4, 0.5], \r\n \"counts\" : [3, 7, 23, 12, 6] \r\n }\r\n}\r\n\r\nPUT my-index-test-unsupported/_doc/2\r\n{\r\n \"my_text\" : \"histogram_2\",\r\n \"my_histogram\" : {\r\n \"values\" : [0.1, 0.25, 0.35, 0.4, 0.45, 0.5], \r\n \"counts\" : [8, 17, 8, 7, 6, 2] \r\n }\r\n}\r\n```\r\n\r\n2. Go to the editor and try the autocomplete, it should not suggest the\r\nhistogram field\r\n\r\n<img width=\"998\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/2a9b4594-1f8f-4e7a-9ea3-d9086c770178\">\r\n\r\n3. Use a query like `FROM my-index-test-unsupported | KEEP my_histogram\r\n`. You should see a warning\r\n\r\n<img width=\"991\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/1bf747da-191f-46e2-b1b8-e5966653f405\">\r\n\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"3c3f2c11a9da2a26f75f601ee365af1a227295b6"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200544","number":200544,"mergeCommit":{"message":"[ES|QL] Don't suggest unsupported fields (#200544)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/189666\r\n\r\nSpecifically:\r\n\r\n- we do not suggest unsupported fields\r\n- we add a warning if the field is used in the query\r\n\r\n### How to test\r\n\r\n1. Create an index with unsupported fields. I used this\r\n\r\n```\r\nPUT my-index-test-unsupported\r\n{\r\n \"mappings\" : {\r\n \"properties\" : {\r\n \"my_histogram\" : {\r\n \"type\" : \"histogram\"\r\n },\r\n \"my_text\" : {\r\n \"type\" : \"keyword\"\r\n }\r\n }\r\n }\r\n}\r\n\r\nPUT my-index-test-unsupported/_doc/1\r\n{\r\n \"my_text\" : \"histogram_1\",\r\n \"my_histogram\" : {\r\n \"values\" : [0.1, 0.2, 0.3, 0.4, 0.5], \r\n \"counts\" : [3, 7, 23, 12, 6] \r\n }\r\n}\r\n\r\nPUT my-index-test-unsupported/_doc/2\r\n{\r\n \"my_text\" : \"histogram_2\",\r\n \"my_histogram\" : {\r\n \"values\" : [0.1, 0.25, 0.35, 0.4, 0.45, 0.5], \r\n \"counts\" : [8, 17, 8, 7, 6, 2] \r\n }\r\n}\r\n```\r\n\r\n2. Go to the editor and try the autocomplete, it should not suggest the\r\nhistogram field\r\n\r\n<img width=\"998\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/2a9b4594-1f8f-4e7a-9ea3-d9086c770178\">\r\n\r\n3. Use a query like `FROM my-index-test-unsupported | KEEP my_histogram\r\n`. You should see a warning\r\n\r\n<img width=\"991\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/1bf747da-191f-46e2-b1b8-e5966653f405\">\r\n\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"3c3f2c11a9da2a26f75f601ee365af1a227295b6"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Stratoula Kalafateli <[email protected]>
jesuswr
pushed a commit
to jesuswr/kibana
that referenced
this pull request
Nov 18, 2024
## Summary Closes elastic#189666 Specifically: - we do not suggest unsupported fields - we add a warning if the field is used in the query ### How to test 1. Create an index with unsupported fields. I used this ``` PUT my-index-test-unsupported { "mappings" : { "properties" : { "my_histogram" : { "type" : "histogram" }, "my_text" : { "type" : "keyword" } } } } PUT my-index-test-unsupported/_doc/1 { "my_text" : "histogram_1", "my_histogram" : { "values" : [0.1, 0.2, 0.3, 0.4, 0.5], "counts" : [3, 7, 23, 12, 6] } } PUT my-index-test-unsupported/_doc/2 { "my_text" : "histogram_2", "my_histogram" : { "values" : [0.1, 0.25, 0.35, 0.4, 0.45, 0.5], "counts" : [8, 17, 8, 7, 6, 2] } } ``` 2. Go to the editor and try the autocomplete, it should not suggest the histogram field <img width="998" alt="image" src="https://github.com/user-attachments/assets/2a9b4594-1f8f-4e7a-9ea3-d9086c770178"> 3. Use a query like `FROM my-index-test-unsupported | KEEP my_histogram `. You should see a warning <img width="991" alt="image" src="https://github.com/user-attachments/assets/1bf747da-191f-46e2-b1b8-e5966653f405"> ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
## Summary Closes elastic#189666 Specifically: - we do not suggest unsupported fields - we add a warning if the field is used in the query ### How to test 1. Create an index with unsupported fields. I used this ``` PUT my-index-test-unsupported { "mappings" : { "properties" : { "my_histogram" : { "type" : "histogram" }, "my_text" : { "type" : "keyword" } } } } PUT my-index-test-unsupported/_doc/1 { "my_text" : "histogram_1", "my_histogram" : { "values" : [0.1, 0.2, 0.3, 0.4, 0.5], "counts" : [3, 7, 23, 12, 6] } } PUT my-index-test-unsupported/_doc/2 { "my_text" : "histogram_2", "my_histogram" : { "values" : [0.1, 0.25, 0.35, 0.4, 0.45, 0.5], "counts" : [8, 17, 8, 7, 6, 2] } } ``` 2. Go to the editor and try the autocomplete, it should not suggest the histogram field <img width="998" alt="image" src="https://github.com/user-attachments/assets/2a9b4594-1f8f-4e7a-9ea3-d9086c770178"> 3. Use a query like `FROM my-index-test-unsupported | KEEP my_histogram `. You should see a warning <img width="991" alt="image" src="https://github.com/user-attachments/assets/1bf747da-191f-46e2-b1b8-e5966653f405"> ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #189666
Specifically:
How to test
FROM my-index-test-unsupported | KEEP my_histogram. You should see a warningChecklist