Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ResponseOps][Connectors] Show a licensing message if the user does not have the sufficient license for system actions. #201396

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

cnasikas
Copy link
Member

@cnasikas cnasikas commented Nov 22, 2024

If a user does not have a sufficient license for a connector and the rule is already configured with such a connector we show the following message:

Screenshot 2024-11-22 at 1 48 10 PM

This PR does the same for system actions.

Screenshot 2024-11-22 at 1 03 06 PM

Testing

  1. Create a rule with a case action in Platinum license
  2. Downgrade to basic
  3. Verify that a licensing message is showing for the case action. Verify in all solutions.

Issue: #189978

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

@cnasikas cnasikas added bug Fixes for quality problems that affect the customer experience Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v9.0.0 Feature:Alerting/RuleActions Issues related to the Actions attached to Rules on the Alerting Framework Feature:Alerting/RulesManagement Issues related to the Rules Management UX v8.18.0 labels Nov 22, 2024
@cnasikas cnasikas self-assigned this Nov 22, 2024
@cnasikas cnasikas requested a review from a team as a code owner November 22, 2024 14:26
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@cnasikas cnasikas added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Nov 22, 2024
@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 22, 2024

💚 Build Succeeded

  • Buildkite Build
  • Commit: 8069e27
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-201396-8069e27ac8d7

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.7MB 1.7MB +605.0B

History

cc @cnasikas

Copy link
Contributor

@js-jankisalvi js-jankisalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified locally, works as expected 👍

@cnasikas cnasikas merged commit e020595 into elastic:main Nov 23, 2024
40 checks passed
@cnasikas cnasikas deleted the fix_189978 branch November 23, 2024 09:17
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11985967737

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 23, 2024
…ot have the sufficient license for system actions. (elastic#201396)

If a user does not have a sufficient license for a connector and the
rule is already configured with such a connector we show the following
message:

<img width="1026" alt="Screenshot 2024-11-22 at 1 48 10 PM"
src="https://github.com/user-attachments/assets/4b3d7197-ff3c-4673-9b37-9ca627dab0db">

This PR does the same for system actions.

<img width="1162" alt="Screenshot 2024-11-22 at 1 03 06 PM"
src="https://github.com/user-attachments/assets/d1cbd479-ff65-453d-889a-ae7f5cd2b63b">

## Testing

1. Create a rule with a case action in Platinum license
2. Downgrade to basic
3. Verify that a licensing message is showing for the case action.
Verify in all solutions.

Issue: elastic#189978

### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit e020595)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 23, 2024
…does not have the sufficient license for system actions. (#201396) (#201494)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ResponseOps][Connectors] Show a licensing message if the user does
not have the sufficient license for system actions.
(#201396)](#201396)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Christos
Nasikas","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-23T09:17:11Z","message":"[ResponseOps][Connectors]
Show a licensing message if the user does not have the sufficient
license for system actions. (#201396)\n\nIf a user does not have a
sufficient license for a connector and the\r\nrule is already configured
with such a connector we show the following\r\nmessage:\r\n\r\n<img
width=\"1026\" alt=\"Screenshot 2024-11-22 at 1 48
10 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/4b3d7197-ff3c-4673-9b37-9ca627dab0db\">\r\n\r\nThis
PR does the same for system actions.\r\n\r\n<img width=\"1162\"
alt=\"Screenshot 2024-11-22 at 1 03
06 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/d1cbd479-ff65-453d-889a-ae7f5cd2b63b\">\r\n\r\n##
Testing\r\n\r\n1. Create a rule with a case action in Platinum
license\r\n2. Downgrade to basic\r\n3. Verify that a licensing message
is showing for the case action.\r\nVerify in all
solutions.\r\n\r\nIssue:
https://github.com/elastic/kibana/issues/189978\r\n\r\n###
Checklist\r\n\r\nCheck the PR satisfies following conditions.
\r\n\r\nReviewers should verify this PR satisfies this list as
well.\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"e02059590899bd67379a5ee2243eb004a2e86952","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:ResponseOps","v9.0.0","Feature:Alerting/RuleActions","Feature:Alerting/RulesManagement","backport:prev-minor","ci:build-serverless-image","v8.18.0"],"title":"[ResponseOps][Connectors]
Show a licensing message if the user does not have the sufficient
license for system
actions.","number":201396,"url":"https://github.com/elastic/kibana/pull/201396","mergeCommit":{"message":"[ResponseOps][Connectors]
Show a licensing message if the user does not have the sufficient
license for system actions. (#201396)\n\nIf a user does not have a
sufficient license for a connector and the\r\nrule is already configured
with such a connector we show the following\r\nmessage:\r\n\r\n<img
width=\"1026\" alt=\"Screenshot 2024-11-22 at 1 48
10 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/4b3d7197-ff3c-4673-9b37-9ca627dab0db\">\r\n\r\nThis
PR does the same for system actions.\r\n\r\n<img width=\"1162\"
alt=\"Screenshot 2024-11-22 at 1 03
06 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/d1cbd479-ff65-453d-889a-ae7f5cd2b63b\">\r\n\r\n##
Testing\r\n\r\n1. Create a rule with a case action in Platinum
license\r\n2. Downgrade to basic\r\n3. Verify that a licensing message
is showing for the case action.\r\nVerify in all
solutions.\r\n\r\nIssue:
https://github.com/elastic/kibana/issues/189978\r\n\r\n###
Checklist\r\n\r\nCheck the PR satisfies following conditions.
\r\n\r\nReviewers should verify this PR satisfies this list as
well.\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"e02059590899bd67379a5ee2243eb004a2e86952"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201396","number":201396,"mergeCommit":{"message":"[ResponseOps][Connectors]
Show a licensing message if the user does not have the sufficient
license for system actions. (#201396)\n\nIf a user does not have a
sufficient license for a connector and the\r\nrule is already configured
with such a connector we show the following\r\nmessage:\r\n\r\n<img
width=\"1026\" alt=\"Screenshot 2024-11-22 at 1 48
10 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/4b3d7197-ff3c-4673-9b37-9ca627dab0db\">\r\n\r\nThis
PR does the same for system actions.\r\n\r\n<img width=\"1162\"
alt=\"Screenshot 2024-11-22 at 1 03
06 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/d1cbd479-ff65-453d-889a-ae7f5cd2b63b\">\r\n\r\n##
Testing\r\n\r\n1. Create a rule with a case action in Platinum
license\r\n2. Downgrade to basic\r\n3. Verify that a licensing message
is showing for the case action.\r\nVerify in all
solutions.\r\n\r\nIssue:
https://github.com/elastic/kibana/issues/189978\r\n\r\n###
Checklist\r\n\r\nCheck the PR satisfies following conditions.
\r\n\r\nReviewers should verify this PR satisfies this list as
well.\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"e02059590899bd67379a5ee2243eb004a2e86952"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Christos Nasikas <[email protected]>
paulinashakirova pushed a commit to paulinashakirova/kibana that referenced this pull request Nov 26, 2024
…ot have the sufficient license for system actions. (elastic#201396)

If a user does not have a sufficient license for a connector and the
rule is already configured with such a connector we show the following
message:

<img width="1026" alt="Screenshot 2024-11-22 at 1 48 10 PM"
src="https://github.com/user-attachments/assets/4b3d7197-ff3c-4673-9b37-9ca627dab0db">

This PR does the same for system actions.

<img width="1162" alt="Screenshot 2024-11-22 at 1 03 06 PM"
src="https://github.com/user-attachments/assets/d1cbd479-ff65-453d-889a-ae7f5cd2b63b">

## Testing

1. Create a rule with a case action in Platinum license
2. Downgrade to basic
3. Verify that a licensing message is showing for the case action.
Verify in all solutions.

Issue: elastic#189978

### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
…ot have the sufficient license for system actions. (elastic#201396)

If a user does not have a sufficient license for a connector and the
rule is already configured with such a connector we show the following
message:

<img width="1026" alt="Screenshot 2024-11-22 at 1 48 10 PM"
src="https://github.com/user-attachments/assets/4b3d7197-ff3c-4673-9b37-9ca627dab0db">

This PR does the same for system actions.

<img width="1162" alt="Screenshot 2024-11-22 at 1 03 06 PM"
src="https://github.com/user-attachments/assets/d1cbd479-ff65-453d-889a-ae7f5cd2b63b">

## Testing

1. Create a rule with a case action in Platinum license
2. Downgrade to basic
3. Verify that a licensing message is showing for the case action.
Verify in all solutions.

Issue: elastic#189978

### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) bug Fixes for quality problems that affect the customer experience ci:build-serverless-image Feature:Alerting/RuleActions Issues related to the Actions attached to Rules on the Alerting Framework Feature:Alerting/RulesManagement Issues related to the Rules Management UX release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants