-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ObsUX][APM] Migrate Service Overview archiver test cases to synthtrace #201407
[ObsUX][APM] Migrate Service Overview archiver test cases to synthtrace #201407
Conversation
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
...pis/observability/apm/service_overview/__snapshots__/instances_detailed_statistics.spec.snap
Outdated
Show resolved
Hide resolved
...gration/deployment_agnostic/apis/observability/apm/dependencies/service_dependencies.spec.ts
Outdated
Show resolved
Hide resolved
@@ -49,8 +61,166 @@ export default function ApiTest({ getService }: DeploymentAgnosticFtrProviderCon | |||
}); | |||
}); | |||
|
|||
// UNSUPPORTED TEST CASES - when data is loaded | |||
// TODO: These tests should be migrated to use synthtrace: https://github.com/elastic/kibana/issues/200743 | |||
describe('when data is loaded', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀 Just a small thing ⬇️
...yment_agnostic/apis/observability/apm/service_overview/instances_detailed_statistics.spec.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: jennypavlova <[email protected]>
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💚 Build Succeeded
Metrics [docs]
History
|
Starting backport for target branches: 8.17, 8.x https://github.com/elastic/kibana/actions/runs/12007802621 |
…ce (elastic#201407) Part of elastic#193245 Related elastic#200226 Closes elastic#200743 ## Summary This PR completes the migration of remaining Service Overview tests to the Deployment Agnostic test framework. In this PR, one test was deduplicated (the Dependencies test), and the Instances Detailed Statistics cases dealing with archiver data was migrated to make use of synthtrace instead. Snapshots included were redone to match the data generated by synthtrace, but no other cases were changed to ensure the new migrated tests were passing the same assumptions as before. ## How to Test ### Serverless ``` node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt/apm.serverless.config.ts node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.apm.serverless.config.ts ``` It's recommended to be run against [MKI](https://github.com/crespocarlos/kibana/blob/main/x-pack/test_serverless/README.md#run-tests-on-mki) ### Stateful ``` node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.apm.stateful.config.ts node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.apm.stateful.config.ts ``` --------- Co-authored-by: jennypavlova <[email protected]> Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit 4891c7d)
…ce (elastic#201407) Part of elastic#193245 Related elastic#200226 Closes elastic#200743 ## Summary This PR completes the migration of remaining Service Overview tests to the Deployment Agnostic test framework. In this PR, one test was deduplicated (the Dependencies test), and the Instances Detailed Statistics cases dealing with archiver data was migrated to make use of synthtrace instead. Snapshots included were redone to match the data generated by synthtrace, but no other cases were changed to ensure the new migrated tests were passing the same assumptions as before. ## How to Test ### Serverless ``` node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt/apm.serverless.config.ts node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.apm.serverless.config.ts ``` It's recommended to be run against [MKI](https://github.com/crespocarlos/kibana/blob/main/x-pack/test_serverless/README.md#run-tests-on-mki) ### Stateful ``` node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.apm.stateful.config.ts node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.apm.stateful.config.ts ``` --------- Co-authored-by: jennypavlova <[email protected]> Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit 4891c7d)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…ce (elastic#201407) Part of elastic#193245 Related elastic#200226 Closes elastic#200743 ## Summary This PR completes the migration of remaining Service Overview tests to the Deployment Agnostic test framework. In this PR, one test was deduplicated (the Dependencies test), and the Instances Detailed Statistics cases dealing with archiver data was migrated to make use of synthtrace instead. Snapshots included were redone to match the data generated by synthtrace, but no other cases were changed to ensure the new migrated tests were passing the same assumptions as before. ## How to Test ### Serverless ``` node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt/apm.serverless.config.ts node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.apm.serverless.config.ts ``` It's recommended to be run against [MKI](https://github.com/crespocarlos/kibana/blob/main/x-pack/test_serverless/README.md#run-tests-on-mki) ### Stateful ``` node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.apm.stateful.config.ts node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.apm.stateful.config.ts ``` --------- Co-authored-by: jennypavlova <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
6 similar comments
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
…nthtrace (#201407) (#201537) # Backport This will backport the following commits from `main` to `8.x`: - [[ObsUX][APM] Migrate Service Overview archiver test cases to synthtrace (#201407)](#201407) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gonçalo Rica Pais da Silva","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-25T10:13:16Z","message":"[ObsUX][APM] Migrate Service Overview archiver test cases to synthtrace (#201407)\n\nPart of #193245\r\nRelated #200226\r\nCloses #200743 \r\n\r\n## Summary\r\n\r\nThis PR completes the migration of remaining Service Overview tests to\r\nthe Deployment Agnostic test framework. In this PR, one test was\r\ndeduplicated (the Dependencies test), and the Instances Detailed\r\nStatistics cases dealing with archiver data was migrated to make use of\r\nsynthtrace instead. Snapshots included were redone to match the data\r\ngenerated by synthtrace, but no other cases were changed to ensure the\r\nnew migrated tests were passing the same assumptions as before.\r\n\r\n## How to Test\r\n\r\n### Serverless\r\n\r\n```\r\nnode scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt/apm.serverless.config.ts\r\nnode scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.apm.serverless.config.ts\r\n```\r\n\r\nIt's recommended to be run against\r\n[MKI](https://github.com/crespocarlos/kibana/blob/main/x-pack/test_serverless/README.md#run-tests-on-mki)\r\n\r\n### Stateful\r\n\r\n```\r\nnode scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.apm.stateful.config.ts\r\nnode scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.apm.stateful.config.ts\r\n```\r\n\r\n---------\r\n\r\nCo-authored-by: jennypavlova <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"4891c7d7f99097de649667ad0c1f48515120edbd","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services","v8.17.0"],"title":"[ObsUX][APM] Migrate Service Overview archiver test cases to synthtrace","number":201407,"url":"https://github.com/elastic/kibana/pull/201407","mergeCommit":{"message":"[ObsUX][APM] Migrate Service Overview archiver test cases to synthtrace (#201407)\n\nPart of #193245\r\nRelated #200226\r\nCloses #200743 \r\n\r\n## Summary\r\n\r\nThis PR completes the migration of remaining Service Overview tests to\r\nthe Deployment Agnostic test framework. In this PR, one test was\r\ndeduplicated (the Dependencies test), and the Instances Detailed\r\nStatistics cases dealing with archiver data was migrated to make use of\r\nsynthtrace instead. Snapshots included were redone to match the data\r\ngenerated by synthtrace, but no other cases were changed to ensure the\r\nnew migrated tests were passing the same assumptions as before.\r\n\r\n## How to Test\r\n\r\n### Serverless\r\n\r\n```\r\nnode scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt/apm.serverless.config.ts\r\nnode scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.apm.serverless.config.ts\r\n```\r\n\r\nIt's recommended to be run against\r\n[MKI](https://github.com/crespocarlos/kibana/blob/main/x-pack/test_serverless/README.md#run-tests-on-mki)\r\n\r\n### Stateful\r\n\r\n```\r\nnode scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.apm.stateful.config.ts\r\nnode scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.apm.stateful.config.ts\r\n```\r\n\r\n---------\r\n\r\nCo-authored-by: jennypavlova <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"4891c7d7f99097de649667ad0c1f48515120edbd"}},"sourceBranch":"main","suggestedTargetBranches":["8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201407","number":201407,"mergeCommit":{"message":"[ObsUX][APM] Migrate Service Overview archiver test cases to synthtrace (#201407)\n\nPart of #193245\r\nRelated #200226\r\nCloses #200743 \r\n\r\n## Summary\r\n\r\nThis PR completes the migration of remaining Service Overview tests to\r\nthe Deployment Agnostic test framework. In this PR, one test was\r\ndeduplicated (the Dependencies test), and the Instances Detailed\r\nStatistics cases dealing with archiver data was migrated to make use of\r\nsynthtrace instead. Snapshots included were redone to match the data\r\ngenerated by synthtrace, but no other cases were changed to ensure the\r\nnew migrated tests were passing the same assumptions as before.\r\n\r\n## How to Test\r\n\r\n### Serverless\r\n\r\n```\r\nnode scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt/apm.serverless.config.ts\r\nnode scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.apm.serverless.config.ts\r\n```\r\n\r\nIt's recommended to be run against\r\n[MKI](https://github.com/crespocarlos/kibana/blob/main/x-pack/test_serverless/README.md#run-tests-on-mki)\r\n\r\n### Stateful\r\n\r\n```\r\nnode scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.apm.stateful.config.ts\r\nnode scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.apm.stateful.config.ts\r\n```\r\n\r\n---------\r\n\r\nCo-authored-by: jennypavlova <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"4891c7d7f99097de649667ad0c1f48515120edbd"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Gonçalo Rica Pais da Silva <[email protected]>
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
1 similar comment
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
…ynthtrace (#201407) (#201536) # Backport This will backport the following commits from `main` to `8.17`: - [[ObsUX][APM] Migrate Service Overview archiver test cases to synthtrace (#201407)](#201407) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gonçalo Rica Pais da Silva","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-25T10:13:16Z","message":"[ObsUX][APM] Migrate Service Overview archiver test cases to synthtrace (#201407)\n\nPart of #193245\r\nRelated #200226\r\nCloses #200743 \r\n\r\n## Summary\r\n\r\nThis PR completes the migration of remaining Service Overview tests to\r\nthe Deployment Agnostic test framework. In this PR, one test was\r\ndeduplicated (the Dependencies test), and the Instances Detailed\r\nStatistics cases dealing with archiver data was migrated to make use of\r\nsynthtrace instead. Snapshots included were redone to match the data\r\ngenerated by synthtrace, but no other cases were changed to ensure the\r\nnew migrated tests were passing the same assumptions as before.\r\n\r\n## How to Test\r\n\r\n### Serverless\r\n\r\n```\r\nnode scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt/apm.serverless.config.ts\r\nnode scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.apm.serverless.config.ts\r\n```\r\n\r\nIt's recommended to be run against\r\n[MKI](https://github.com/crespocarlos/kibana/blob/main/x-pack/test_serverless/README.md#run-tests-on-mki)\r\n\r\n### Stateful\r\n\r\n```\r\nnode scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.apm.stateful.config.ts\r\nnode scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.apm.stateful.config.ts\r\n```\r\n\r\n---------\r\n\r\nCo-authored-by: jennypavlova <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"4891c7d7f99097de649667ad0c1f48515120edbd","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services","v8.17.0"],"title":"[ObsUX][APM] Migrate Service Overview archiver test cases to synthtrace","number":201407,"url":"https://github.com/elastic/kibana/pull/201407","mergeCommit":{"message":"[ObsUX][APM] Migrate Service Overview archiver test cases to synthtrace (#201407)\n\nPart of #193245\r\nRelated #200226\r\nCloses #200743 \r\n\r\n## Summary\r\n\r\nThis PR completes the migration of remaining Service Overview tests to\r\nthe Deployment Agnostic test framework. In this PR, one test was\r\ndeduplicated (the Dependencies test), and the Instances Detailed\r\nStatistics cases dealing with archiver data was migrated to make use of\r\nsynthtrace instead. Snapshots included were redone to match the data\r\ngenerated by synthtrace, but no other cases were changed to ensure the\r\nnew migrated tests were passing the same assumptions as before.\r\n\r\n## How to Test\r\n\r\n### Serverless\r\n\r\n```\r\nnode scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt/apm.serverless.config.ts\r\nnode scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.apm.serverless.config.ts\r\n```\r\n\r\nIt's recommended to be run against\r\n[MKI](https://github.com/crespocarlos/kibana/blob/main/x-pack/test_serverless/README.md#run-tests-on-mki)\r\n\r\n### Stateful\r\n\r\n```\r\nnode scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.apm.stateful.config.ts\r\nnode scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.apm.stateful.config.ts\r\n```\r\n\r\n---------\r\n\r\nCo-authored-by: jennypavlova <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"4891c7d7f99097de649667ad0c1f48515120edbd"}},"sourceBranch":"main","suggestedTargetBranches":["8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201407","number":201407,"mergeCommit":{"message":"[ObsUX][APM] Migrate Service Overview archiver test cases to synthtrace (#201407)\n\nPart of #193245\r\nRelated #200226\r\nCloses #200743 \r\n\r\n## Summary\r\n\r\nThis PR completes the migration of remaining Service Overview tests to\r\nthe Deployment Agnostic test framework. In this PR, one test was\r\ndeduplicated (the Dependencies test), and the Instances Detailed\r\nStatistics cases dealing with archiver data was migrated to make use of\r\nsynthtrace instead. Snapshots included were redone to match the data\r\ngenerated by synthtrace, but no other cases were changed to ensure the\r\nnew migrated tests were passing the same assumptions as before.\r\n\r\n## How to Test\r\n\r\n### Serverless\r\n\r\n```\r\nnode scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt/apm.serverless.config.ts\r\nnode scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.apm.serverless.config.ts\r\n```\r\n\r\nIt's recommended to be run against\r\n[MKI](https://github.com/crespocarlos/kibana/blob/main/x-pack/test_serverless/README.md#run-tests-on-mki)\r\n\r\n### Stateful\r\n\r\n```\r\nnode scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.apm.stateful.config.ts\r\nnode scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.apm.stateful.config.ts\r\n```\r\n\r\n---------\r\n\r\nCo-authored-by: jennypavlova <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"4891c7d7f99097de649667ad0c1f48515120edbd"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Gonçalo Rica Pais da Silva <[email protected]>
…ce (elastic#201407) Part of elastic#193245 Related elastic#200226 Closes elastic#200743 ## Summary This PR completes the migration of remaining Service Overview tests to the Deployment Agnostic test framework. In this PR, one test was deduplicated (the Dependencies test), and the Instances Detailed Statistics cases dealing with archiver data was migrated to make use of synthtrace instead. Snapshots included were redone to match the data generated by synthtrace, but no other cases were changed to ensure the new migrated tests were passing the same assumptions as before. ## How to Test ### Serverless ``` node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt/apm.serverless.config.ts node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.apm.serverless.config.ts ``` It's recommended to be run against [MKI](https://github.com/crespocarlos/kibana/blob/main/x-pack/test_serverless/README.md#run-tests-on-mki) ### Stateful ``` node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.apm.stateful.config.ts node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.apm.stateful.config.ts ``` --------- Co-authored-by: jennypavlova <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
This PR didn't make it on time for the latest v8.17.0 BC. Updating the labels. |
Part of #193245
Related #200226
Closes #200743
Summary
This PR completes the migration of remaining Service Overview tests to the Deployment Agnostic test framework. In this PR, one test was deduplicated (the Dependencies test), and the Instances Detailed Statistics cases dealing with archiver data was migrated to make use of synthtrace instead. Snapshots included were redone to match the data generated by synthtrace, but no other cases were changed to ensure the new migrated tests were passing the same assumptions as before.
How to Test
Serverless
It's recommended to be run against MKI
Stateful