[8.17] [APM] Make `trace.id` an optional field (#201821) #201939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes [elastic#201803](elastic#201803) ## Summary This PR fixes the error sample details function, making the `trace.id` an optional field, to prevent the function from crashing in case this field is not in the docs. --------- Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit caea206)
botelastic
bot
added
ci:project-deploy-observability
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
💚 Build Succeeded
Metrics [docs]
|
crespocarlos
added a commit
that referenced
this pull request
Nov 27, 2024
# Backport This will backport the following commits from `main` to `8.16`: - [[APM] Make `trace.id` an optional field (#201821)](#201821) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Carlos Crespo","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-27T10:55:51Z","message":"[APM] Make `trace.id` an optional field (#201821)\n\nfixes [#201803](https://github.com/elastic/kibana/issues/201803)\r\n\r\n## Summary\r\n\r\nThis PR fixes the error sample details function, making the `trace.id`\r\nan optional field, to prevent the function from crashing in case this\r\nfield is not in the docs.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"caea2066e4ca70e913b83a1ae13d3f2cd0d46804","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services","v8.16.0","backport:version","v8.17.0","v8.18.0"],"number":201821,"url":"https://github.com/elastic/kibana/pull/201821","mergeCommit":{"message":"[APM] Make `trace.id` an optional field (#201821)\n\nfixes [#201803](https://github.com/elastic/kibana/issues/201803)\r\n\r\n## Summary\r\n\r\nThis PR fixes the error sample details function, making the `trace.id`\r\nan optional field, to prevent the function from crashing in case this\r\nfield is not in the docs.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"caea2066e4ca70e913b83a1ae13d3f2cd0d46804"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201821","number":201821,"mergeCommit":{"message":"[APM] Make `trace.id` an optional field (#201821)\n\nfixes [#201803](https://github.com/elastic/kibana/issues/201803)\r\n\r\n## Summary\r\n\r\nThis PR fixes the error sample details function, making the `trace.id`\r\nan optional field, to prevent the function from crashing in case this\r\nfield is not in the docs.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"caea2066e4ca70e913b83a1ae13d3f2cd0d46804"}},{"branch":"8.16","label":"v8.16.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/201939","number":201939,"state":"MERGED","mergeCommit":{"sha":"7b10d16a8e1557fa7af07a3ad40ac866b7c462df","message":"[8.17] [APM] Make `trace.id` an optional field (#201821) (#201939)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.17`:\n- [[APM] Make `trace.id` an optional field\n(#201821)](https://github.com/elastic/kibana/pull/201821)\n\n<!--- Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Carlos\nCrespo\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2024-11-27T10:55:51Z\",\"message\":\"[APM]\nMake `trace.id` an optional field (#201821)\\n\\nfixes\n[#201803](https://github.com/elastic/kibana/issues/201803)\\r\\n\\r\\n##\nSummary\\r\\n\\r\\nThis PR fixes the error sample details function, making\nthe `trace.id`\\r\\nan optional field, to prevent the function from\ncrashing in case this\\r\\nfield is not in the\ndocs.\\r\\n\\r\\n---------\\r\\n\\r\\nCo-authored-by: Elastic Machine\n<[email protected]>\",\"sha\":\"caea2066e4ca70e913b83a1ae13d3f2cd0d46804\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.18.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:skip\",\"v9.0.0\",\"backport:prev-minor\",\"ci:project-deploy-observability\",\"Team:obs-ux-infra_services\",\"v8.16.0\",\"backport:version\",\"v8.17.0\"],\"title\":\"[APM]\nMake `trace.id` an optional\nfield\",\"number\":201821,\"url\":\"https://github.com/elastic/kibana/pull/201821\",\"mergeCommit\":{\"message\":\"[APM]\nMake `trace.id` an optional field (#201821)\\n\\nfixes\n[#201803](https://github.com/elastic/kibana/issues/201803)\\r\\n\\r\\n##\nSummary\\r\\n\\r\\nThis PR fixes the error sample details function, making\nthe `trace.id`\\r\\nan optional field, to prevent the function from\ncrashing in case this\\r\\nfield is not in the\ndocs.\\r\\n\\r\\n---------\\r\\n\\r\\nCo-authored-by: Elastic Machine\n<[email protected]>\",\"sha\":\"caea2066e4ca70e913b83a1ae13d3f2cd0d46804\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[\"8.16\",\"8.17\"],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/201821\",\"number\":201821,\"mergeCommit\":{\"message\":\"[APM]\nMake `trace.id` an optional field (#201821)\\n\\nfixes\n[#201803](https://github.com/elastic/kibana/issues/201803)\\r\\n\\r\\n##\nSummary\\r\\n\\r\\nThis PR fixes the error sample details function, making\nthe `trace.id`\\r\\nan optional field, to prevent the function from\ncrashing in case this\\r\\nfield is not in the\ndocs.\\r\\n\\r\\n---------\\r\\n\\r\\nCo-authored-by: Elastic Machine\n<[email protected]>\",\"sha\":\"caea2066e4ca70e913b83a1ae13d3f2cd0d46804\"}},{\"branch\":\"8.16\",\"label\":\"v8.16.0\",\"branchLabelMappingKey\":\"^v(\\\\d+).(\\\\d+).\\\\d+$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"},{\"branch\":\"8.17\",\"label\":\"v8.17.0\",\"branchLabelMappingKey\":\"^v(\\\\d+).(\\\\d+).\\\\d+$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"}]}]\nBACKPORT-->\n\nCo-authored-by: Carlos Crespo <[email protected]>"}},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/201940","number":201940,"state":"MERGED","mergeCommit":{"sha":"4c3fcad3a7e94f2a340940acefe915414bbfabc4","message":"[8.x] [APM] Make `trace.id` an optional field (#201821) (#201940)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.x`:\n- [[APM] Make `trace.id` an optional field\n(#201821)](https://github.com/elastic/kibana/pull/201821)\n\n<!--- Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Carlos\nCrespo\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2024-11-27T10:55:51Z\",\"message\":\"[APM]\nMake `trace.id` an optional field (#201821)\\n\\nfixes\n[#201803](https://github.com/elastic/kibana/issues/201803)\\r\\n\\r\\n##\nSummary\\r\\n\\r\\nThis PR fixes the error sample details function, making\nthe `trace.id`\\r\\nan optional field, to prevent the function from\ncrashing in case this\\r\\nfield is not in the\ndocs.\\r\\n\\r\\n---------\\r\\n\\r\\nCo-authored-by: Elastic Machine\n<[email protected]>\",\"sha\":\"caea2066e4ca70e913b83a1ae13d3f2cd0d46804\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.18.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:skip\",\"v9.0.0\",\"backport:prev-minor\",\"ci:project-deploy-observability\",\"Team:obs-ux-infra_services\",\"v8.16.0\",\"backport:version\",\"v8.17.0\"],\"title\":\"[APM]\nMake `trace.id` an optional\nfield\",\"number\":201821,\"url\":\"https://github.com/elastic/kibana/pull/201821\",\"mergeCommit\":{\"message\":\"[APM]\nMake `trace.id` an optional field (#201821)\\n\\nfixes\n[#201803](https://github.com/elastic/kibana/issues/201803)\\r\\n\\r\\n##\nSummary\\r\\n\\r\\nThis PR fixes the error sample details function, making\nthe `trace.id`\\r\\nan optional field, to prevent the function from\ncrashing in case this\\r\\nfield is not in the\ndocs.\\r\\n\\r\\n---------\\r\\n\\r\\nCo-authored-by: Elastic Machine\n<[email protected]>\",\"sha\":\"caea2066e4ca70e913b83a1ae13d3f2cd0d46804\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[\"8.16\",\"8.17\"],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/201821\",\"number\":201821,\"mergeCommit\":{\"message\":\"[APM]\nMake `trace.id` an optional field (#201821)\\n\\nfixes\n[#201803](https://github.com/elastic/kibana/issues/201803)\\r\\n\\r\\n##\nSummary\\r\\n\\r\\nThis PR fixes the error sample details function, making\nthe `trace.id`\\r\\nan optional field, to prevent the function from\ncrashing in case this\\r\\nfield is not in the\ndocs.\\r\\n\\r\\n---------\\r\\n\\r\\nCo-authored-by: Elastic Machine\n<[email protected]>\",\"sha\":\"caea2066e4ca70e913b83a1ae13d3f2cd0d46804\"}},{\"branch\":\"8.16\",\"label\":\"v8.16.0\",\"branchLabelMappingKey\":\"^v(\\\\d+).(\\\\d+).\\\\d+$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"},{\"branch\":\"8.17\",\"label\":\"v8.17.0\",\"branchLabelMappingKey\":\"^v(\\\\d+).(\\\\d+).\\\\d+$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"}]}]\nBACKPORT-->\n\nCo-authored-by: Carlos Crespo <[email protected]>"}}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.17:Questions ?
Please refer to the Backport tool documentation