Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Remove 9.0 breaking changes from 8.x docs #202219

Conversation

florent-leborgne
Copy link
Contributor

This PR removes 9.0 entries from the 8.x breaking changes list

@florent-leborgne florent-leborgne added Team:Docs release_note:skip Skip the PR/issue when compiling release notes docs backport:version Backport to applied version labels v8.17.0 v8.18.0 labels Nov 28, 2024
@florent-leborgne florent-leborgne requested review from lcawl, wajihaparvez and a team November 28, 2024 17:17
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

Copy link
Contributor

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@florent-leborgne florent-leborgne enabled auto-merge (squash) November 28, 2024 17:28
@wajihaparvez wajihaparvez self-assigned this Nov 28, 2024
@wajihaparvez
Copy link
Contributor

buildkite test this

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

cc @wajihaparvez

@lcawl
Copy link
Contributor

lcawl commented Nov 29, 2024

The build failure:

INFO:build_docs:  Kibana [8.x]: packages/kbn-doc-links/src/get_doc_links.ts contains broken links to:
--
  | INFO:build_docs:   - en/kibana/8.x/breaking-changes-summary.html#breaking-199656
  | INFO:build_docs:   - en/kibana/8.x/breaking-changes-summary.html#breaking-201004
  | INFO:build_docs:   - en/kibana/8.x/breaking-changes-summary.html#breaking-201550

Is due to the entries in the doc link service like this:

deprecatedV1Endpoints: `${KIBANA_DOCS}breaking-changes-summary.html#breaking-199656`,

It looks like they're used in deprecation messages in the product, so we either need to leave them or else change them to point to "master" and then change again when V9 is forked.

@wajihaparvez
Copy link
Contributor

Based on more offline discussions with @lcawl, to avoid any confusion, we'll revisit this in January when we have a definitive URL for v9.0.0. Leaving this PR open for now.

Thanks, Lisa!

@kapral18
Copy link
Contributor

Please do not merge this pull request. We disabled auto-merge because we are trying to merge a this big PR as part of sustainable architecture migration which is impossible with ever increasing stream of backports. We will resume the automerge after our PR is merged. Reach out to #sustainable-kibana-architecture for more info.

@kapral18 kapral18 disabled auto-merge December 17, 2024 16:39
@stephmilovic stephmilovic enabled auto-merge (squash) December 17, 2024 19:30
@florent-leborgne
Copy link
Contributor Author

It looks like they're used in deprecation messages in the product, so we either need to leave them or else change them to point to "master" and then change again when V9 is forked.

Hmm yes I overlooked this. I think we should wait to get the definitive URL in the V9 upgrade docs, then update the links of the 8.x get link service to that new v9 URL. It's ok to leave this file as is for now anyway.

@florent-leborgne
Copy link
Contributor Author

Closing this, will revisit later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels docs release_note:skip Skip the PR/issue when compiling release notes Team:Docs v8.17.0 v8.18.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants