-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EDR Workflows] CrowdStrike RTR connector's sub actions #203420
Conversation
/ci |
/ci |
/ci |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM! 👍
@@ -14,4 +14,7 @@ export enum SUB_ACTION { | |||
HOST_ACTIONS = 'hostActions', | |||
GET_AGENT_ONLINE_STATUS = 'getAgentOnlineStatus', | |||
EXECUTE_RTR_COMMAND = 'executeRTRCommand', | |||
EXECUTE_ACTIVE_RESPONDER_RTR = 'batchActiveResponderExecuteRTR', | |||
EXECUTE_ADMIN_RTR = 'batchAdminExecuteRTR', | |||
GET_SCRIPTS = 'getScripts', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these general scripts, or are they specific to RTR? If they’re specific to RTR, consider including ‘RTR’ in the name for clarity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They're related to RTR, added the prefix - thanks 👍
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12276197507 |
💚 Build Succeeded
Metrics [docs]Page load bundle
History
cc @tomsonpl |
(cherry picked from commit 5be7182)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…203420) (#203782) # Backport This will backport the following commits from `main` to `8.x`: - [[EDR Workflows] CrowdStrike RTR connector's sub actions (#203420)](#203420) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Tomasz Ciecierski","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-11T12:18:14Z","message":"[EDR Workflows] CrowdStrike RTR connector's sub actions (#203420)","sha":"5be7182bd44f4cdf98cd3f06bc5b0c1755a13a97","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["v9.0.0","Team:Defend Workflows","release_note:feature","backport:version","v8.18.0"],"title":"[EDR Workflows] CrowdStrike RTR connector's sub actions","number":203420,"url":"https://github.com/elastic/kibana/pull/203420","mergeCommit":{"message":"[EDR Workflows] CrowdStrike RTR connector's sub actions (#203420)","sha":"5be7182bd44f4cdf98cd3f06bc5b0c1755a13a97"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203420","number":203420,"mergeCommit":{"message":"[EDR Workflows] CrowdStrike RTR connector's sub actions (#203420)","sha":"5be7182bd44f4cdf98cd3f06bc5b0c1755a13a97"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Tomasz Ciecierski <[email protected]>
Summary
This PR introduces key enhancements and fixes for CrowdStrike RTR functionality, including support for multiple RTR subactions, temporary additions, and improved session management.
Key Changes
1. Support for RTR Subactions
2. Temporary
getScripts
SubActiongetScripts
subaction to retrieve cloud file names and details.3. Dynamic Access Handling for RTR Commands
runscript
, require different access levels depending on the arguments:CloudFile
requires Active Responder access rights.Raw
orHostPath
requires Admin access rights.overwriteUrl
functionality to dynamically manage the API URL used within Kibana based on the command arguments and access requirements.4. Session Manager Fix
this
was not bound correctly in thesessionManager
, leading to unexpected behavior during CrowdStrike requests.Previous Steps
Previous Steps
Next Steps