Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Security Assistant] Fix animation border color of security AI assistant (#202319) #203583

Merged
merged 3 commits into from
Dec 18, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…ant (elastic#202319)

## Summary

**Resolves: elastic#186135

Changes:
- Update border color of animated border of the security AI assistance
icon from `euiColorPrimary` to `euiBorderColor`.

Old border color:
<img width="182" alt="image"
src="https://github.com/user-attachments/assets/a41a7859-3f9a-488c-bd4f-2ed25a52a481">

New border color:
<img width="169" alt="image"
src="https://github.com/user-attachments/assets/c7e1fa13-adb0-4014-950f-ae643e4e1d6d">
<img width="347" alt="image"
src="https://github.com/user-attachments/assets/8fba05e2-2a5b-48b2-b367-a58162cdaa9e">

New animated:
![Nov-29-2024
13-58-11](https://github.com/user-attachments/assets/2eaaf5a0-9bc2-4d84-9625-11ed7902c2c8)

### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

### Identify risks

Does this PR introduce any risks? For example, consider risks like hard
to test bugs, performance regression, potential of data loss.

No

Describe the risk, its severity, and mitigation for each identified
risk. Invite stakeholders and evaluate how to proceed before merging.

- [X] [See some risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit 2818a7c)
@kapral18
Copy link
Contributor

Please do not merge this pull request. We disabled auto-merge because we are trying to merge a this big PR as part of sustainable architecture migration which is impossible with ever increasing stream of backports. We will resume the automerge after our PR is merged. Reach out to #sustainable-kibana-architecture for more info.

@kapral18 kapral18 disabled auto-merge December 17, 2024 16:39
@stephmilovic stephmilovic enabled auto-merge (squash) December 17, 2024 19:31
@KDKHD KDKHD force-pushed the backport/8.x/pr-202319 branch from f9d9597 to 43e55b1 Compare December 18, 2024 10:38
@stephmilovic stephmilovic merged commit 7bcc2ae into elastic:8.x Dec 18, 2024
8 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 19.1MB 19.1MB -83.0B

History

cc @KDKHD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants