Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ai][assistant] Refactor search to use new Assistant logo and beacon #204287

Merged

Conversation

clintandrewhall
Copy link
Contributor

@clintandrewhall clintandrewhall commented Dec 13, 2024

A follow-up to #203879

Summary

This PR integrates the new Assistant Icon, Beacon, and Avatar into solutions and packages owned by Search. In most cases this was a 1:1 replacement, but in a few, Icon was replaced with Beacon or Beacon was added for consistency, (e.g. welcome screens, upsells, etc), .

Note: the scaling of the icon/avatar before was one different from EUI. The new components match EUI directly and represent a 2x scale change (e.g. 's' becomes 'l', 'm' becomes 'xl', etc).

@clintandrewhall clintandrewhall added review release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.18.0 labels Dec 13, 2024
@clintandrewhall clintandrewhall requested a review from a team as a code owner December 13, 2024 22:22
@clintandrewhall clintandrewhall added v9.0.0 backport:prev-major Backport to (8.x, 8.17, 8.16) the previous major branch and other branches in development backport:version Backport to applied version labels and removed backport:skip This commit does not require backporting backport:prev-major Backport to (8.x, 8.17, 8.16) the previous major branch and other branches in development labels Dec 18, 2024
@clintandrewhall clintandrewhall enabled auto-merge (squash) December 18, 2024 13:12
@clintandrewhall clintandrewhall merged commit e078673 into elastic:main Dec 18, 2024
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12395451683

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observabilityAiAssistantManagement 368 381 +13
searchAssistant 241 248 +7
total +20

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observabilityAIAssistantApp 295.1KB 295.1KB -23.0B
searchAssistant 160.2KB 163.2KB +3.0KB
total +3.0KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observabilityAIAssistantApp 12.8KB 14.8KB +2.0KB
searchAssistant 4.8KB 4.9KB +104.0B
total +2.1KB
Unknown metric groups

async chunk count

id before after diff
searchAssistant 1 2 +1

References to deprecated APIs

id before after diff
@kbn/ai-assistant 4 0 -4
searchAssistant 2 0 -2
total -6

History

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.x Backport failed because of merge conflicts

You might need to backport the following PRs to 8.x:
- [ai][assistant] Create AI Assistant Icon, Avatar, Beacon (#203879)

Manual backport

To create the backport manually run:

node scripts/backport --pr 204287

Questions ?

Please refer to the Backport tool documentation

clintandrewhall added a commit to clintandrewhall/kibana that referenced this pull request Dec 18, 2024
…lastic#204287)

> A follow-up to elastic#203879

## Summary

This PR integrates the new Assistant Icon, Beacon, and Avatar into
solutions and packages owned by Search. In most cases this was a 1:1
replacement, but in a few, Icon was replaced with Beacon or Beacon was
added for consistency, (e.g. welcome screens, upsells, etc), .

Note: the scaling of the icon/avatar _before_ was one different from
EUI. The new components match EUI directly and represent a 2x scale
change (e.g. 's' becomes 'l', 'm' becomes 'xl', etc).

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit e078673)
@clintandrewhall
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

clintandrewhall added a commit that referenced this pull request Dec 18, 2024
…eacon (#204287) (#204772)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ai][assistant] Refactor search to use new Assistant logo and beacon
(#204287)](#204287)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Clint Andrew
Hall","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-18T14:51:45Z","message":"[ai][assistant]
Refactor search to use new Assistant logo and beacon (#204287)\n\n> A
follow-up to #203879 \r\n\r\n## Summary\r\n\r\nThis PR integrates the
new Assistant Icon, Beacon, and Avatar into\r\nsolutions and packages
owned by Search. In most cases this was a 1:1\r\nreplacement, but in a
few, Icon was replaced with Beacon or Beacon was\r\nadded for
consistency, (e.g. welcome screens, upsells, etc), .\r\n\r\nNote: the
scaling of the icon/avatar _before_ was one different from\r\nEUI. The
new components match EUI directly and represent a 2x scale\r\nchange
(e.g. 's' becomes 'l', 'm' becomes 'xl',
etc).\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"e0786738c950870c49b4899937cc3904a1b8ef97","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["review","release_note:skip","v9.0.0","backport:version","v8.18.0"],"number":204287,"url":"https://github.com/elastic/kibana/pull/204287","mergeCommit":{"message":"[ai][assistant]
Refactor search to use new Assistant logo and beacon (#204287)\n\n> A
follow-up to #203879 \r\n\r\n## Summary\r\n\r\nThis PR integrates the
new Assistant Icon, Beacon, and Avatar into\r\nsolutions and packages
owned by Search. In most cases this was a 1:1\r\nreplacement, but in a
few, Icon was replaced with Beacon or Beacon was\r\nadded for
consistency, (e.g. welcome screens, upsells, etc), .\r\n\r\nNote: the
scaling of the icon/avatar _before_ was one different from\r\nEUI. The
new components match EUI directly and represent a 2x scale\r\nchange
(e.g. 's' becomes 'l', 'm' becomes 'xl',
etc).\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"e0786738c950870c49b4899937cc3904a1b8ef97"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204287","number":204287,"mergeCommit":{"message":"[ai][assistant]
Refactor search to use new Assistant logo and beacon (#204287)\n\n> A
follow-up to #203879 \r\n\r\n## Summary\r\n\r\nThis PR integrates the
new Assistant Icon, Beacon, and Avatar into\r\nsolutions and packages
owned by Search. In most cases this was a 1:1\r\nreplacement, but in a
few, Icon was replaced with Beacon or Beacon was\r\nadded for
consistency, (e.g. welcome screens, upsells, etc), .\r\n\r\nNote: the
scaling of the icon/avatar _before_ was one different from\r\nEUI. The
new components match EUI directly and represent a 2x scale\r\nchange
(e.g. 's' becomes 'l', 'm' becomes 'xl',
etc).\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"e0786738c950870c49b4899937cc3904a1b8ef97"}},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this pull request Dec 19, 2024
…lastic#204287)

> A follow-up to elastic#203879 

## Summary

This PR integrates the new Assistant Icon, Beacon, and Avatar into
solutions and packages owned by Search. In most cases this was a 1:1
replacement, but in a few, Icon was replaced with Beacon or Beacon was
added for consistency, (e.g. welcome screens, upsells, etc), .

Note: the scaling of the icon/avatar _before_ was one different from
EUI. The new components match EUI directly and represent a 2x scale
change (e.g. 's' becomes 'l', 'm' becomes 'xl', etc).

---------

Co-authored-by: kibanamachine <[email protected]>
benakansara pushed a commit to benakansara/kibana that referenced this pull request Jan 2, 2025
…lastic#204287)

> A follow-up to elastic#203879 

## Summary

This PR integrates the new Assistant Icon, Beacon, and Avatar into
solutions and packages owned by Search. In most cases this was a 1:1
replacement, but in a few, Icon was replaced with Beacon or Beacon was
added for consistency, (e.g. welcome screens, upsells, etc), .

Note: the scaling of the icon/avatar _before_ was one different from
EUI. The new components match EUI directly and represent a 2x scale
change (e.g. 's' becomes 'l', 'm' becomes 'xl', etc).

---------

Co-authored-by: kibanamachine <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Jan 13, 2025
…lastic#204287)

> A follow-up to elastic#203879 

## Summary

This PR integrates the new Assistant Icon, Beacon, and Avatar into
solutions and packages owned by Search. In most cases this was a 1:1
replacement, but in a few, Icon was replaced with Beacon or Beacon was
added for consistency, (e.g. welcome screens, upsells, etc), .

Note: the scaling of the icon/avatar _before_ was one different from
EUI. The new components match EUI directly and represent a 2x scale
change (e.g. 's' becomes 'l', 'm' becomes 'xl', etc).

---------

Co-authored-by: kibanamachine <[email protected]>
viduni94 pushed a commit to viduni94/kibana that referenced this pull request Jan 23, 2025
…lastic#204287)

> A follow-up to elastic#203879 

## Summary

This PR integrates the new Assistant Icon, Beacon, and Avatar into
solutions and packages owned by Search. In most cases this was a 1:1
replacement, but in a few, Icon was replaced with Beacon or Beacon was
added for consistency, (e.g. welcome screens, upsells, etc), .

Note: the scaling of the icon/avatar _before_ was one different from
EUI. The new components match EUI directly and represent a 2x scale
change (e.g. 's' becomes 'l', 'm' becomes 'xl', etc).

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes review v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants