[Fleet] Bump install version after removal of deprecated _source.mode… #204471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchaulet
added
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
💔 Build Failed
Failed CI StepsTest Failures
Metrics [docs]
Historycc @nchaulet |
|
@nchaulet I think the intent was that the deprecation warning would only appear for new indices being created with _source.mode mapping attribute. Let me look into this. |
juliaElastic
approved these changes
Dec 17, 2024
nchaulet
added
the
release_note:skip
💚 Build Succeeded
Metrics [docs]
History
cc @nchaulet |
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12376353560 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 17, 2024
elastic#204471) (cherry picked from commit 348ea81)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
4 tasks
stephmilovic
pushed a commit
that referenced
this pull request
Dec 17, 2024
…e.mode… (#204471) (#204604) # Backport This will backport the following commits from `main` to `8.x`: - [[Fleet] Bump install version after removal of deprecated _source.mode… (#204471)](#204471) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nicolas Chaulet","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-17T15:39:08Z","message":"[Fleet] Bump install version after removal of deprecated _source.mode… (#204471)","sha":"348ea81b1e85e846c855635c51e4e7fc3136bda1","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","backport:prev-minor","v8.18.0"],"title":"[Fleet] Bump install version after removal of deprecated _source.mode…","number":204471,"url":"https://github.com/elastic/kibana/pull/204471","mergeCommit":{"message":"[Fleet] Bump install version after removal of deprecated _source.mode… (#204471)","sha":"348ea81b1e85e846c855635c51e4e7fc3136bda1"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204471","number":204471,"mergeCommit":{"message":"[Fleet] Bump install version after removal of deprecated _source.mode… (#204471)","sha":"348ea81b1e85e846c855635c51e4e7fc3136bda1"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nicolas Chaulet <[email protected]>
JoseLuisGJ
pushed a commit
to JoseLuisGJ/kibana
that referenced
this pull request
Dec 19, 2024
benakansara
pushed a commit
to benakansara/kibana
that referenced
this pull request
Jan 2, 2025
nchaulet
added a commit
to nchaulet/kibana
that referenced
this pull request
Jan 10, 2025
elastic#204471) (cherry picked from commit 348ea81)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
nchaulet
added a commit
that referenced
this pull request
Jan 10, 2025
…ce.mode… (#204471) (#206336) # Backport This will backport the following commits from `main` to `8.17`: - [[Fleet] Bump install version after removal of deprecated _source.mode… (#204471)](#204471) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nicolas Chaulet","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-17T15:39:08Z","message":"[Fleet] Bump install version after removal of deprecated _source.mode… (#204471)","sha":"348ea81b1e85e846c855635c51e4e7fc3136bda1","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","backport:prev-minor","v8.18.0","v8.17.1","backport:8.17"],"number":204471,"url":"https://github.com/elastic/kibana/pull/204471","mergeCommit":{"message":"[Fleet] Bump install version after removal of deprecated _source.mode… (#204471)","sha":"348ea81b1e85e846c855635c51e4e7fc3136bda1"}},"sourceBranch":"main","suggestedTargetBranches":["8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204471","number":204471,"mergeCommit":{"message":"[Fleet] Bump install version after removal of deprecated _source.mode… (#204471)","sha":"348ea81b1e85e846c855635c51e4e7fc3136bda1"}},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/204604","number":204604,"state":"MERGED","mergeCommit":{"sha":"442d5f2b863967fdca5c2404ff84058e76f3f12c","message":"[8.x] [Fleet] Bump install version after removal of deprecated _source.mode… (#204471) (#204604)\n\n# Backport\r\n\r\nThis will backport the following commits from `main` to `8.x`:\r\n- [[Fleet] Bump install version after removal of deprecated\r\n_source.mode… (#204471)](https://github.com/elastic/kibana/pull/204471)\r\n\r\n<!--- Backport version: 9.4.3 -->\r\n\r\n### Questions ?\r\nPlease refer to the [Backport tool\r\ndocumentation](https://github.com/sqren/backport)\r\n\r\n<!--BACKPORT [{\"author\":{\"name\":\"Nicolas\r\nChaulet\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2024-12-17T15:39:08Z\",\"message\":\"[Fleet]\r\nBump install version after removal of deprecated _source.mode…\r\n(#204471)\",\"sha\":\"348ea81b1e85e846c855635c51e4e7fc3136bda1\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.18.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:skip\",\"Team:Fleet\",\"v9.0.0\",\"backport:prev-minor\",\"v8.18.0\"],\"title\":\"[Fleet]\r\nBump install version after removal of deprecated\r\n_source.mode…\",\"number\":204471,\"url\":\"https://github.com/elastic/kibana/pull/204471\",\"mergeCommit\":{\"message\":\"[Fleet]\r\nBump install version after removal of deprecated _source.mode…\r\n(#204471)\",\"sha\":\"348ea81b1e85e846c855635c51e4e7fc3136bda1\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[\"8.x\"],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/204471\",\"number\":204471,\"mergeCommit\":{\"message\":\"[Fleet]\r\nBump install version after removal of deprecated _source.mode…\r\n(#204471)\",\"sha\":\"348ea81b1e85e846c855635c51e4e7fc3136bda1\"}},{\"branch\":\"8.x\",\"label\":\"v8.18.0\",\"branchLabelMappingKey\":\"^v8.18.0$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"}]}]\r\nBACKPORT-->\r\n\r\nCo-authored-by: Nicolas Chaulet <[email protected]>"}},{"branch":"8.17","label":"v8.17.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following https://github.com/elastic/kibana/pull/202729/files
That PR bump the install version of package, so every packages are reinstalled on setup, and the new index template do not contains the deprecated
_source.mode:syntheticvalue.@kpollich I tested manually the upgrade and it seems the upgrade assistant still show cirtical issues for old backing index of datastreams
@martijnvg what will be the way to properly fix datastreams here?