-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ResponseOps][Rules] Move APM rule types params to the @kbn/response-ops-rule-params package #204637
[ResponseOps][Rules] Move APM rule types params to the @kbn/response-ops-rule-params package #204637
Conversation
…t --include-path /api/status --include-path /api/alerting/rule/ --include-path /api/alerting/rules --include-path /api/actions --include-path /api/security/role --include-path /api/spaces --include-path /api/fleet --include-path /api/dashboards --update'
…alvi/kibana into apm-rule-types-package
Pinging @elastic/response-ops (Team:ResponseOps) |
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
…t --include-path /api/status --include-path /api/alerting/rule/ --include-path /api/alerting/rules --include-path /api/actions --include-path /api/security/role --include-path /api/spaces --include-path /api/fleet --include-path /api/dashboards --update'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just code review, changes in apm LGTM
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12596054711 |
💔 All backports failed
Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…ponse-ops-rule-params package (#204637) (#205720) # Backport This will backport the following commits from `main` to `8.x`: - [[ResponseOps][Rules] Move APM rule types params to the @kbn/response-ops-rule-params package (#204637)](#204637) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Janki Salvi","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-03T10:07:46Z","message":"[ResponseOps][Rules] Move APM rule types params to the @kbn/response-ops-rule-params package (#204637)\n\n## Summary\r\n\r\nResolves https://github.com/elastic/kibana/issues/195186\r\n\r\n\r\n### Checklist\r\n\r\n- [x]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"25d7849fc96810ae2edd254e0d8d8c40d711b155","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","backport missing","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services","v8.18.0"],"number":204637,"url":"https://github.com/elastic/kibana/pull/204637","mergeCommit":{"message":"[ResponseOps][Rules] Move APM rule types params to the @kbn/response-ops-rule-params package (#204637)\n\n## Summary\r\n\r\nResolves https://github.com/elastic/kibana/issues/195186\r\n\r\n\r\n### Checklist\r\n\r\n- [x]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"25d7849fc96810ae2edd254e0d8d8c40d711b155"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204637","number":204637,"mergeCommit":{"message":"[ResponseOps][Rules] Move APM rule types params to the @kbn/response-ops-rule-params package (#204637)\n\n## Summary\r\n\r\nResolves https://github.com/elastic/kibana/issues/195186\r\n\r\n\r\n### Checklist\r\n\r\n- [x]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"25d7849fc96810ae2edd254e0d8d8c40d711b155"}},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
…ops-rule-params package (elastic#204637) ## Summary Resolves elastic#195186 ### Checklist - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials --------- Co-authored-by: kibanamachine <[email protected]>
Summary
Resolves #195186
Checklist