Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ResponseOps][Rules] Move APM rule types params to the @kbn/response-ops-rule-params package #204637

Merged
merged 21 commits into from
Jan 3, 2025

Conversation

js-jankisalvi
Copy link
Contributor

@js-jankisalvi js-jankisalvi commented Dec 17, 2024

Summary

Resolves #195186

Checklist

  • Documentation was added for features that require explanation or tutorials

@js-jankisalvi js-jankisalvi self-assigned this Dec 17, 2024
@js-jankisalvi js-jankisalvi changed the title initial commit [ResponseOps][Rules] move apm rule type params to package Dec 17, 2024
@js-jankisalvi js-jankisalvi changed the title [ResponseOps][Rules] move apm rule type params to package [ResponseOps][Rules] Move APM rule types params to the @kbn/response-ops-rule-params package Dec 23, 2024
@js-jankisalvi js-jankisalvi added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v9.0.0 v8.18.0 backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Dec 23, 2024
@js-jankisalvi js-jankisalvi marked this pull request as ready for review December 23, 2024 10:35
@js-jankisalvi js-jankisalvi requested review from a team as code owners December 23, 2024 10:35
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Dec 23, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

js-jankisalvi and others added 4 commits December 23, 2024 13:20
…t --include-path /api/status --include-path /api/alerting/rule/ --include-path /api/alerting/rules --include-path /api/actions --include-path /api/security/role --include-path /api/spaces --include-path /api/fleet --include-path /api/dashboards --update'
Copy link
Contributor

@MiriamAparicio MiriamAparicio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just code review, changes in apm LGTM

@elasticmachine
Copy link
Contributor

elasticmachine commented Jan 2, 2025

💛 Build succeeded, but was flaky

  • Buildkite Build
  • Commit: 12a9e52
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-204637-12a9e522b619

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #29 / Serverless Common UI - Management Index Management Data Streams Modify data streams index mode allows to downgrade data stream from logsdb to standard index mode

Metrics [docs]

✅ unchanged

History

cc @js-jankisalvi

@js-jankisalvi js-jankisalvi merged commit 25d7849 into elastic:main Jan 3, 2025
8 checks passed
@js-jankisalvi js-jankisalvi deleted the apm-rule-types-package branch January 3, 2025 10:07
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12596054711

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 204637

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 7, 2025
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 204637 locally

@js-jankisalvi
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

js-jankisalvi added a commit that referenced this pull request Jan 7, 2025
…ponse-ops-rule-params package (#204637) (#205720)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ResponseOps][Rules] Move APM rule types params to the
@kbn/response-ops-rule-params package
(#204637)](#204637)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Janki
Salvi","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-03T10:07:46Z","message":"[ResponseOps][Rules]
Move APM rule types params to the @kbn/response-ops-rule-params package
(#204637)\n\n## Summary\r\n\r\nResolves
https://github.com/elastic/kibana/issues/195186\r\n\r\n\r\n###
Checklist\r\n\r\n-
[x]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or
tutorials\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"25d7849fc96810ae2edd254e0d8d8c40d711b155","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","backport
missing","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services","v8.18.0"],"number":204637,"url":"https://github.com/elastic/kibana/pull/204637","mergeCommit":{"message":"[ResponseOps][Rules]
Move APM rule types params to the @kbn/response-ops-rule-params package
(#204637)\n\n## Summary\r\n\r\nResolves
https://github.com/elastic/kibana/issues/195186\r\n\r\n\r\n###
Checklist\r\n\r\n-
[x]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or
tutorials\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"25d7849fc96810ae2edd254e0d8d8c40d711b155"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204637","number":204637,"mergeCommit":{"message":"[ResponseOps][Rules]
Move APM rule types params to the @kbn/response-ops-rule-params package
(#204637)\n\n## Summary\r\n\r\nResolves
https://github.com/elastic/kibana/issues/195186\r\n\r\n\r\n###
Checklist\r\n\r\n-
[x]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or
tutorials\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"25d7849fc96810ae2edd254e0d8d8c40d711b155"}},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 7, 2025
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Jan 13, 2025
…ops-rule-params package (elastic#204637)

## Summary

Resolves elastic#195186


### Checklist

- [x]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ResponseOps][Rules] Move the params of APM rule types to the @kbn/response-ops-rule-params package
6 participants