Add ".reindexed-v8-" prefix to the valid prefixes list #204819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ersin-erdal
reviewed
Dec 18, 2024
| '.alerts-', | ||
| '.internal.preview.alerts-', | ||
| '.internal.alerts-', | ||
| '.reindexed-v8-internal.alerts', |
There was a problem hiding this comment.
should this have a "-" suffix?
There was a problem hiding this comment.
sure..feel free to update!
ersin-erdal
added
release_note:skip
ersin-erdal
added
the
ci:project-deploy-observability
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
Pinging @elastic/response-ops (Team:ResponseOps) |
ersin-erdal
changed the title
⏳ Build in-progress
History
cc @ersin-erdal |
mikecote
approved these changes
Jan 7, 2025
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12659116367 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 7, 2025
As part of v9.0 readiness, we reindex the indices in v.8 but still has data from v.7x. As a result of the process, the reindexed indices get `.reindexed-v8-` prefix. This PR add that prefix to the valid prefixes list. # To verify: Run Kibana and ES in 7.17 (use `-E path.data=your-data-path` to keep the data in your local) Create some rules that generate alerts (Observability rules to have AAD) Let them run for a while. Stop Kibana and ES, switch to 8.x branch and run ES and Kibana again Open the Upgrade Assistant. It should show the `.internal.alerts-*` indices Click on them and start reindexing on the opened flyout. Check that `.reindexed-v8-internal.alerts-*` index has been created Let you rules run for a while again. Your alerts should be updated and there shouldn't be any error on your terminal. --------- Co-authored-by: Ersin Erdal <[email protected]> Co-authored-by: Ersin Erdal <[email protected]> (cherry picked from commit 8a9202e)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kowalczyk-krzysztof
pushed a commit
to kowalczyk-krzysztof/kibana
that referenced
this pull request
Jan 7, 2025
As part of v9.0 readiness, we reindex the indices in v.8 but still has data from v.7x. As a result of the process, the reindexed indices get `.reindexed-v8-` prefix. This PR add that prefix to the valid prefixes list. # To verify: Run Kibana and ES in 7.17 (use `-E path.data=your-data-path` to keep the data in your local) Create some rules that generate alerts (Observability rules to have AAD) Let them run for a while. Stop Kibana and ES, switch to 8.x branch and run ES and Kibana again Open the Upgrade Assistant. It should show the `.internal.alerts-*` indices Click on them and start reindexing on the opened flyout. Check that `.reindexed-v8-internal.alerts-*` index has been created Let you rules run for a while again. Your alerts should be updated and there shouldn't be any error on your terminal. --------- Co-authored-by: Ersin Erdal <[email protected]> Co-authored-by: Ersin Erdal <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Jan 7, 2025
#204819) (#205809) # Backport This will backport the following commits from `main` to `8.x`: - [Add ".reindexed-v8-" prefix to the valid prefixes list (#204819)](#204819) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ying Mao","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-07T20:50:52Z","message":"Add \".reindexed-v8-\" prefix to the valid prefixes list (#204819)\n\nAs part of v9.0 readiness, we reindex the indices in v.8 but still has\r\ndata from v.7x.\r\nAs a result of the process, the reindexed indices get `.reindexed-v8-`\r\nprefix.\r\nThis PR add that prefix to the valid prefixes list.\r\n\r\n\r\n# To verify:\r\n\r\nRun Kibana and ES in 7.17 (use `-E path.data=your-data-path` to keep the\r\ndata in your local)\r\nCreate some rules that generate alerts (Observability rules to have AAD)\r\nLet them run for a while.\r\nStop Kibana and ES, switch to 8.x branch and run ES and Kibana again\r\nOpen the Upgrade Assistant.\r\nIt should show the `.internal.alerts-*` indices \r\nClick on them and start reindexing on the opened flyout.\r\nCheck that `.reindexed-v8-internal.alerts-*` index has been created\r\nLet you rules run for a while again.\r\nYour alerts should be updated and there shouldn't be any error on your\r\nterminal.\r\n\r\n---------\r\n\r\nCo-authored-by: Ersin Erdal <[email protected]>\r\nCo-authored-by: Ersin Erdal <[email protected]>","sha":"8a9202ed8ec8a7cc8347ad228d15f3c602d75c99","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","v9.0.0","backport:prev-minor","ci:project-deploy-observability"],"title":"Add \".reindexed-v8-\" prefix to the valid prefixes list","number":204819,"url":"https://github.com/elastic/kibana/pull/204819","mergeCommit":{"message":"Add \".reindexed-v8-\" prefix to the valid prefixes list (#204819)\n\nAs part of v9.0 readiness, we reindex the indices in v.8 but still has\r\ndata from v.7x.\r\nAs a result of the process, the reindexed indices get `.reindexed-v8-`\r\nprefix.\r\nThis PR add that prefix to the valid prefixes list.\r\n\r\n\r\n# To verify:\r\n\r\nRun Kibana and ES in 7.17 (use `-E path.data=your-data-path` to keep the\r\ndata in your local)\r\nCreate some rules that generate alerts (Observability rules to have AAD)\r\nLet them run for a while.\r\nStop Kibana and ES, switch to 8.x branch and run ES and Kibana again\r\nOpen the Upgrade Assistant.\r\nIt should show the `.internal.alerts-*` indices \r\nClick on them and start reindexing on the opened flyout.\r\nCheck that `.reindexed-v8-internal.alerts-*` index has been created\r\nLet you rules run for a while again.\r\nYour alerts should be updated and there shouldn't be any error on your\r\nterminal.\r\n\r\n---------\r\n\r\nCo-authored-by: Ersin Erdal <[email protected]>\r\nCo-authored-by: Ersin Erdal <[email protected]>","sha":"8a9202ed8ec8a7cc8347ad228d15f3c602d75c99"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204819","number":204819,"mergeCommit":{"message":"Add \".reindexed-v8-\" prefix to the valid prefixes list (#204819)\n\nAs part of v9.0 readiness, we reindex the indices in v.8 but still has\r\ndata from v.7x.\r\nAs a result of the process, the reindexed indices get `.reindexed-v8-`\r\nprefix.\r\nThis PR add that prefix to the valid prefixes list.\r\n\r\n\r\n# To verify:\r\n\r\nRun Kibana and ES in 7.17 (use `-E path.data=your-data-path` to keep the\r\ndata in your local)\r\nCreate some rules that generate alerts (Observability rules to have AAD)\r\nLet them run for a while.\r\nStop Kibana and ES, switch to 8.x branch and run ES and Kibana again\r\nOpen the Upgrade Assistant.\r\nIt should show the `.internal.alerts-*` indices \r\nClick on them and start reindexing on the opened flyout.\r\nCheck that `.reindexed-v8-internal.alerts-*` index has been created\r\nLet you rules run for a while again.\r\nYour alerts should be updated and there shouldn't be any error on your\r\nterminal.\r\n\r\n---------\r\n\r\nCo-authored-by: Ersin Erdal <[email protected]>\r\nCo-authored-by: Ersin Erdal <[email protected]>","sha":"8a9202ed8ec8a7cc8347ad228d15f3c602d75c99"}}]}] BACKPORT--> Co-authored-by: Ying Mao <[email protected]>
crespocarlos
pushed a commit
to crespocarlos/kibana
that referenced
this pull request
Jan 8, 2025
As part of v9.0 readiness, we reindex the indices in v.8 but still has data from v.7x. As a result of the process, the reindexed indices get `.reindexed-v8-` prefix. This PR add that prefix to the valid prefixes list. # To verify: Run Kibana and ES in 7.17 (use `-E path.data=your-data-path` to keep the data in your local) Create some rules that generate alerts (Observability rules to have AAD) Let them run for a while. Stop Kibana and ES, switch to 8.x branch and run ES and Kibana again Open the Upgrade Assistant. It should show the `.internal.alerts-*` indices Click on them and start reindexing on the opened flyout. Check that `.reindexed-v8-internal.alerts-*` index has been created Let you rules run for a while again. Your alerts should be updated and there shouldn't be any error on your terminal. --------- Co-authored-by: Ersin Erdal <[email protected]> Co-authored-by: Ersin Erdal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of v9.0 readiness, we reindex the indices in v.8 but still has data from v.7x.
As a result of the process, the reindexed indices get
.reindexed-v8-prefix.This PR add that prefix to the valid prefixes list.
To verify:
Run Kibana and ES in 7.17 (use
-E path.data=your-data-pathto keep the data in your local)Create some rules that generate alerts (Observability rules to have AAD)
Let them run for a while.
Stop Kibana and ES, switch to 8.x branch and run ES and Kibana again
Open the Upgrade Assistant.
It should show the
.internal.alerts-*indicesClick on them and start reindexing on the opened flyout.
Check that
.reindexed-v8-internal.alerts-*index has been createdLet you rules run for a while again.
Your alerts should be updated and there shouldn't be any error on your terminal.