Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[embeddable] remove legacy embeddable types #204832

Merged
merged 2 commits into from
Dec 19, 2024
Merged

[embeddable] remove legacy embeddable types #204832

merged 2 commits into from
Dec 19, 2024

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Dec 18, 2024 •
edited by kibanamachine
Loading

Part of embeddable cleanup. PR removes legacy embeddable type guards and types.

@nreese
Copy link
Contributor Author

nreese commented Dec 18, 2024

/ci

@nreese
Copy link
Contributor Author

nreese commented Dec 18, 2024

/ci

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
embeddable 142 132 -10

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
embeddable 291 268 -23

Any counts in public APIs

Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.

id before after diff
embeddable 1 0 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 667.7KB 667.7KB +13.0B
securitySolution 21.4MB 21.4MB +337.0B
total +350.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
embeddable 4 3 -1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
embeddable 49.5KB 47.2KB -2.3KB
Unknown metric groups

API count

id before after diff
embeddable 377 342 -35

History

@nreese nreese marked this pull request as ready for review December 18, 2024 23:36
@nreese nreese requested review from a team as code owners December 18, 2024 23:36
@nreese nreese added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas release_note:skip Skip the PR/issue when compiling release notes v9.0.0 project:embeddableRebuild backport:version Backport to applied version labels v8.18.0 labels Dec 18, 2024
ThomThomson
ThomThomson approved these changes Dec 18, 2024
View reviewed changes
src/plugins/embeddable/public/mocks.tsx
@@ -51,48 +44,6 @@ export const createEmbeddableStateTransferMock = (): Partial<EmbeddableStateTran
};
};

export const mockRefOrValEmbeddable = <
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a relief to see this removed.

@botelastic botelastic bot added the Feature:Embedding Embedding content via iFrame label Dec 18, 2024
markov00
markov00 approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

owned code changes LGTM

markov00
markov00 approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

owned code changes LGTM

@nreese nreese merged commit b321646 into elastic:main Dec 19, 2024
22 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12413665334

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 204832

Questions ?

Please refer to the Backport tool documentation

@nreese nreese mentioned this pull request Dec 19, 2024
Merged
@nreese
Copy link
Contributor Author

nreese commented Dec 19, 2024

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@nreese nreese mentioned this pull request Dec 19, 2024
Merged
Ikuni17 pushed a commit that referenced this pull request Dec 19, 2024
@nreese
[visualizations] fix eslint error (#204972)
5df5e4f 
#204816 merged into main
then #204832 merged into main. The
combination of these merges resulted in an eslint error in main.
nreese added a commit that referenced this pull request Dec 19, 2024
@nreese @kibanamachine
[8.x] [embeddable] remove legacy embeddable types (#204832) (#204952)
8a46374 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[embeddable] remove legacy embeddable types
(#204832)](#204832)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nathan
Reese","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-19T13:29:20Z","message":"[embeddable]
remove legacy embeddable types (#204832)\n\nPart of embeddable cleanup.
PR removes legacy embeddable type guards
and\r\ntypes.","sha":"b321646d03fb7bfc9e9a323822432d145bc07411","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Embedding","Team:Presentation","release_note:skip","v9.0.0","project:embeddableRebuild","backport:version","v8.18.0"],"number":204832,"url":"https://github.com/elastic/kibana/pull/204832","mergeCommit":{"message":"[embeddable]
remove legacy embeddable types (#204832)\n\nPart of embeddable cleanup.
PR removes legacy embeddable type guards
and\r\ntypes.","sha":"b321646d03fb7bfc9e9a323822432d145bc07411"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204832","number":204832,"mergeCommit":{"message":"[embeddable]
remove legacy embeddable types (#204832)\n\nPart of embeddable cleanup.
PR removes legacy embeddable type guards
and\r\ntypes.","sha":"b321646d03fb7bfc9e9a323822432d145bc07411"}},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

---------

Co-authored-by: kibanamachine <[email protected]>
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this pull request Dec 19, 2024
@nreese @JoseLuisGJ
[embeddable] remove legacy embeddable types (elastic#204832)
313488d 
Part of embeddable cleanup. PR removes legacy embeddable type guards and
types.
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this pull request Dec 19, 2024
@nreese @JoseLuisGJ
[visualizations] fix eslint error (elastic#204972)
acacded 
elastic#204816 merged into main
then elastic#204832 merged into main. The
combination of these merges resulted in an eslint error in main.
stratoula pushed a commit to stratoula/kibana that referenced this pull request Jan 2, 2025
@nreese @stratoula
[visualizations] fix eslint error (elastic#204972)
f574ae2 
elastic#204816 merged into main
then elastic#204832 merged into main. The
combination of these merges resulted in an eslint error in main.
benakansara pushed a commit to benakansara/kibana that referenced this pull request Jan 2, 2025
@nreese @benakansara
[embeddable] remove legacy embeddable types (elastic#204832)
b48d5b8 
Part of embeddable cleanup. PR removes legacy embeddable type guards and
types.
benakansara pushed a commit to benakansara/kibana that referenced this pull request Jan 2, 2025
@nreese @benakansara
[visualizations] fix eslint error (elastic#204972)
d405929 
elastic#204816 merged into main
then elastic#204832 merged into main. The
combination of these merges resulted in an eslint error in main.
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Jan 13, 2025
@nreese @CAWilson94
[embeddable] remove legacy embeddable types (elastic#204832)
fc102d9 
Part of embeddable cleanup. PR removes legacy embeddable type guards and
types.
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Jan 13, 2025
@nreese @CAWilson94
[visualizations] fix eslint error (elastic#204972)
09c1959 
elastic#204816 merged into main
then elastic#204832 merged into main. The
combination of these merges resulted in an eslint error in main.
viduni94 pushed a commit to viduni94/kibana that referenced this pull request Jan 23, 2025
@nreese @viduni94
[embeddable] remove legacy embeddable types (elastic#204832)
43d336b 
Part of embeddable cleanup. PR removes legacy embeddable type guards and
types.
viduni94 pushed a commit to viduni94/kibana that referenced this pull request Jan 23, 2025
@nreese @viduni94
[visualizations] fix eslint error (elastic#204972)
47d1bf1 
elastic#204816 merged into main
then elastic#204832 merged into main. The
combination of these merges resulted in an eslint error in main.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomThomson ThomThomson ThomThomson approved these changes

@angorayc angorayc angorayc approved these changes

@markov00 markov00 markov00 approved these changes

Assignees
No one assigned
Labels
backport:version Backport to applied version labels Feature:Embedding Embedding content via iFrame project:embeddableRebuild release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nreese @elasticmachine @kibanamachine @markov00 @angorayc @ThomThomson