[Cloud Security] Added labels popover #204954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfirpeled
added
release_note:skip
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7626[✅] x-pack/test/cloud_security_posture_functional/config.ts: 25/25 tests passed. |
elastic-vault-github-plugin-prod
bot
requested a review
from a team
as a code owner
seanrathier
approved these changes
Dec 19, 2024
...ity/packages/kbn-cloud-security-posture/graph/src/components/graph/graph_popover.stories.tsx
Show resolved
Hide resolved
...oud-security-posture/graph/src/components/graph_investigation/graph_label_expand_popover.tsx
Outdated
Show resolved
Hide resolved
...utions/security/packages/kbn-cloud-security-posture/graph/src/components/node/label_node.tsx
Show resolved
Hide resolved
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12470124664 |
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Unknown metric groupsAPI count
ESLint disabled line counts
Total ESLint disabled count
History
|
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 23, 2024
## Summary Added expand button for labels with popover: https://github.com/user-attachments/assets/80950f51-b45b-4174-9be2-267b6aca569b https://github.com/user-attachments/assets/690ef85b-be48-42df-bf00-02ee7d9303f2 **How to test** To test this PR you can run ``` yarn storybook cloud_security_posture_packages ``` To test e2e - Enable the feature flag `kibana.dev.yml`: ```yml uiSettings.overrides.securitySolution:enableVisualizationsInFlyout: true xpack.securitySolution.enableExperimental: ['graphVisualizationInFlyoutEnabled'] ``` - Load mocked data: ``` node scripts/es_archiver load x-pack/test/cloud_security_posture_functional/es_archives/logs_gcp_audit \ --es-url http://elastic:changeme@localhost:9200 \ --kibana-url http://elastic:changeme@localhost:5601 node scripts/es_archiver load x-pack/test/cloud_security_posture_functional/es_archives/security_alerts \ --es-url http://elastic:changeme@localhost:9200 \ --kibana-url http://elastic:changeme@localhost:5601 ``` - Make sure you include data from Oct 13 2024. (in the video I use Last year) ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed --------- Co-authored-by: Sean Rathier <[email protected]> Co-authored-by: Brad White <[email protected]> Co-authored-by: seanrathier <[email protected]> Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit fd47d2e)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 23, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[Cloud Security] Added labels popover (#204954)](#204954) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kfir Peled","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-23T16:47:24Z","message":"[Cloud Security] Added labels popover (#204954)\n\n## Summary\r\n\r\nAdded expand button for labels with popover:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/80950f51-b45b-4174-9be2-267b6aca569b\r\n\r\n\r\nhttps://github.com/user-attachments/assets/690ef85b-be48-42df-bf00-02ee7d9303f2\r\n\r\n**How to test**\r\n\r\nTo test this PR you can run\r\n\r\n```\r\nyarn storybook cloud_security_posture_packages\r\n```\r\n\r\nTo test e2e\r\n\r\n- Enable the feature flag\r\n\r\n`kibana.dev.yml`:\r\n\r\n```yml\r\nuiSettings.overrides.securitySolution:enableVisualizationsInFlyout: true\r\nxpack.securitySolution.enableExperimental: ['graphVisualizationInFlyoutEnabled']\r\n```\r\n\r\n- Load mocked data:\r\n\r\n```\r\nnode scripts/es_archiver load x-pack/test/cloud_security_posture_functional/es_archives/logs_gcp_audit \\ \r\n --es-url http://elastic:changeme@localhost:9200 \\\r\n --kibana-url http://elastic:changeme@localhost:5601\r\n\r\nnode scripts/es_archiver load x-pack/test/cloud_security_posture_functional/es_archives/security_alerts \\\r\n --es-url http://elastic:changeme@localhost:9200 \\\r\n --kibana-url http://elastic:changeme@localhost:5601\r\n```\r\n\r\n- Make sure you include data from Oct 13 2024. (in the video I use Last\r\nyear)\r\n\r\n### Checklist\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n\r\n---------\r\n\r\nCo-authored-by: Sean Rathier <[email protected]>\r\nCo-authored-by: Brad White <[email protected]>\r\nCo-authored-by: seanrathier <[email protected]>\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"fd47d2ec7ccd9188fa45af85d44a17d143f2e44a","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Cloud Security","backport:prev-minor","ci:build-storybooks"],"title":"[Cloud Security] Added labels popover","number":204954,"url":"https://github.com/elastic/kibana/pull/204954","mergeCommit":{"message":"[Cloud Security] Added labels popover (#204954)\n\n## Summary\r\n\r\nAdded expand button for labels with popover:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/80950f51-b45b-4174-9be2-267b6aca569b\r\n\r\n\r\nhttps://github.com/user-attachments/assets/690ef85b-be48-42df-bf00-02ee7d9303f2\r\n\r\n**How to test**\r\n\r\nTo test this PR you can run\r\n\r\n```\r\nyarn storybook cloud_security_posture_packages\r\n```\r\n\r\nTo test e2e\r\n\r\n- Enable the feature flag\r\n\r\n`kibana.dev.yml`:\r\n\r\n```yml\r\nuiSettings.overrides.securitySolution:enableVisualizationsInFlyout: true\r\nxpack.securitySolution.enableExperimental: ['graphVisualizationInFlyoutEnabled']\r\n```\r\n\r\n- Load mocked data:\r\n\r\n```\r\nnode scripts/es_archiver load x-pack/test/cloud_security_posture_functional/es_archives/logs_gcp_audit \\ \r\n --es-url http://elastic:changeme@localhost:9200 \\\r\n --kibana-url http://elastic:changeme@localhost:5601\r\n\r\nnode scripts/es_archiver load x-pack/test/cloud_security_posture_functional/es_archives/security_alerts \\\r\n --es-url http://elastic:changeme@localhost:9200 \\\r\n --kibana-url http://elastic:changeme@localhost:5601\r\n```\r\n\r\n- Make sure you include data from Oct 13 2024. (in the video I use Last\r\nyear)\r\n\r\n### Checklist\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n\r\n---------\r\n\r\nCo-authored-by: Sean Rathier <[email protected]>\r\nCo-authored-by: Brad White <[email protected]>\r\nCo-authored-by: seanrathier <[email protected]>\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"fd47d2ec7ccd9188fa45af85d44a17d143f2e44a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204954","number":204954,"mergeCommit":{"message":"[Cloud Security] Added labels popover (#204954)\n\n## Summary\r\n\r\nAdded expand button for labels with popover:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/80950f51-b45b-4174-9be2-267b6aca569b\r\n\r\n\r\nhttps://github.com/user-attachments/assets/690ef85b-be48-42df-bf00-02ee7d9303f2\r\n\r\n**How to test**\r\n\r\nTo test this PR you can run\r\n\r\n```\r\nyarn storybook cloud_security_posture_packages\r\n```\r\n\r\nTo test e2e\r\n\r\n- Enable the feature flag\r\n\r\n`kibana.dev.yml`:\r\n\r\n```yml\r\nuiSettings.overrides.securitySolution:enableVisualizationsInFlyout: true\r\nxpack.securitySolution.enableExperimental: ['graphVisualizationInFlyoutEnabled']\r\n```\r\n\r\n- Load mocked data:\r\n\r\n```\r\nnode scripts/es_archiver load x-pack/test/cloud_security_posture_functional/es_archives/logs_gcp_audit \\ \r\n --es-url http://elastic:changeme@localhost:9200 \\\r\n --kibana-url http://elastic:changeme@localhost:5601\r\n\r\nnode scripts/es_archiver load x-pack/test/cloud_security_posture_functional/es_archives/security_alerts \\\r\n --es-url http://elastic:changeme@localhost:9200 \\\r\n --kibana-url http://elastic:changeme@localhost:5601\r\n```\r\n\r\n- Make sure you include data from Oct 13 2024. (in the video I use Last\r\nyear)\r\n\r\n### Checklist\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n\r\n---------\r\n\r\nCo-authored-by: Sean Rathier <[email protected]>\r\nCo-authored-by: Brad White <[email protected]>\r\nCo-authored-by: seanrathier <[email protected]>\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"fd47d2ec7ccd9188fa45af85d44a17d143f2e44a"}}]}] BACKPORT--> Co-authored-by: Kfir Peled <[email protected]>
stratoula
pushed a commit
to stratoula/kibana
that referenced
this pull request
Jan 2, 2025
## Summary Added expand button for labels with popover: https://github.com/user-attachments/assets/80950f51-b45b-4174-9be2-267b6aca569b https://github.com/user-attachments/assets/690ef85b-be48-42df-bf00-02ee7d9303f2 **How to test** To test this PR you can run ``` yarn storybook cloud_security_posture_packages ``` To test e2e - Enable the feature flag `kibana.dev.yml`: ```yml uiSettings.overrides.securitySolution:enableVisualizationsInFlyout: true xpack.securitySolution.enableExperimental: ['graphVisualizationInFlyoutEnabled'] ``` - Load mocked data: ``` node scripts/es_archiver load x-pack/test/cloud_security_posture_functional/es_archives/logs_gcp_audit \ --es-url http://elastic:changeme@localhost:9200 \ --kibana-url http://elastic:changeme@localhost:5601 node scripts/es_archiver load x-pack/test/cloud_security_posture_functional/es_archives/security_alerts \ --es-url http://elastic:changeme@localhost:9200 \ --kibana-url http://elastic:changeme@localhost:5601 ``` - Make sure you include data from Oct 13 2024. (in the video I use Last year) ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed --------- Co-authored-by: Sean Rathier <[email protected]> Co-authored-by: Brad White <[email protected]> Co-authored-by: seanrathier <[email protected]> Co-authored-by: kibanamachine <[email protected]>
benakansara
pushed a commit
to benakansara/kibana
that referenced
this pull request
Jan 2, 2025
## Summary Added expand button for labels with popover: https://github.com/user-attachments/assets/80950f51-b45b-4174-9be2-267b6aca569b https://github.com/user-attachments/assets/690ef85b-be48-42df-bf00-02ee7d9303f2 **How to test** To test this PR you can run ``` yarn storybook cloud_security_posture_packages ``` To test e2e - Enable the feature flag `kibana.dev.yml`: ```yml uiSettings.overrides.securitySolution:enableVisualizationsInFlyout: true xpack.securitySolution.enableExperimental: ['graphVisualizationInFlyoutEnabled'] ``` - Load mocked data: ``` node scripts/es_archiver load x-pack/test/cloud_security_posture_functional/es_archives/logs_gcp_audit \ --es-url http://elastic:changeme@localhost:9200 \ --kibana-url http://elastic:changeme@localhost:5601 node scripts/es_archiver load x-pack/test/cloud_security_posture_functional/es_archives/security_alerts \ --es-url http://elastic:changeme@localhost:9200 \ --kibana-url http://elastic:changeme@localhost:5601 ``` - Make sure you include data from Oct 13 2024. (in the video I use Last year) ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed --------- Co-authored-by: Sean Rathier <[email protected]> Co-authored-by: Brad White <[email protected]> Co-authored-by: seanrathier <[email protected]> Co-authored-by: kibanamachine <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Jan 13, 2025
## Summary Added expand button for labels with popover: https://github.com/user-attachments/assets/80950f51-b45b-4174-9be2-267b6aca569b https://github.com/user-attachments/assets/690ef85b-be48-42df-bf00-02ee7d9303f2 **How to test** To test this PR you can run ``` yarn storybook cloud_security_posture_packages ``` To test e2e - Enable the feature flag `kibana.dev.yml`: ```yml uiSettings.overrides.securitySolution:enableVisualizationsInFlyout: true xpack.securitySolution.enableExperimental: ['graphVisualizationInFlyoutEnabled'] ``` - Load mocked data: ``` node scripts/es_archiver load x-pack/test/cloud_security_posture_functional/es_archives/logs_gcp_audit \ --es-url http://elastic:changeme@localhost:9200 \ --kibana-url http://elastic:changeme@localhost:5601 node scripts/es_archiver load x-pack/test/cloud_security_posture_functional/es_archives/security_alerts \ --es-url http://elastic:changeme@localhost:9200 \ --kibana-url http://elastic:changeme@localhost:5601 ``` - Make sure you include data from Oct 13 2024. (in the video I use Last year) ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed --------- Co-authored-by: Sean Rathier <[email protected]> Co-authored-by: Brad White <[email protected]> Co-authored-by: seanrathier <[email protected]> Co-authored-by: kibanamachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added expand button for labels with popover:
Screen.Recording.2024-12-19.at.15.31.44.mov
Screen.Recording.2024-12-19.at.15.25.25.mov
How to test
To test this PR you can run
To test e2e
kibana.dev.yml:Checklist