Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Assistant] Migrate semantic_text to use highlighter instead of inner_hits #204962

Merged
merged 7 commits into from
Jan 10, 2025
Merged

[Security Assistant] Migrate semantic_text to use highlighter instead of inner_hits #204962

merged 7 commits into from
Jan 10, 2025

Conversation

patrykkopycinski
Copy link
Contributor

@patrykkopycinski patrykkopycinski commented Dec 19, 2024 •
edited by kibanamachine
Loading

Summary

Switch to use elastic/elasticsearch#118064 when retrieving Knowledge base Index entry docs

Followed testing instructions from #198020

Results:
Zrzut ekranu 2024-12-19 o 16 32 28

Zrzut ekranu 2024-12-19 o 16 32 38 Zrzut ekranu 2024-12-19 o 16 32 43 Zrzut ekranu 2024-12-19 o 16 32 47 Zrzut ekranu 2024-12-19 o 16 32 50

@patrykkopycinski patrykkopycinski changed the title Feat/semantic text highlighter [Security Assistant] Migrate semantic_text to use highlighter instead of inner_hits Dec 19, 2024
@patrykkopycinski patrykkopycinski self-assigned this Dec 19, 2024
@patrykkopycinski patrykkopycinski added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 backport:prev-major Backport to (8.x, 8.17, 8.16) the previous major branch and other branches in development Feature:Security Assistant Security Assistant Team:Security Generative AI Security Generative AI v8.18.0 backport:version Backport to applied version labels and removed backport:prev-major Backport to (8.x, 8.17, 8.16) the previous major branch and other branches in development labels Dec 19, 2024
@patrykkopycinski
Copy link
Contributor Author

/ci

@elasticmachine
Copy link
Contributor

elasticmachine commented Jan 7, 2025 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #1 / getStructuredToolForIndexEntry should execute func correctly and return expected results
  • [job] [logs] Jest Tests #1 / getStructuredToolForIndexEntry should execute func correctly and return expected results

Metrics [docs]

✅ unchanged

History

cc @patrykkopycinski

@patrykkopycinski
Copy link
Contributor Author

/ci

@patrykkopycinski patrykkopycinski marked this pull request as ready for review January 8, 2025 19:45
@patrykkopycinski patrykkopycinski requested a review from a team as a code owner January 8, 2025 19:45
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #18 / useMonitorStatusData handles resize events and requests based on new data

Metrics [docs]

✅ unchanged

History

cc @patrykkopycinski

stephmilovic
stephmilovic approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@stephmilovic stephmilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@patrykkopycinski patrykkopycinski merged commit 5539000 into elastic:main Jan 10, 2025
8 checks passed
@patrykkopycinski patrykkopycinski deleted the feat/semantic-text-highlighter branch January 10, 2025 15:51
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12712762063

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 10, 2025
@patrykkopycinski
[Security Assistant] Migrate semantic_text to use highlighter instead…
64169e0 
… of inner_hits (elastic#204962)

## Summary

Switch to use elastic/elasticsearch#118064 when
retrieving Knowledge base Index entry docs

Followed testing instructions from
elastic#198020

Results:
<img width="1498" alt="Zrzut ekranu 2024-12-19 o 16 32 28"
src="https://github.com/user-attachments/assets/a16bf729-ac30-4ea7-9b11-6e9ecca842dc"
/>

<img width="1495" alt="Zrzut ekranu 2024-12-19 o 16 32 38"
src="https://github.com/user-attachments/assets/016c08c3-9865-4461-86a5-638e9559b202"
/>

<img width="1502" alt="Zrzut ekranu 2024-12-19 o 16 32 43"
src="https://github.com/user-attachments/assets/37a14a2d-191d-420c-940d-1de649e082fd"
/>

<img width="1491" alt="Zrzut ekranu 2024-12-19 o 16 32 47"
src="https://github.com/user-attachments/assets/e2be1e95-6fc8-4149-b1ff-2e8b8a9a0a8d"
/>

<img width="1494" alt="Zrzut ekranu 2024-12-19 o 16 32 50"
src="https://github.com/user-attachments/assets/38b17f44-e349-46ab-8069-80d1a3fd42ae"
/>

(cherry picked from commit 5539000)
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.x Could not create pull request: You have exceeded a secondary rate limit and have been temporarily blocked from content creation. Please retry your request again later. If you reach out to GitHub Support for help, please include the request ID 6F01:35EA1C:809E06:1002BD9:6781434F and timestamp 2025-01-10 15:57:04 UTC.

Manual backport

To create the backport manually run:

node scripts/backport --pr 204962

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine mentioned this pull request Jan 10, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephmilovic stephmilovic stephmilovic approved these changes

Assignees

@patrykkopycinski patrykkopycinski

Labels
backport:version Backport to applied version labels Feature:Security Assistant Security Assistant release_note:skip Skip the PR/issue when compiling release notes Team:Security Generative AI Security Generative AI v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@patrykkopycinski @elasticmachine @kibanamachine @stephmilovic