[Onboarding] Introduce search index details page locator and update all reference #205005

saarikabhasi · 2024-12-19T20:00:53Z

Summary

Introducing new locator for onboarding search_indices plugin index details page - SEARCH_INDEX_DETAILS_LOCATOR_ID.
In stack, Updated view index details usage(connector table, connector details page, search application & web crawler) to use this locator to navigate to onboarding index details page ONLY when its search - Elasticsearch solution nav
Index management view index details would use extensionService with active solution id check in search_indices plugin
verified locally existing FTR & unit tests
Added FTR for index management in functional_search tests for search solution nav and classic nav

demo.mov

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios
Flaky Test Runner was used on any tests changed

…ion is search

…saarikabhasi/kibana into onboarding/search-index-details-locator

kibanamachine · 2024-12-19T22:42:31Z

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7628

[✅] x-pack/test/functional_search/config.ts: 25/25 tests passed.
[✅] x-pack/test_serverless/functional/test_suites/observability/common_configs/config.group1.ts: 25/25 tests passed.
[✅] x-pack/test_serverless/functional/test_suites/search/common_configs/config.group1.ts: 25/25 tests passed.
[✅] x-pack/test_serverless/functional/test_suites/search/config.ts: 25/25 tests passed.
[✅] x-pack/test_serverless/functional/test_suites/security/common_configs/config.group1.ts: 25/25 tests passed.

see run history

kibanamachine · 2024-12-19T22:56:30Z

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7627

[✅] x-pack/test/api_integration/apis/search/config.ts: 25/25 tests passed.
[✅] x-pack/test/functional_search/config.ts: 25/25 tests passed.
[✅] x-pack/test_serverless/api_integration/test_suites/search/common_configs/config.group1.ts: 25/25 tests passed.
[✅] x-pack/test_serverless/api_integration/test_suites/security/common_configs/config.group1.ts: 25/25 tests passed.
[✅] x-pack/test_serverless/api_integration/test_suites/observability/common_configs/config.group1.ts: 25/25 tests passed.
[✅] x-pack/test_serverless/functional/test_suites/search/config.ts: 25/25 tests passed.

see run history

…-fix'

…saarikabhasi/kibana into onboarding/search-index-details-locator

pheyos

x-pack/test/functional/page_objects/index.ts changes LGTM

joemcelroy · 2025-01-07T09:06:17Z

x-pack/test/functional/page_objects/search_api_keys.ts

+ * 2.0.
+ */
+
+import expect from '@kbn/expect';


these tests are going to collide with Yan's changes. They are broadly similar but theres likely slight differences in approach.

I suggest we wait until @yansavitski changes are merged in then we can rebase the FTR tests.

yansavitski

LGTM

…saarikabhasi/kibana into onboarding/search-index-details-locator

...ublic/applications/applications/components/search_application/search_application_indices.tsx

TattdCodeMonkey · 2025-01-08T16:25:41Z

...plications/applications/components/search_applications/search_application_indices_flyout.tsx

+    () => share?.url.locators.get('SEARCH_INDEX_DETAILS_LOCATOR_ID'),
+    [share]
+  );
+  const SearchIndicesLinkProps = useCallback(


see other comment.

updated in 6c03f45

...enterprise_search_content/components/connector_detail/components/generated_config_fields.tsx

saarikabhasi · 2025-01-09T18:37:06Z

@elasticmachine merge upstream

TattdCodeMonkey

Updates overall looks good. We should probably do a final Flakey Test Runner job just to be safe.

TattdCodeMonkey · 2025-01-09T19:22:59Z

...plications/applications/components/search_application/search_application_view_index_link.tsx

+  return searchIndexDetailsUrl ? (
+    <EuiLink
+      data-telemetry-id={dataTelemetryId}
+      data-test-subj={'search-application-index-link'}


Should this be a prop along with data-telemetry-id ?

We could, but added here as data-test-subj value is same in both usage (flyout & search application content).

updated 359b77e

TattdCodeMonkey · 2025-01-09T19:23:49Z

...plications/applications/components/search_applications/search_application_indices_flyout.tsx

-        <EuiLink {...SearchIndicesLinkProps(indexName)}>{indexName}</EuiLink>
+        <SearchApplicationViewIndexLink
+          indexName={indexName}
+          dataTelemetryId={'entSearchApplications-list-viewIndex'}


the {} are not needed if you're passing a static string.

Suggested change

dataTelemetryId={'entSearchApplications-list-viewIndex'}

dataTelemetryId='entSearchApplications-list-viewIndex'

updated in 359b77e

TattdCodeMonkey · 2025-01-09T19:25:04Z

...nents/shared/connector_view_search_indices_details/connector_view_search_indices_details.tsx

+  return searchIndexDetailsUrl ? (
+    <EuiLink
+      target={target ? '_blank' : undefined}
+      external={target ? true : false}


optional nit

Suggested change

external={target ? true : false}

external={target ?? false}

updated in 359b77e

stale

…saarikabhasi/kibana into onboarding/search-index-details-locator

elasticmachine · 2025-01-09T21:56:08Z

💚 Build Succeeded

Buildkite Build
Commit: 9bdba15

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`enterpriseSearch`	1352	1354	+2
`searchIndices`	222	224	+2
total			+4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`enterpriseSearch`	1.6MB	1.6MB	+864.0B
`searchIndices`	164.0KB	164.0KB	-1.0B
total			+863.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`searchIndices`	7.5KB	8.2KB	+670.0B

History

💚 Build #265782 succeeded 3929ec8
💔 Build #265186 failed 8116d7d
💛 Build #264912 was flaky 601f509
💚 Build #264822 succeeded ca8dc1d
💔 Build #264553 failed 4023011
💚 Build #262552 succeeded adba282

kibanamachine · 2025-01-10T00:39:11Z

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7687

[✅] x-pack/test/functional_search/config.ts: 25/25 tests passed.
[✅] x-pack/test_serverless/functional/test_suites/observability/common_configs/config.group1.ts: 25/25 tests passed.
[✅] x-pack/test_serverless/functional/test_suites/search/common_configs/config.group1.ts: 25/25 tests passed.
[✅] x-pack/test_serverless/functional/test_suites/search/config.ts: 25/25 tests passed.
[✅] x-pack/test_serverless/functional/test_suites/security/common_configs/config.group1.ts: 25/25 tests passed.
[✅] x-pack/test_serverless/api_integration/test_suites/search/common_configs/config.group1.ts: 25/25 tests passed.
[✅] x-pack/test_serverless/api_integration/test_suites/security/common_configs/config.group1.ts: 25/25 tests passed.
[✅] x-pack/test_serverless/api_integration/test_suites/observability/common_configs/config.group1.ts: 25/25 tests passed.

see run history

saarikabhasi added 6 commits December 16, 2024 13:24

add locator, make index_management use this locator when active solut…

761d919

…ion is search

inital commit for connectors, crawler

031ad33

update search application references

acdd102

clean up

11de762

use extensionService for index_management details page view

d5c621e

clean up for ci

fd10893

saarikabhasi added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 labels Dec 19, 2024

saarikabhasi requested a review from a team as a code owner December 19, 2024 20:00

saarikabhasi added the backport:skip This commit does not require backporting label Dec 19, 2024

saarikabhasi and others added 3 commits December 19, 2024 15:24

Merge branch 'main' into onboarding/search-index-details-locator

adba282

add new route for document_search in searchIndices plugin

a813e6d

Merge branch 'onboarding/search-index-details-locator' of github.com:…

7237fb1

…saarikabhasi/kibana into onboarding/search-index-details-locator

update FTR tests for functional_search index management

adf7a89

saarikabhasi requested a review from a team as a code owner January 6, 2025 19:16

kibanamachine and others added 5 commits January 6, 2025 19:34

[CI] Auto-commit changed files from 'node scripts/yarn_deduplicate'

a504b82

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

4bd6ca6

…-fix'

fix merge conflict

0eafbd9

Merge branch 'onboarding/search-index-details-locator' of github.com:…

468f3e6

…saarikabhasi/kibana into onboarding/search-index-details-locator

remove unintended changes

4023011

pheyos approved these changes Jan 7, 2025

View reviewed changes

joemcelroy reviewed Jan 7, 2025

View reviewed changes

yansavitski approved these changes Jan 7, 2025

View reviewed changes

saarikabhasi and others added 4 commits January 7, 2025 09:52

Merge branch 'main' into onboarding/search-index-details-locator

ca8dc1d

add classic nav FTR

5df9816

Merge branch 'onboarding/search-index-details-locator' of github.com:…

601f509

…saarikabhasi/kibana into onboarding/search-index-details-locator

enable connector detail page external link to new tab

8116d7d

TattdCodeMonkey previously requested changes Jan 8, 2025

View reviewed changes

move view index to separate component

6c03f45

Merge branch 'main' into onboarding/search-index-details-locator

3929ec8

TattdCodeMonkey reviewed Jan 9, 2025

View reviewed changes

saarikabhasi added 2 commits January 9, 2025 15:31

address review comments

359b77e

Merge branch 'onboarding/search-index-details-locator' of github.com:…

9bdba15

…saarikabhasi/kibana into onboarding/search-index-details-locator

saarikabhasi requested a review from TattdCodeMonkey January 10, 2025 14:03

TattdCodeMonkey approved these changes Jan 10, 2025

View reviewed changes

saarikabhasi added the Team:Search label Jan 10, 2025

saarikabhasi merged commit 54436e3 into elastic:main Jan 10, 2025
11 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Onboarding] Introduce search index details page locator and update all reference #205005

[Onboarding] Introduce search index details page locator and update all reference #205005

saarikabhasi commented Dec 19, 2024 •

edited

Loading

kibanamachine commented Dec 19, 2024

kibanamachine commented Dec 19, 2024

pheyos left a comment

joemcelroy Jan 7, 2025

yansavitski left a comment

TattdCodeMonkey Jan 8, 2025

saarikabhasi Jan 9, 2025

saarikabhasi commented Jan 9, 2025

TattdCodeMonkey left a comment

TattdCodeMonkey Jan 9, 2025

saarikabhasi Jan 9, 2025 •

edited

Loading

saarikabhasi Jan 9, 2025

TattdCodeMonkey Jan 9, 2025

saarikabhasi Jan 9, 2025

TattdCodeMonkey Jan 9, 2025

saarikabhasi Jan 9, 2025

elasticmachine commented Jan 9, 2025

kibanamachine commented Jan 10, 2025

	dataTelemetryId={'entSearchApplications-list-viewIndex'}
	dataTelemetryId='entSearchApplications-list-viewIndex'

[Onboarding] Introduce search index details page locator and update all reference #205005

[Onboarding] Introduce search index details page locator and update all reference #205005

Conversation

saarikabhasi commented Dec 19, 2024 • edited Loading

Summary

Checklist

kibanamachine commented Dec 19, 2024

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7628

kibanamachine commented Dec 19, 2024

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7627

pheyos left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yansavitski left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

saarikabhasi commented Jan 9, 2025

TattdCodeMonkey left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

saarikabhasi Jan 9, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elasticmachine commented Jan 9, 2025

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Page load bundle

History

kibanamachine commented Jan 10, 2025

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7687

saarikabhasi commented Dec 19, 2024 •

edited

Loading

saarikabhasi Jan 9, 2025 •

edited

Loading