Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][THI] - replace deprecated EUI color variables #205173

Merged
merged 2 commits into from
Jan 10, 2025
Merged

[Security Solution][THI] - replace deprecated EUI color variables #205173

merged 2 commits into from
Jan 10, 2025
+6 −6

Conversation

PhilippeOberti
Copy link
Contributor

@PhilippeOberti PhilippeOberti commented Dec 26, 2024 •
edited
Loading

Summary

This PR is part of a list of PRs to perform the changes necessary to get the new Borealis theme working correctly. It focuses on replacing the deprecated color variables with the new ones:

previous color token -> new color token:

  • primaryText -> textPrimary
  • accentText -> textAccent
  • warningText -> textWarning
  • dangerText -> textDanger
  • text -> textParagraph
  • title -> textHeading
  • subduedText -> textSubdued
  • disabledText -> textDisabled

No UI changes are visible.

#201881

@PhilippeOberti PhilippeOberti added backport:skip This commit does not require backporting v9.0.0 Team:Threat Hunting:Investigations Security Solution Investigations Team EUI Visual Refresh labels Dec 26, 2024
@PhilippeOberti PhilippeOberti requested review from a team as code owners December 26, 2024 20:50
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

@PhilippeOberti PhilippeOberti added the release_note:skip Skip the PR/issue when compiling release notes label Dec 26, 2024
davismcphee
davismcphee approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-only review, Unified Data Table changes LGTM 👍

mgadewoll
mgadewoll approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@mgadewoll mgadewoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Changes LGTM from EUI side

@PhilippeOberti PhilippeOberti enabled auto-merge (squash) January 10, 2025 15:25
@PhilippeOberti PhilippeOberti merged commit f833b18 into elastic:main Jan 10, 2025
8 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgadewoll mgadewoll mgadewoll approved these changes

@davismcphee davismcphee davismcphee approved these changes

@christineweng christineweng christineweng approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting EUI Visual Refresh release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Investigations Team v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@PhilippeOberti @elasticmachine @christineweng @davismcphee @mgadewoll