Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [embeddable] remove embeddable class (#205164) #205434

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Jan 2, 2025

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

Part of embeddable rebuild clean-up.

Removes legacy Embeddable class and types from embeddable plugin.

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit 2ee9cbf)
@nreese nreese requested a review from kibanamachine as a code owner January 2, 2025 19:57
@nreese nreese added the backport label Jan 2, 2025
@nreese nreese enabled auto-merge (squash) January 2, 2025 19:57
@botelastic botelastic bot added Feature:Drilldowns Embeddable panel Drilldowns Feature:Embedding Embedding content via iFrame Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Jan 2, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@nreese
Copy link
Contributor Author

nreese commented Jan 2, 2025

/ci

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
aiops 612 613 +1
apm 1910 1911 +1
canvas 1271 1272 +1
cases 840 841 +1
controls 352 353 +1
dashboard 669 670 +1
dashboardEnhanced 84 85 +1
dataVisualizer 724 725 +1
discover 966 967 +1
discoverEnhanced 46 47 +1
embeddable 97 86 -11
embeddableEnhanced 44 45 +1
imageEmbeddable 131 132 +1
infra 1518 1519 +1
inputControlVis 82 83 +1
lens 1500 1501 +1
links 119 120 +1
maps 1243 1244 +1
ml 2114 2115 +1
presentationPanel 99 100 +1
presentationUtil 176 177 +1
reporting 140 141 +1
securitySolution 6456 6457 +1
slo 844 845 +1
synthetics 1020 1021 +1
urlDrilldown 48 49 +1
visualizations 475 484 +9
total +23

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/presentation-publishing 197 199 +2
dashboard 113 109 -4
embeddable 222 152 -70
total -72

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 613.8KB 613.9KB +133.0B
embeddable 1.6KB 1.6KB -1.0B
securitySolution 18.5MB 18.5MB +3.0B
visualizations 321.9KB 327.3KB +5.4KB
total +5.5KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
dashboard 13 12 -1
visualizations 21 22 +1
total -0

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
embeddable 31.5KB 22.5KB -9.0KB
urlDrilldown 17.5KB 17.5KB +38.0B
visualizations 62.3KB 62.6KB +286.0B
total -8.7KB
Unknown metric groups

API count

id before after diff
@kbn/presentation-publishing 233 235 +2
dashboard 117 113 -4
embeddable 280 179 -101
total -103

References to deprecated APIs

id before after diff
maps 33 30 -3

Unreferenced deprecated APIs

id before after diff
embeddable 1 0 -1
visualizations 0 1 +1
total -0

@nreese nreese merged commit 4122f3b into elastic:8.x Jan 2, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Feature:Drilldowns Embeddable panel Drilldowns Feature:Embedding Embedding content via iFrame Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants