Use EuiIconTip for lock icon in privileges table action #205436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
added
Team:Security
|
Pinging @elastic/kibana-security (Team:Security) |
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
tsullivan
commented
Jan 2, 2025
| 'xpack.spaces.management.spaceDetails.rolesTable.column.actions.notEditableDescription.isAssignedToAll', | ||
| { | ||
| defaultMessage: `You can't edit the access of a role that is assigned to all spaces.`, | ||
| render: (role) => { |
There was a problem hiding this comment.
This changes the action to use a custom action
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12589166501 |
💚 Build Succeeded
Metrics [docs]Async chunks
|
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12589166501 |
jbudz
added
backport:prev-minor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12601157099 |
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Jan 3, 2025
## Summary Closes elastic/kibana-team#1323 ## Screenshots **Before** https://github.com/user-attachments/assets/a7eed859-7e81-44b2-86ec-6fa542983960 **After** https://github.com/user-attachments/assets/58c2b576-4d4a-4869-8252-edd327ae7062 ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
|
The backport action is failing due to a Github incident. Created the backport manually, via cherry-picking, here: #205528 |
tsullivan
added a commit
that referenced
this pull request
Jan 3, 2025
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Jan 13, 2025
## Summary Closes elastic/kibana-team#1323 ## Screenshots **Before** https://github.com/user-attachments/assets/a7eed859-7e81-44b2-86ec-6fa542983960 **After** https://github.com/user-attachments/assets/58c2b576-4d4a-4869-8252-edd327ae7062 ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
viduni94
pushed a commit
to viduni94/kibana
that referenced
this pull request
Jan 23, 2025
## Summary Closes elastic/kibana-team#1323 ## Screenshots **Before** https://github.com/user-attachments/assets/a7eed859-7e81-44b2-86ec-6fa542983960 **After** https://github.com/user-attachments/assets/58c2b576-4d4a-4869-8252-edd327ae7062 ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes https://github.com/elastic/kibana-team/issues/1323
Screenshots
Before
skdjfhbklsdhidsofgh-before.mov
After
skdjfhbklsdhidsofgh-after.mov
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:*label is applied per the guidelines