Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Split jest config public|common|server #205798

Merged
merged 13 commits into from
Jan 10, 2025

Conversation

nchaulet
Copy link
Member

@nchaulet nchaulet commented Jan 7, 2025

Summary

Related to https://github.com/elastic/ingest-dev/issues/4683

When investigating memory locally it seems memory usage is a lot higher for server side tests, (not sure why probably need investigation here) but I think it could only help to run smaller test suites to have smaller garbage collection, and if we want to increase timeout in the future, we will be able to do only for one test suite.

@nchaulet nchaulet requested a review from a team as a code owner January 7, 2025 18:27
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Jan 7, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@nchaulet nchaulet added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Jan 7, 2025
@nchaulet
Copy link
Member Author

nchaulet commented Jan 7, 2025

@elasticmachine merge upstream

@nchaulet
Copy link
Member Author

nchaulet commented Jan 7, 2025

@elasticmachine merge upstream

@nchaulet nchaulet requested a review from kpollich January 7, 2025 23:18
@nchaulet
Copy link
Member Author

nchaulet commented Jan 8, 2025

@elasticmachine merge upstream

Copy link
Contributor

@criamico criamico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nchaulet
Copy link
Member Author

nchaulet commented Jan 8, 2025

@elasticmachine merge upstream

@nchaulet
Copy link
Member Author

nchaulet commented Jan 8, 2025

@elasticmachine merge upstream

@nchaulet
Copy link
Member Author

nchaulet commented Jan 8, 2025

@elasticmachine merge upstream

@nchaulet
Copy link
Member Author

nchaulet commented Jan 8, 2025

@elasticmachine merge upstream

@nchaulet
Copy link
Member Author

nchaulet commented Jan 8, 2025

@elasticmachine merge upstream

@nchaulet
Copy link
Member Author

nchaulet commented Jan 9, 2025

@elasticmachine merge upstream

@nchaulet nchaulet enabled auto-merge (squash) January 9, 2025 14:14
@nchaulet
Copy link
Member Author

nchaulet commented Jan 9, 2025

@elasticmachine merge upstream

@nchaulet
Copy link
Member Author

@elasticmachine merge upstream

@nchaulet nchaulet merged commit 8bb2da1 into elastic:main Jan 10, 2025
9 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12712645473

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 10, 2025
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 10, 2025
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Fleet] Split jest config public|common|server
(#205798)](#205798)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nicolas
Chaulet","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-10T15:44:06Z","message":"[Fleet]
Split jest config public|common|server
(#205798)","sha":"8bb2da19ea4e22d279df355f620790080548da00","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","backport:prev-minor"],"title":"[Fleet]
Split jest config
public|common|server","number":205798,"url":"https://github.com/elastic/kibana/pull/205798","mergeCommit":{"message":"[Fleet]
Split jest config public|common|server
(#205798)","sha":"8bb2da19ea4e22d279df355f620790080548da00"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205798","number":205798,"mergeCommit":{"message":"[Fleet]
Split jest config public|common|server
(#205798)","sha":"8bb2da19ea4e22d279df355f620790080548da00"}}]}]
BACKPORT-->

Co-authored-by: Nicolas Chaulet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants